Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMNoTitleBarWindowKey for hiding titlebar #111

Merged
merged 1 commit into from Dec 9, 2015

Conversation

splhack
Copy link
Contributor

@splhack splhack commented Nov 5, 2015

$ defaults write org.vim.MacVim MMNoTitleBarWindow true
but it's not finished yet, needs to fix the error.
ERROR: Can't have a toolbar in a window with <NSNextStepFrame: 0x7ff618f46a20> as it's borderview

@splhack splhack mentioned this pull request Nov 5, 2015
@chdiza
Copy link
Contributor

chdiza commented Nov 5, 2015

It works. There seems to be no way to move a titlebar-less window all the way flush against the right-hand edge of the screen. I have an ineliminable gap of about fix or six pixels.

splhack added a commit that referenced this pull request Dec 9, 2015
MMNoTitleBarWindowKey for hiding titlebar
@splhack splhack merged commit 11bd9b9 into master Dec 9, 2015
@splhack splhack deleted the feature/no_title_bar_window branch December 9, 2015 04:50
@bensinc
Copy link

bensinc commented Mar 5, 2017

I've tried enabling this on 10.12.1 and it does remove the titlebar, but it causes text rendering problems. The screen is gray, and any typing appears for a moment, then disappears.

I did notice that if I disable core text rendering, it does work, though I'd rather not do that.

@mirca
Copy link

mirca commented May 23, 2017

I'm experiencing the same problem as @bensinc. Any clue on that?

@KCreate
Copy link

KCreate commented Jul 7, 2017

Same problem as @bensinc. Are there any updates on how to fix this issue?

@cmcginty
Copy link

cmcginty commented Aug 29, 2017

Thanks for this so much! But when I enable this feature the window eventually turns all white. Is there a setting that might conflict with this value. Thanks for the help! Testing on Sierra 10.12.6.

@jampow
Copy link

jampow commented Dec 23, 2017

Same problem here.

macVim 8.0.1420 (144)
macOS 10.12.6

@sbrki
Copy link

sbrki commented Feb 28, 2018

Still Broken. Bump.

@omartin
Copy link

omartin commented Apr 2, 2018

Broken, can be better by removing the CoreText but still there is a white line at the top.

@acidjazz
Copy link

acidjazz commented Apr 3, 2019

@splhack finding this PR and knowing this exists made my day.

@mirca
Copy link

mirca commented Apr 3, 2019

@acidjazz it exists, which is super cool in itself (thanks @splhack); but does it work?

@acidjazz
Copy link

acidjazz commented Apr 3, 2019

@mirca works fine for me, just pasted it into terminal, started up macvim, and no more title bar.

image

@mirca
Copy link

mirca commented Apr 3, 2019

yo everybody, it's working!! @bensinc @whiteShtef @omartin @jampow @cmcginty @KCreate

@ychin
Copy link
Member

ychin commented Apr 4, 2019

Yes this should be working! In 10.13 or below it was fixed in #828 but the no-titlebar / borderless mode has some performance issues compared to normal windowed mode. In 10.14 it should work just like the normal mode.

@sbrki
Copy link

sbrki commented Apr 8, 2019

Woohoo! Thanks for implementing this.

@4fthawaiian
Copy link

found this totally by accident - makes me so happy. Thanks so much! 🥰

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet