New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gcc's -Wcast-align warnings on ARM platform #64
Comments
Thanks Takayuki. I'm slightly surprised as I was expecting |
Yeah, since it is basically Apple centric tool, I also expected the warning. But as x64 compiler, it is correct result though. |
Which raises one warning : |
Wrong hypothesis :
So it seems only the warning |
I've updated the "dev" branch with a fix which, I hope, removes the warning complaints. The only remaining issue is that I can't test it. I would like to build the ability to automate such a test within Travis CI. It would its re-appearance later on. |
Confirmed. For testing, install cross toolchain. In this case, target architecture is
|
Thanks Takayuki, it's exactly the test I was looking for. Unfortunately, it doesn't work "as is" on my test system.
Seems there are still some remaining problems with path, or some missing file/objects. |
I could get it to work by using |
Strange 😕 Just an FYI, perhaps the following procedure will show some hints (1) To ensure crt* for cross toolchain, see
(2) Add |
Good points !
By contrast :
So it's pretty clear the relevant files are simply missing. But why ? |
Merged into master |
I've got the following warnings when I build LZ4 on ARM platform (RaspberryPi Model B+ with 2015-02-16-raspbian-wheezy) :
Line #1324 in
lib/lz4.c
is-Wcast-align
is warning for alignment mismatch. Here, alignment ofLZ4_stream_t_internal
is 4 (sizeof(U32)), but alignment ofLZ4_stream_t
is 8 (sizeof(long long)).So we should maintain structure's alignment more strictly like this :
Perhaps, adding
union { long long hashTableU64[HASH_SIZE_U32/2]; ... };
is more generic and LZ4 way.Build Log
The text was updated successfully, but these errors were encountered: