Export to GitHub

lilypond - issue #837

Slow uninstallation on Windows


Posted on Sep 19, 2009 by Helpful Bear

Please DO NOT add issues directly to this tracker unless you are certain that they correspond to our preferred format.

Comment #1

Posted on Sep 19, 2009 by Helpful Bear

Ooops, sorry for having hit the Return key a bit too soon!

The current temporary 2.13.4 Win32 build installs a bunch of empty directories under /usr/docs.

Additionally, the default installation name is now GNU_LilyPond' instead of just LilyPond' (this is not a problem but we might want a space instead of an underscore, as in `Mozilla Firefox').

Comment #2

Posted on Nov 23, 2009 by Happy Camel

Fixed by this GUB commit:

http://github.com/janneke/gub/commit/af45c9cf067df8ea84c44e1c44b6de024bff88fb

By comparison, under Wine, 2.13.7 took around 15 minutes to uninstall, and 2.13.8 took about 5 minutes.

Comment #3

Posted on Dec 3, 2009 by Helpful Bear

Indeed. Thanks a lot, that was a PITA!

Comment #4

Posted on Dec 20, 2009 by Happy Rhino

There's a credible report that this is broken in 2.13.9 and 2.12.3.

Comment #5

Posted on Dec 20, 2009 by Quick Wombat

originally I was going to report this on 2.13.9 and 2.13.8 (I think), but I see that it does the same thing for me on windows 7 for 2.12.3 when I run the uninstaller app. I'll verify control panel uninstall does the same thing for 2.12.3 also.

Comment #6

Posted on Dec 20, 2009 by Quick Wombat

Yes the control panel uninstall does the same thing - takes a long time You can watch the files vanish one at a time, and I am able to simply 'del' the Lilypond Dir or move it to the trash and delete the files manually in a few seconds.

Comment #7

Posted on Dec 21, 2009 by Helpful Bird

Windows 7, Dual Core 2.2 GHz, 3GB ram.

Fifteen-plus minutes to uninstall LATEST VERSION of LilyPond (reinstalling fresh). Just to delete files???

Intolerably slow.

What more information can I give to be helpful?

Comment #8

Posted on Dec 24, 2009 by Happy Camel

You could examine the installed "files.txt" for 2.12.3, and compare it to the "files.txt" for 2.13.8, the version when this seemed to be fixed.

Also, IIUC, the uninstaller does consider every file in turn before deleting it, and this is a safety measure in case a user has a custom installation, e.g. with non-distributed Scheme code in scm/.

Comment #9

Posted on Dec 24, 2009 by Happy Rhino

Back up a moment -- James said that he "thought" that 2.13.8 didn't work, either. If that's true, then we need to figure out what's different between his windows and yours+Valentin's windows.

James, starting from a clean account (no .font or .fontcache dir, etc... I don't know what they're called on windows... could you make a new account to test this on?), please install 2.13.8 (point eight, no typo here), then uninstall it? How long does that take?

If 2.13.8 takes a long time to uninstall, then we're left making guesses about whether it's a win7 thing (if Patrick doesn't have this), or a particular version of directx (dunno why), or whatever. If 2.13.8 is fast, then the investigation is easier: we just try to figure out what's different between 2.13.8 and 2.13.9. (forget about 2.12.3 -- we're not having any more 2.12 releases, so it's a waste of time, and in any case there'll be lots of unrelated changes)

Comment #10

Posted on Dec 26, 2009 by Quick Wombat

Hello,

Installed 2.13.8 with a new account on a clean windows 7.

Same problem of slow uninstall, to show you I also took a 'movie' of the first 2 minutes of the uninstall to show you how slow it is.

The quality is rubbish, but that is to keep the size down (200kb) it's an mp4 moive file you can download from here

I'll try this on XP as I have a system here too.

Attachments

Comment #11

Posted on Dec 26, 2009 by Happy Rhino

We know how slow it is; no need for a movie. I'm really interested in the winxp time, since it worked for at least two people (presumably on XP).

Comment #12

Posted on Dec 26, 2009 by Quick Wombat

XP is as slow.

Comment #13

Posted on Dec 26, 2009 by Quick Wombat

Let me qualify some things.

My win7 tests were done on physical and virtual. The difference is the amount of RAM (2GB on Phys, 1GB of Virtual). The speed is the same for uninstall and install.

XP is only virtual (1GB of RAM).

Comment #14

Posted on Dec 26, 2009 by Happy Rhino

Valentin, how did you verify this? Did you use wine?

I just tested it on XP SP 3, and it took about 5 minutes. At first I though it was going to be longer (it seemed to be getting nowhere), but in the time it took to finish my tea, fish my laptop out of my bag, and configure it for the silly http proxy here, the uninstall finished. This was on a clean user account -- I installed it then immediately uninstalled it. BTW, the installer left usr/share/lilypond/current/dvips/ps/lilyponddefs and music-drawing-routines, and also lilypad-unicode.

I started from a newly-created user account, installed lilypond 2.13.8 into the "my documents" folder, the uninstalled it. I didn't try compiling any music (not even the intro scale).

I wouldn't expect the virtual nature of James' XP test to matter... but who knows?

Comment #15

Posted on Jan 2, 2010 by Helpful Bear

Virtual and physical, XP sp2, 32 bits: 2.13.9 took me 25 minutes to uninst, vs "only" 6 minutes for 2.13.10.

I'm marking this as fixed, but will monitor it closely in the future.

Comment #16

Posted on Jan 2, 2010 by Happy Rhino

I don't think it's fixed unless more people report success, especially since 2.13.10 didn't contain any (deliberate) fixes for this issue. If something randomly fails to work (as appears to be the case with 2.13.8, where some people had it working and others didn't), then having it randomly work on one computer hardly counts as "fixed".

Comment #17

Posted on Jan 3, 2010 by Happy Camel

As Trevor noted, the empty directory issue has been fixed, so I'll change the summary.

I discovered that the code we are using for uninstalling LilyPond was "optimized" a few days ago. Perhaps we should port this into GUB? See

http://nsis.sourceforge.net/Uninstall_only_installed_files

Comment #18

Posted on Jan 3, 2010 by Happy Rhino

Maybe. It'll be a few days before I can get to it, though.

Comment #19

Posted on Feb 13, 2010 by Happy Rhino

Report from Trevor about the 2.13.13 pre-release.

on vista, uninstall took 20 minutes, and left three files:

/usr/bin/lilypad-unicode.exe /usr/share/lilypond/current/dvips/ps/lilyponddefs.ps /usr/share/lilypond/current/dvips/ps/music-drawing-routines.ps

I don't know if this is a change in behaviour as I normally just delete or rename the lilypond directory.

Comment #20

Posted on Feb 13, 2010 by Grumpy Dog

The previous entry is a misquote. I said uninstall took exactly 10 mins, not 20.

Trevor

Comment #21

Posted on Feb 13, 2010 by Happy Rhino

Sorry, that was a typo. I was definitely thinking "10 minutes".

Comment #22

Posted on Jul 11, 2010 by Happy Camel

Updating the NSIS script appears to work great (testing with Wine). I'll test on Windows shortly.

Comment #23

Posted on Jul 11, 2010 by Happy Camel

On Windows XP Home, with these changes, uninstall takes about 20 seconds! :)

I'll submit my changes.

Comment #24

Posted on Jul 11, 2010 by Happy Camel

And... the issue from comment 19 (leftover files) is now filed as Issue 1179.

Comment #25

Posted on Jul 13, 2010 by Happy Camel

A patch has been posted: http://lists.gnu.org/archive/html/lilypond-devel/2010-07/msg00184.html

Comment #26

Posted on Jul 13, 2010 by Happy Camel

(No comment was entered for this change.)

Comment #27

Posted on Jul 16, 2010 by Happy Camel

I didn't measure the time when verifying issue 1179, but it certainly was something between 10 and 20 seconds on my approximately 5 year old XP machine.

Status: Verified

Labels:
Type-Build Priority-Low OpSys-Windows Patch fixed_2_13_28