Export to GitHub

lilypond - issue #3890

Patch: Add dodecaphonic-first accidental style


Posted on Mar 25, 2014 by Happy Camel

Add dodecaphonic-first accidental style

This accidental style assigns accidentals to all pitches (just as dodecaphonic does) but remembers them throughout a whole measure. This style is useful for different styles of contemporary notation that want to make use of the non-tonal dodecaphonic style but don't want to print so many redundant accidentals.

http://codereview.appspot.com/79680044

Comment #1

Posted on Mar 25, 2014 by Happy Camel

(No comment was entered for this change.)

Comment #2

Posted on Mar 25, 2014 by Quick Kangaroo

Patchy the autobot says: passes make, make check and a full make doc.

Comment #3

Posted on Mar 26, 2014 by Happy Camel

Issue 3889 has been merged into this issue.

Comment #4

Posted on Mar 29, 2014 by Quick Kangaroo

Patch on countdown for April 1 - 06:00 GMT

Comment #5

Posted on Apr 1, 2014 by Quick Bird

I haven't been able to do more than verify that this patch does what it is intended to do -- it does. I'm sorry that I don't have the brain function at the moment to give this a detailed look.

(I wonder if it would be a good idea to do some consolidation of the dodecaphonic code in future.)

Comment #6

Posted on Apr 1, 2014 by Quick Kangaroo

Patch counted down - please push (Note: Do we need some extra doc for anything, if so can you create a new tracker?)

Comment #7

Posted on Apr 4, 2014 by Quick Kangaroo

author Urs Liska Tue, 25 Mar 2014 10:59:54 +0000 (11:59 +0100) committer Benkő Pál Tue, 1 Apr 2014 20:00:08 +0000 (22:00 +0200) commit b03be2f2cdd9ed43a4bcaa3091965c2f63e7146e

Comment #8

Posted on Apr 21, 2014 by Massive Bear

(No comment was entered for this change.)

Status: Verified

Labels:
Type-Enhancement Fixed_2_19_4