Export to GitHub

lilypond - issue #3818

Patch: stencil.scm: add make-path-stencil function


Posted on Jan 18, 2014 by Grumpy Dog

stencil.scm: add make-path-stencil function

supports all path commands both relative and absolute: lineto, rlineto, curveto, rcurveto, moveto, rmoveto, closepath also supports single letter syntax used in standard SVG path commands: L, l, C, c, M, m, Z, z. Refactors make-connected-path-stencil for backwards compatibility and continued use

http://codereview.appspot.com/54050043

Comment #1

Posted on Jan 18, 2014 by Quick Kangaroo

Patchy the autobot says: passes make, make check and a full make docs.

Comment #2

Posted on Jan 21, 2014 by Quick Kangaroo

Patch on countdown for Jan 24th - 06:00 GMT

Comment #3

Posted on Jan 23, 2014 by Grumpy Dog

Attempting to change label to "new" to trigger automated tests. I don't see any interface for editing labels, just this comment field and a link to attach a file. (Maybe I don't have sufficient privileges to edit labels?) Maybe you just enter them as text here in the comment? Here goes, but I doubt this will work, except maybe for comic effect...

Labels: -Patch-countdown Patch-new

Comment #4

Posted on Jan 23, 2014 by Grumpy Dog

(No comment was entered for this change.)

Comment #5

Posted on Jan 24, 2014 by Quick Kangaroo

Patchy the autobot says: passes make, make check and a full make doc.

Comment #6

Posted on Jan 27, 2014 by Quick Kangaroo

Patch on countdown for Jan 30th - 06:00 GMT

Comment #7

Posted on Jan 30, 2014 by Quick Kangaroo

Patch counted down - Paul as you possibly don't have git push permissions, can you attach a git-formatted patch based on current master (or you can send it to the dev list direct) and someone can push it for you.

Comment #8

Posted on Jan 30, 2014 by Grumpy Dog

Ok, I've attached the two patch files, based on current master, created using lily-git.tcl. Would someone please push them for me? Thanks in advance.

Attachments

Comment #9

Posted on Jan 30, 2014 by Quick Kangaroo

stencil.scm: add make-path-stencil function

authorPaul Morris Sat, 18 Jan 2014 03:53:26 +0000 (22:53 -0500) committerJames Lowe Thu, 30 Jan 2014 20:00:59 +0000 (20:00 +0000) commit2348fa9c19d9884469911f17dac9ad1f93b13363

and

stencil.scm: minor edits, doc strings, comments staging

authorPaul Morris Tue, 21 Jan 2014 02:00:05 +0000 (21:00 -0500) committerJames Lowe Thu, 30 Jan 2014 20:00:59 +0000 (20:00 +0000) commit79c105dd1767b5e272fc3429b95b1b699fa5366b

Comment #10

Posted on Feb 3, 2014 by Happy Camel

(No comment was entered for this change.)

Status: Verified

Labels:
Type-Enhancement Fixed_2_19_2