Export to GitHub

lilypond - issue #2914

Patch: prevent collision of ligatures and next note


Posted on Oct 18, 2012 by Quick Cat

prevent collision of ligatures and next note

http://codereview.appspot.com/6740046

Comment #1

Posted on Oct 18, 2012 by Quick Cat

the attachments are generated from the file below. I haven't added it to the regtest because I feel this sort of collision depends on too much unknowns - I wouldn't be surprised if this particular example looked totally ok in older versions.

----------------------------------------------------->8 \version "2.17.4"

\layout { \context { \MensuralStaff \override BarLine #'stencil = ##f createSpacing = ##f }

\context { \Score \override SpacingSpanner #'packed-spacing = ##t \override SpacingSpanner #'shortest-duration-space = #0.0 \override SpacingSpanner #'spacing-increment = #0.0 } }

\new MensuralStaff { \clef "petrucci-c4" [ e\longa f g a b ] d [ b c ] e }

Attachments

Comment #2

Posted on Oct 18, 2012 by Quick Kangaroo

Patchy the autobot says: passes tests.

Reg test attached

Attachments

Comment #3

Posted on Oct 22, 2012 by Happy Camel

(No comment was entered for this change.)

Comment #4

Posted on Oct 23, 2012 by Quick Cat

(No comment was entered for this change.)

Comment #5

Posted on Oct 23, 2012 by Quick Cat

prevent collision of ligatures and next note

http://codereview.appspot.com/6740046

Comment #6

Posted on Oct 23, 2012 by Quick Cat

Comment deleted

Comment #7

Posted on Oct 23, 2012 by Quick Cat

regtest diff is similar to the previous one - I still can't see the difference, which annoys me a bit since I remember changes (e.g. with the repeat dot placement issues) that I saw but the regtest didn't show.

Comment #8

Posted on Oct 23, 2012 by Quick Kangaroo

Patchy says - passes make and make tests.

Reg test diff attached

Attachments

Comment #9

Posted on Oct 26, 2012 by Happy Camel

(No comment was entered for this change.)

Comment #10

Posted on Oct 29, 2012 by Happy Camel

Counted down to 20121028, please push.

Comment #11

Posted on Oct 29, 2012 by Quick Cat

pushed to staging as

6d62217ac79d7a31f8258a2f7a6dabbacbb8670a prevent collision of mensural ligature and next grob f24c42f2581c987d333e87916bf5805ead86a24b pass by reference-to-const, not by value

Comment #12

Posted on Oct 30, 2012 by Quick Cat

reached master as 5cb09f71fea59c7bdbcb3c1dcb1151bbf19b4d26 prevent collision of mensural ligature and next grob d2caa06715a7214166ee401501160370b0d1479e pass by reference-to-const, not by value

Comment #13

Posted on Nov 5, 2012 by Happy Camel

(No comment was entered for this change.)

Status: Verified

Labels:
Type-Enhancement fixed_2_17_6