Export to GitHub

lilypond - issue #2806

Patch: part-combiner.scm: replace use of "when" with "moment"


Posted on Sep 3, 2012 by Quick Lion

part-combiner.scm: replace use of "when" with "moment"

"when" is already a macro in Guilev2.

http://codereview.appspot.com/6500069

Comment #1

Posted on Sep 3, 2012 by Swift Camel

Build results are available at

http://grenouille.lilynet.net/patches-tests/2806/test-results

17:56:16 (UTC) Begin LilyPond compile, previous commit at 1ce92ec5c984dfc05c3431a9f4185b453b457656 17:56:26 Success: No new commits in master 17:58:09 Using test baseline from previous build.

17:58:09 Issue 2806: Patch: part-combiner.scm: replace use of "when" with "moment" 17:58:09 Issue 2806: Testing patch issue6500069_1_diff 17:58:09 Success: sudo -u lilybuild git apply --index /home/jmandereau/lily-test-patches/issue6500069_1.diff 17:58:11 Success: sudo -u lilybuild ./autogen.sh --noconfigure 17:58:37 Success: sudo -u lilybuild /home/lilybuild/master/configure --disable-optimising 17:58:46 Success: sudo -u lilybuild nice make clean 18:14:01 Success: sudo -u lilybuild nice make -j2 CPU_COUNT=2 ANTI_ALIAS_FACTOR=1 18:36:54 Success: sudo -u lilybuild nice make check -j2 CPU_COUNT=2 ANTI_ALIAS_FACTOR=1

Comment #2

Posted on Sep 3, 2012 by Quick Kangaroo

Why isn't grenouille setting patches to -review?

I've just tested this manually, it fails by the way - lots of 'programming errors' in the reg test.

James

Comment #3

Posted on Sep 3, 2012 by Happy Lion

I think that automatic status-changing was disabled while John's still working on the code.

Comment #4

Posted on Sep 8, 2012 by Quick Lion

(No comment was entered for this change.)

Comment #5

Posted on Sep 9, 2012 by Quick Lion

part-combiner.scm: replace use of "when" with "moment"

"when" is already a macro in Guilev2.

http://codereview.appspot.com/6500069

Comment #6

Posted on Sep 9, 2012 by Quick Lion

Patchy the autobot says: passes tests. My Patchy does not show any programming error. Can you please recheck?

Comment #7

Posted on Sep 10, 2012 by Happy Camel

(No comment was entered for this change.)

Comment #8

Posted on Sep 12, 2012 by Happy Camel

Count6ed down to 20120911, please push.

Comment #9

Posted on Sep 12, 2012 by Quick Lion

Pushed to staging as commit f57c55d075245079074dda3245d5baa39b3726bb Author: David Kastrup Date: Mon Sep 3 19:23:51 2012 +0200

Issue 2806: part-combiner.scm: replace use of "when" with "moment"

"when" is already a macro in Guilev2.

Comment #10

Posted on Sep 24, 2012 by Happy Camel

(No comment was entered for this change.)

Status: Verified

Labels:
Type-Maintainability Fixed_2_17_3