Export to GitHub

lilypond - issue #2742

Patch: Add support for Cyrillic in texinfo.


Posted on Aug 13, 2012 by Helpful Dog

Add support for Cyrillic in texinfo.

http://codereview.appspot.com/6459081

Comment #1

Posted on Aug 13, 2012 by Quick Lion

What is this change intended to be used for?

Comment #2

Posted on Aug 13, 2012 by Quick Kangaroo

Patchy the autobot says: passes tests.

Comment #3

Posted on Aug 13, 2012 by Helpful Dog

With this change, Cyrillic characters get displayed in PDF documents produced by texinfo.

Comment #4

Posted on Aug 13, 2012 by Quick Kangaroo

Hello, while this passes a make and make test, this fails a full make doc based on current master

--snip-- pond-git/build/out/lybook-db/91/lily-18ad7e70-1.pdf>) (./f7/lily-abcb712a.texidoc) [185] (./f7/lily-abcb712a-systems.texi ) (./81/lily-f1520e7b.texidoc) Overfull \hbox (102.37863pt too wide) in paragraph at lines 1744--1744 [][] | (./81/lily-f1520e7b-systems.texi ) [186] (./dc/lily-0beb8ca9.texidoc) (./dc/lily-0beb8ca9-systems.texi ) (./3d/lily-47a03893.texidoc) [187] kpathsea: Running mktextfm latt1095 mktextfm: Running mf-nowin -progname=mf \mode:=ljfour; mag:=1; nonstopmode; input latt1095 This is METAFONT, Version 2.718281 (TeX Live 2009/Debian)

kpathsea: Running mktexmf latt1095

! I can't find file `latt1095'. <*> ...ljfour; mag:=1; nonstopmode; input latt1095

Please type another input file name ! Emergency stop. <*> ...ljfour; mag:=1; nonstopmode; input latt1095

Transcript written on mfput.log. grep: latt1095.log: No such file or directory mktextfm: `mf-nowin -progname=mf \mode:=ljfour; mag:=1; nonstopmode; input latt1095' failed to make latt1095.tfm. kpathsea: Appending font creation commands to missfont.log.

./text.texi:1903: Font @thiscyrfont=latt1095 at 11.0pt not loadable: Metric (TF M) file not found. @thiscyrfont @CYRZH ->{@cyrfont @char 198} ...nt^^Mbulgarian = \lyricmode {^^M Ж ълтата дюля бе...

@doverbatim #1^^M#2@end verbatim->#2 @end verbatim l.1903 @end verbatim

? ./text.texi:1903: Emergency stop. @thiscyrfont @CYRZH ->{@cyrfont @char 198} ...nt^^Mbulgarian = \lyricmode {^^M Ж ълтата дюля бе...

@doverbatim #1^^M#2@end verbatim->#2 @end verbatim l.1903 @end verbatim

./text.texi:1903: ==> Fatal error occurred, no output PDF file produced! Transcript written on snippets.log. /usr/bin/texi2dvi: pdfetex exited with bad status, quitting.

--snip--

James

Comment #5

Posted on Aug 13, 2012 by Quick Lion

Well, at least that reduces the likelihood of Patchy-staging still pushing the change to master.

Comment #6

Posted on Aug 13, 2012 by Helpful Dog

Sigh. It seems that Debian TeXLive 2009 installs the cm-super fonts without its Cyrillic support files. Please install the LH package.

I'm running a full TeXLive which doesn't exhibit this problem.

Comment #7

Posted on Aug 13, 2012 by Helpful Dog

Given the reported problem, there are high chances that LH files are missing in lilydev also. Can someone check please whether the file `fikparm.mf' is available?

Comment #8

Posted on Aug 18, 2012 by Swift Camel

Build results are available at

http://grenouille.lilynet.net/patches-tests/2742/

01:05:18 (UTC) Begin LilyPond compile, previous commit at 229e78d781e24469d65e47244fb6eb161be84621 01:05:28 Success: sudo -u lilybuild ./autogen.sh --noconfigure 01:05:56 Success: sudo -u lilybuild ../configure --disable-optimising 01:06:06 Success: sudo -u lilybuild nice make clean 01:22:38 Success: sudo -u lilybuild nice make -j2 CPU_COUNT=2 ANTI_ALIAS_FACTOR=1 01:42:08 Success: sudo -u lilybuild nice make test-baseline -j2 CPU_COUNT=2 ANTI_ALIAS_FACTOR=1

02:20:23 Success: git apply --index /home/jmandereau/lilypond-extra/patches/issue6459081_1.diff 02:20:24 Success: sudo -u lilybuild ./autogen.sh --noconfigure 02:20:53 Success: sudo -u lilybuild ../configure --disable-optimising 02:21:02 Success: sudo -u lilybuild nice make clean 02:37:35 Success: sudo -u lilybuild nice make -j2 CPU_COUNT=2 ANTI_ALIAS_FACTOR=1 02:58:13 Success: sudo -u lilybuild nice make check -j2 CPU_COUNT=2 ANTI_ALIAS_FACTOR=1

Comment #9

Posted on Aug 28, 2012 by Happy Kangaroo

I just installed lilydev, and it misses some Cyrillic fonts or support files indeed. LH TeX package can be installed in Ubuntu by installing texlive-lang-cyrillic (texlive-texmf-fonts on Fedora).

I'm preparing a newer version of the patch that adds a configure check.

Comment #10

Posted on Aug 28, 2012 by Happy Kangaroo

Add support for Cyrillic in Texinfo/TeX

This is a follow-up of Rietveld Issue 6459081.

http://codereview.appspot.com/6492045

Comment #11

Posted on Aug 28, 2012 by Happy Kangaroo

Note to Patchy testers: you should install texlive-lang-cyrillic (or texlive-texmf-fonts in Fedora) before testing this patch.

Comment #12

Posted on Aug 28, 2012 by Happy Kangaroo

Add support for Cyrillic in Texinfo/TeX

This is a follow-up of Rietveld Issue 6459081.

http://codereview.appspot.com/6492045

Comment #13

Posted on Aug 28, 2012 by Quick Kangaroo

Patchy the autobot says: passes tests.

Comment #14

Posted on Aug 29, 2012 by Happy Camel

(No comment was entered for this change.)

Comment #15

Posted on Aug 29, 2012 by Happy Kangaroo

Add support for Cyrillic in Texinfo/TeX

This is a follow-up of Rietveld Issue 6459081.

http://codereview.appspot.com/6492045

Comment #16

Posted on Aug 29, 2012 by Swift Camel

Build results are available at

http://grenouille.lilynet.net/patches-tests/2742/test-results

13:56:31 (UTC) Begin LilyPond compile, previous commit at 1cdcb2f73f35834fef5cbbc2a6647a11ae468f85 13:56:38 From git.savannah.gnu.org:/srv/git/lilypond 1cdcb2f..66a7c3e master -> master 13:56:49 Merged master, now at: 66a7c3e925cbc1a34eaad04f80d4bc42ad9834ac 13:56:51 Success: sudo -u lilybuild ./autogen.sh --noconfigure 13:57:28 Success: sudo -u lilybuild /home/lilybuild/master/configure --disable-optimising 13:57:38 Success: sudo -u lilybuild nice make clean 14:13:02 Success: sudo -u lilybuild nice make -j2 CPU_COUNT=2 ANTI_ALIAS_FACTOR=1 14:34:46 Success: sudo -u lilybuild nice make test-baseline -j2 CPU_COUNT=2 ANTI_ALIAS_FACTOR=1

19:48:35 Issue 2742: Patch: Add support for Cyrillic in texinfo. 19:48:35 Issue 2742: Testing patch issue6492045_2003_diff 19:48:35 Success: sudo -u lilybuild git apply --index /home/jmandereau/lily-test-patches/issue6492045_2003.diff 19:48:37 Success: sudo -u lilybuild ./autogen.sh --noconfigure 19:49:05 Success: sudo -u lilybuild /home/lilybuild/master/configure --disable-optimising 19:49:14 Success: sudo -u lilybuild nice make clean 20:04:35 Success: sudo -u lilybuild nice make -j2 CPU_COUNT=2 ANTI_ALIAS_FACTOR=1 20:27:09 Success: sudo -u lilybuild nice make check -j2 CPU_COUNT=2 ANTI_ALIAS_FACTOR=1

Comment #17

Posted on Aug 30, 2012 by Quick Kangaroo

When I run Patchy test it fails on configure

--snip-

ERROR: Please install required programs: lh CTAN package (texlive-lang-cyrillic or texlive-texmf-fonts)

--snip--

This isn't standard as far as I can tell on LilyDev

I guess we need to make this a pre-req?

Comment #18

Posted on Aug 30, 2012 by Happy Lion

Yes please. Actually, as a general note, could you start making a list of what software needs to be installed on top of ubuntu 12.04 ? it's time to start preparing lilydev 3.0.

(and yes, GUB works on 12.04. and yes, this may require finding another way of creating the remix if the old program doesn't work on 12.04)

Comment #19

Posted on Aug 30, 2012 by Happy Kangaroo

James, on one hand it is good that you haven't read comment 11, so you could verify that configure fails nicely and tells you which package to install to satisfy the pre-req (texlive-lang-cyrillic on LilyDev). I've added a note to issue 2538 "LilyDev 3".

Tests passed on Grenouille (which has texlive-lang-cyrillic installed from Debian/unstable), so setting to Patch-review.

Comment #20

Posted on Aug 30, 2012 by Quick Lion

Regarding comment #18: "could you start making a list of what software needs to be installed on top of ubuntu 12.04": maybe it is worth turning gub into a .deb package so that we can then just do

sudo apt-get install build-dep gub

and have all dependencies we need. At the current point of time, knowledge about the dependencies is passed by mouth and trial and error. Particularly given the costs of a failed build and the desirability of more people being able to juggle with releases, condensing this wisdom into a spec file might be less painful in the long run.

Comment #21

Posted on Aug 30, 2012 by Happy Kangaroo

Comment 20 belongs to issue 2538, I copied it there.

Comment #22

Posted on Aug 30, 2012 by Happy Lion

As far as GUB is concerned, John and I have discussed adding some kind of checks (like "configure") to GUB such that it dies if you don't have the right dependencies. I don't think that a .deb is ideal since some people (like John) run it on Fedora.

Comment #23

Posted on Aug 31, 2012 by Happy Camel

(No comment was entered for this change.)

Comment #24

Posted on Sep 3, 2012 by Happy Camel

Counted down to 20120902, please push.

Comment #25

Posted on Sep 6, 2012 by Happy Kangaroo

Pushed to staging as commit 3cd24002639b7b48a9f0c7245101bdb721ce21c0 Author: Werner Lemberg Date: Tue Aug 28 18:05:18 2012 +0200

Add support for Cyrillic in Texinfo/TeX

Comment #26

Posted on Sep 6, 2012 by Happy Kangaroo

(No comment was entered for this change.)

Comment #27

Posted on Sep 11, 2012 by Happy Camel

(No comment was entered for this change.)

Status: Verified

Labels:
Type-Enhancement fixed_2_17_2