Export to GitHub

lilypond - issue #2515

Patch: staff_radius fixes

Posted on May 5, 2012 by Quick Cat

staff_radius fixes

  1. implementation does not assume staff centred at zero
  2. where used for determining whether within staff or not, use new function Staff_symbol_referencer::staff_span instead

http://codereview.appspot.com/6202048

Comment #1

Posted on May 5, 2012 by Quick Kangaroo

Patchy the autobot says: LGTM.

Comment #2

Posted on May 7, 2012 by Happy Camel

(No comment was entered for this change.)

Comment #3

Posted on May 7, 2012 by Quick Cat

staff_radius fixes

  1. implementation does not assume staff centred at zero
  2. where used for determining whether within staff or not, use new function Staff_symbol_referencer::staff_span instead

http://codereview.appspot.com/6202048

Comment #4

Posted on May 7, 2012 by Quick Kangaroo

Patchy the autobot says: LGTM.

Comment #5

Posted on May 9, 2012 by Happy Camel

(No comment was entered for this change.)

Comment #6

Posted on May 11, 2012 by Happy Camel

Counted down to 20120510, please push

Comment #7

Posted on May 11, 2012 by Happy Camel

(No comment was entered for this change.)

Comment #8

Posted on May 11, 2012 by Quick Lion

Pál, would you suggest I push this for you?

Comment #9

Posted on May 11, 2012 by Quick Cat

yes, please, thank you very much!

Comment #10

Posted on May 11, 2012 by Quick Lion

Pushed as 387a298cdf6e9a987e7bc4f8fc0db6a89d0f6d5a to staging.

Comment #11

Posted on May 25, 2012 by Happy Camel

(No comment was entered for this change.)

Status: Verified

Labels:
Type-Enhancement Fixed_2_15_39