Export to GitHub

lilypond - issue #2378

Patch: Various updates to reduce make doc output


Posted on Mar 4, 2012 by Happy Wombat

Various updates to reduce make doc output

http://codereview.appspot.com/5727055

Comment #1

Posted on Mar 4, 2012 by Quick Lion

Patchy the autobot says: LGTM.

Comment #2

Posted on Mar 5, 2012 by Happy Camel

(No comment was entered for this change.)

Comment #3

Posted on Mar 5, 2012 by Happy Lion

Julien and I have concerns about modifying the default behaviour of a few python scripts; we think they should be changed to take a --quiet option.

Comment #4

Posted on Mar 6, 2012 by Happy Wombat

I'm happy to address those comments, but it'll be the weekend at the earliest.

Comment #5

Posted on Mar 11, 2012 by Happy Wombat

GNUmakefile: pushes lilypond output to a logfile. Using $(*F) for the filename since the target name includes the directory. GNUmakefile.in: heeltap from previous patch lilypond-book-rules.make: removes output from pdflatex and prevents it requesting input if it fails. lysdoc-rules.make: Gets rid of echoed progress message abc2ly.py; lys-to-tely.py; midi2ly.py: Gets rid of progress message.

http://codereview.appspot.com/5727055

Comment #6

Posted on Mar 11, 2012 by Happy Wombat

GNUmakefile: pushes lilypond output to a logfile. Using $(*F) for the filename since the target name includes the directory. GNUmakefile.in: heeltap from previous patch lilypond-book-rules.make: removes output from pdflatex and prevents it requesting input if it fails. lysdoc-rules.make: Gets rid of echoed progress message abc2ly.py; lys-to-tely.py; midi2ly.py: Gets rid of progress message.

http://codereview.appspot.com/5727055

Comment #7

Posted on Mar 11, 2012 by Quick Lion

Patchy the autobot says: LGTM.

Comment #8

Posted on Mar 12, 2012 by Happy Camel

(No comment was entered for this change.)

Comment #9

Posted on Mar 12, 2012 by Happy Wombat

Haven't actually updated the makefiles to add the --quiet flag. Will do so later today. Please leave on countdown.

Comment #10

Posted on Mar 12, 2012 by Happy Wombat

GNUmakefile: pushes lilypond output to a logfile. GNUmakefile.in: heeltap from previous patch lilypond-book-rules.make: removes output from pdflatex and prevents it requesting input if it fails. lysdoc-rules.make: Gets rid of echoed progress message abc2ly.py; lys-to-tely.py; midi2ly.py: Gets rid of progress message using a --quiet flag.

http://codereview.appspot.com/5727055

Comment #11

Posted on Mar 12, 2012 by Quick Lion

Patchy the autobot says: LGTM.

Comment #12

Posted on Mar 16, 2012 by Happy Camel

(No comment was entered for this change.)

Comment #13

Posted on Mar 18, 2012 by Happy Wombat

Pushed as 61f11056af686fde87a1b82936cf2a073b017b88

Comment #14

Posted on Mar 20, 2012 by Swift Dog

Verified that the committish for this patch was part of the 2.15.34 release.

Status: Verified

Labels:
Type-Patch Fixed_2_15_34