New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add install make target & pkg-config file #2
Conversation
@tfarina is this OK? Thanks - |
735fc09
to
803d692
Compare
Hi - could I get a review for this PR? Thanks - |
Ping! Over one year old :( |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
ping! Over another year! Why this PR is stuck by CLA? |
CLAs look good, thanks! |
Is there something specific blocking this? |
Hey, installing this is really inconvenient without the install target, please accept this pr already. |
ba8a445 Prefer std::atomic over MemoryBarrier (Pieter Wuille) Tree-SHA512: d25e9d2b3d149a16b3083515993f5e9a02576d6a6b58a39bdd3307a099c5656def5ac39d3bb25e9f638830de76b960b409bd8414df1ced3ed22794d8a6ab6f82
Ping @pwnall - you've committed quite a lot recently, can you help? Thanks - |
We're planning to switch to CMake, at which point the Makefile will be removed. I'm sorry I haven't had time to complete the migration earlier, and thus caused you to spend time on this PR. In case you're wondering, the CMake migration is blocked on changes needed to the internal codebase, so we can't get external help on that. |
@pwnall thanks for the update! It'd be great if the cmake build generate a pkg-config file - otherwise I'll port this PR over when it's released... |
Needs rebase if still relevant, I guess. |
Would be awesome if this would be implemented :) Any plans @njwhite? |
I'm going to close this PR, because it targets the now-removed Make-based build system. The CMake configuration includes install support -- please try it out and see if it works for you. |
Any plans for a pkg-config file though? As I'm having trouble making Swift bindings without it |
Fixes 138 and 139.