Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add install make target & pkg-config file #2

Closed
wants to merge 1 commit into from

Conversation

njwhite
Copy link

@njwhite njwhite commented Aug 29, 2014

Fixes 138 and 139.

@njwhite
Copy link
Author

njwhite commented Sep 4, 2014

@tfarina is this OK? Thanks -

@njwhite
Copy link
Author

njwhite commented Dec 1, 2014

Hi - could I get a review for this PR? Thanks -

@FreemanFeng FreemanFeng mentioned this pull request Dec 12, 2014
@bok
Copy link

bok commented Feb 24, 2015

This PR fixes #144 and #145. I have successfully tested the changes in a Debian wheezy environment.

Can this be merged please?

@njwhite
Copy link
Author

njwhite commented Feb 24, 2016

Ping! Over one year old :(

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@njwhite
Copy link
Author

njwhite commented Feb 28, 2016

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@antran89
Copy link

antran89 commented Apr 27, 2016

ping! Over another year! Why this PR is stuck by CLA?

@googlebot
Copy link

CLAs look good, thanks!

@njwhite
Copy link
Author

njwhite commented May 3, 2016

@antran89 oops, the email address I committed as wasn't the one linked to my Github account. All fixed (and rebased, it's been two years)!

CC @cmumford

@icholy
Copy link

icholy commented Jan 4, 2017

Is there something specific blocking this?

@kcolford
Copy link

Hey, installing this is really inconvenient without the install target, please accept this pr already.

isaachier pushed a commit to isaachier/leveldb that referenced this pull request Dec 3, 2017
ba8a445 Prefer std::atomic over MemoryBarrier (Pieter Wuille)

Tree-SHA512: d25e9d2b3d149a16b3083515993f5e9a02576d6a6b58a39bdd3307a099c5656def5ac39d3bb25e9f638830de76b960b409bd8414df1ced3ed22794d8a6ab6f82
isaachier added a commit to isaachier/leveldb that referenced this pull request Dec 4, 2017
@njwhite
Copy link
Author

njwhite commented Feb 25, 2018

Ping @pwnall - you've committed quite a lot recently, can you help? Thanks -

@google google deleted a comment from pirter Feb 26, 2018
@pwnall
Copy link
Member

pwnall commented Feb 26, 2018

We're planning to switch to CMake, at which point the Makefile will be removed.

I'm sorry I haven't had time to complete the migration earlier, and thus caused you to spend time on this PR.

In case you're wondering, the CMake migration is blocked on changes needed to the internal codebase, so we can't get external help on that.

@njwhite
Copy link
Author

njwhite commented Feb 26, 2018

@pwnall thanks for the update! It'd be great if the cmake build generate a pkg-config file - otherwise I'll port this PR over when it's released...

@maflcko
Copy link
Contributor

maflcko commented Apr 17, 2018

Needs rebase if still relevant, I guess.

@JaapWijnen
Copy link

JaapWijnen commented Mar 5, 2019

Would be awesome if this would be implemented :) Any plans @njwhite?

@pwnall
Copy link
Member

pwnall commented Mar 5, 2019

I'm going to close this PR, because it targets the now-removed Make-based build system.

The CMake configuration includes install support -- please try it out and see if it works for you.

@pwnall pwnall closed this Mar 5, 2019
@JaapWijnen
Copy link

Any plans for a pkg-config file though? As I'm having trouble making Swift bindings without it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants