Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement signal handling #4

Closed
jmmv opened this issue Feb 22, 2014 · 2 comments
Closed

Implement signal handling #4

jmmv opened this issue Feb 22, 2014 · 2 comments
Labels

Comments

@jmmv
Copy link
Member

jmmv commented Feb 22, 2014

From jmmv@google.com on December 05, 2010 04:54:04

If kyua receives a signal while the test case's body or cleanup routines are being executed, kyua will die and the temporary directory in which the test case runs will not be cleaned up.

Kyua should install signal handlers for all possible signals so that, when received, the test case body/cleanup is forcibly terminated (by killing the process group in which they run), the work directory is cleaned up, the signal handler is uninstalled, and Kyua sends the signal again to itself (to trigger any previously-set signal handler).

When receiving the signal during the execution of the body, we probably need to execute cleanup... but that may add an annoying delay to the user. Be sure to report on the console what's going on (and a second signal should kill the cleanup immediately).

Original issue: http://code.google.com/p/kyua/issues/detail?id=4

@jmmv
Copy link
Member Author

jmmv commented Feb 22, 2014

From jmmv@google.com on June 05, 2011 11:04:03

This issue was closed by revision r139 .

Status: Fixed

@jmmv
Copy link
Member Author

jmmv commented Feb 22, 2014

From jmmv@julipedia.org on June 05, 2011 11:04:56

Looks like the ticket update comment in r139 did not propagate to the ticket, so posting by hand for future reference:

This seems to work fine in all cases I tried and in the automated tests
for this new feature. That said, I am sure there is some corner case
that is not covered and will result in turds being left behind after a
user cancels the execution. However, because I have not been able to
uncover these cases at the moment, I see no value in keeping the ticket
open. So... one less thing to do before 0.1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant