You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If kyua receives a signal while the test case's body or cleanup routines are being executed, kyua will die and the temporary directory in which the test case runs will not be cleaned up.
Kyua should install signal handlers for all possible signals so that, when received, the test case body/cleanup is forcibly terminated (by killing the process group in which they run), the work directory is cleaned up, the signal handler is uninstalled, and Kyua sends the signal again to itself (to trigger any previously-set signal handler).
When receiving the signal during the execution of the body, we probably need to execute cleanup... but that may add an annoying delay to the user. Be sure to report on the console what's going on (and a second signal should kill the cleanup immediately).
Looks like the ticket update comment in r139 did not propagate to the ticket, so posting by hand for future reference:
This seems to work fine in all cases I tried and in the automated tests
for this new feature. That said, I am sure there is some corner case
that is not covered and will result in turds being left behind after a
user cancels the execution. However, because I have not been able to
uncover these cases at the moment, I see no value in keeping the ticket
open. So... one less thing to do before 0.1!
From jmmv@google.com on December 05, 2010 04:54:04
If kyua receives a signal while the test case's body or cleanup routines are being executed, kyua will die and the temporary directory in which the test case runs will not be cleaned up.
Kyua should install signal handlers for all possible signals so that, when received, the test case body/cleanup is forcibly terminated (by killing the process group in which they run), the work directory is cleaned up, the signal handler is uninstalled, and Kyua sends the signal again to itself (to trigger any previously-set signal handler).
When receiving the signal during the execution of the body, we probably need to execute cleanup... but that may add an annoying delay to the user. Be sure to report on the console what's going on (and a second signal should kill the cleanup immediately).
Original issue: http://code.google.com/p/kyua/issues/detail?id=4
The text was updated successfully, but these errors were encountered: