Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISUP: Update messages in accordance with ITU Q.763 #201

Closed
agafox opened this issue Feb 6, 2017 · 6 comments
Closed

ISUP: Update messages in accordance with ITU Q.763 #201

agafox opened this issue Feb 6, 2017 · 6 comments
Assignees
@agafox
Milestone
8.0.0

Comments

@agafox
Copy link
Contributor

agafox commented Feb 6, 2017

In my project I found ISUP IAM messages with optional parameters from Q.763 (for instance, 'Called IN number', 'UID capability indicators', e.t.c) which don't defined in 'InitialAddressMessage' object.

So, any attempt to decode such messages leads to Exception.

I could try to review ISUP messages and update them in accordance with Q.763
@agafox agafox mentioned this issue Feb 6, 2017
Closed
@vetss
Copy link
Contributor

vetss commented Feb 7, 2017

Hello @agafox

thank you for opening an issue. Feel free to provide update for ISUP messages if you mean it is needed. We will include it into sources.

@agafox
Copy link
Contributor Author

agafox commented Feb 14, 2017 •
edited
Loading

Hello @vetss

I've reviewed all ISUP messages. Only AIM is not up to date with ITU Q.763
25 optional parameters from Table 32 are absent in IAM jss7 implementation.

2 of this parameters not implemented in jss7 at all:

  1. Number portability forward information
  2. Calling geodetic location

I suggest to update IAM with 23 implemented in jss7 parameters and create new issue to implement parameters above because now I'm not sure I have enough time to do it (Calling geodetic location - very complex parameter...)

@ghost ghost added the Peer Review label Feb 14, 2017
@vetss
Copy link
Contributor

vetss commented Feb 15, 2017

Hello @agafox

ok, let's start with what we have. Feel free to provide a PR to the staff you can cover.

@deruelle deruelle added this to the 8.0.0 milestone Feb 20, 2017
@vetss
Copy link
Contributor

vetss commented Feb 27, 2017

Hello @agafox

I have added your update:
9fd03cb

Will you be able to implement two missed parameters ? Should I keep the issue opened so far ?

@agafox
Copy link
Contributor Author

agafox commented Feb 27, 2017

Thanks @vetss

Let's close this issue, because I have no time to implement missed parameters in February and March.

I believe I'll come with pull request in future.

@vetss
Copy link
Contributor

vetss commented Mar 8, 2017

I am closing the issue now. Feel free to open a new one for finishing the work

@vetss vetss closed this as completed Mar 8, 2017
@ghost ghost removed the Peer Review label Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agafox agafox

Labels
None yet
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
3 participants
@deruelle @vetss @agafox