My favorites | Sign in
Project Home Downloads Wiki Issues Source
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 71: token_re_cache in javascript implementation doesn't do anything?
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  martijn....@gmail.com
Closed:  May 2012


 
Project Member Reported by martijn....@gmail.com, May 10, 2012
In the code, the token_re_cache is used to cache regular expressions. But it appears nothing is ever put into the cache. A good thing too, as token_re should be recreated each time during compilation otherwise its lastIndex property isn't reset to 0. At least, I think that's what's going on (I was wondering how it could work with the cache in the first place; turned out the cache doesn't work).

May 18, 2012
Project Member #1 andyc...@gmail.com
Good catch, thanks.  I guess I should just get rid of the cache because the lack of the caching apparently hasn't any issues for anyone.

I can't imagine that anyone would compile more than 10 or 100 templates per page, and it's probably negligible then.  I think it was a carryover from Python, where you could imagine a huge server loading thousands of templates.
May 18, 2012
Project Member #2 andyc...@gmail.com
Fixed with changeset:   440:42ec17bd6386
Status: Fixed

Powered by Google Project Hosting