Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jpcsp.HLE.kernel.managers.MsgPipeManager repeated conditional tests #200

Closed
GoogleCodeExporter opened this issue Mar 22, 2015 · 3 comments
Closed

jpcsp.HLE.kernel.managers.MsgPipeManager repeated conditional tests #200

GoogleCodeExporter opened this issue Mar 22, 2015 · 3 comments
Labels
auto-migrated Priority-Low Type-Defect

Comments

@GoogleCodeExporter
Copy link 

updateWaitingMsgPipeSend(SceKernelMppInfo info) and
updateWaitingMsgPipeReceive(SceKernelMppInfo info)

have these ifs:
if (((info.attr & PSP_MPP_ATTR_SEND_FIFO) == PSP_MPP_ATTR_SEND_FIFO) || 
((info.attr & PSP_MPP_ATTR_FIFO) == PSP_MPP_ATTR_FIFO)) 

if (((info.attr & PSP_MPP_ATTR_RECEIVE_FIFO) == PSP_MPP_ATTR_RECEIVE_FIFO) || 
((info.attr & PSP_MPP_ATTR_FIFO) == PSP_MPP_ATTR_FIFO))

Probably something else was meant.

Original issue reported on code.google.com by i30817@gmail.com on 30 Sep 2010 at 3:32
@GoogleCodeExporter
Copy link
Author 

A comment: the real problem (that find bugs reported is that both 

PSP_MPP_ATTR_RECEIVE_FIFO
and 
PSP_MPP_ATTR_FIFO are static final zeros.
So things look like
if (((info.attr & 0) == 0) || ((info.attr & 0) == 0))

or if(true)


For a while thought that i was senile.

Original comment by i30817@gmail.com on 9 Oct 2010 at 3:16

  • Changed state: Invalid

@GoogleCodeExporter
Copy link
Author

Original comment by i30817@gmail.com on 9 Oct 2010 at 3:19

  • Changed state: New

@GoogleCodeExporter
Copy link
Author 

Fixed in r1810

Original comment by gi...@web.de on 25 Oct 2010 at 5:30

  • Changed state: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated Priority-Low Type-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter