Issue 56 - jaikuengine - Visibility check on comments should only check parent

Issue 56:	Visibility check on comments should only check parent
	5 people starred this issue and may be notified of changes.	Back to list

Status:	Duplicate
Merged:	issue 120
Owner:	mika.raento
Closed:	Jul 22
Cc:	andyster
Type-Defect
Priority-High
privacy

Reported by mika.raento, Mar 18, 2009

Currently we check the comment's stream's visibility to the viewer - that's
wrong, as comments inherit visibility from the post.

Will need to continue to check that the stream exists though.

Comment 1 by adewale, Mar 21, 2009

This: http://yerga.jaiku.com/presence/8c8a388afff247bf81022a57a28cb14b seems to be
suffering from this bug

Comment 2 by jonasnockert, Mar 30, 2009

I'm not sure the below is a consequence of this issue or not but I'm assuming it is.

Comments on private posts seem to be displayed through the IM interface on the basis of having access to the 
commenters' stream. These comments are not visible in ones overview though.

As stated by Mika, comments should inherit visibility from the post.

Comment 3 by andyster, Apr 22, 2009

(No comment was entered for this change.)

Status: Accepted
Labels: -Priority-Medium Priority-High privacy

Comment 4 by adewale, Jul 22, 2009

Marking this as a duplicate of  issue 120 . This patch: http://rietku.appspot.com/24001
should fix both issues.

Status: Duplicate
Mergedinto: 120