My favorites | Sign in
Google
             
New issue | Search
for
| Advanced search | Search tips
Issue 18: no more mobile version of the site
9 people starred this issue and may be notified of changes. Back to list
Status:  Verified
Owner:  andyster
Closed:  May 21
Type-Defect
Priority-Medium
starterproject
Size-Medium


Sign in to add a comment
 
Reported by andyster, Mar 14, 2009
this is mostly just a css problem, we have the old css in there and most of the places that check for 
mobileness still exist, we just didn't get it all running again. A few experiments in the 
middleware/domain.py should get it working again
Comment 1 by tony.t.tseng, Mar 27, 2009
Hi Andy,
Can you add some instruction/description? I'm not sure where to start...
Comment 2 by andyster, Apr 02, 2009
Places to start:

We have in middleware/domain.py some stuff that looks for the 'm' subdomain and
attempts to set request.mobile = True if it finds it. Templates ought to be able to
look for request.mobile to see if they should be rendering themselves as a mobile
variant (likely including the mobile.css stuff).

Additionally, queries will likely have a slightly smaller page size if this is a
mobile site, so places like overview, explore and so on should probably check, also.
Labels: Size-Medium
Comment 3 by alexleonard2003, Apr 02, 2009
I'm completely at a loss to where I would look to work out correcting stuff like this - 
if there's a css display issue I can usually work it out - eg. layouts getting skewed 
etc.
Comment 4 by andyster, Apr 16, 2009
jonas appears to have started work on this and made significant headway
Comment 5 by jonasnockert, Apr 20, 2009
Initial patch has been put on rietku for review: http://rietku.appspot.com/10001
Comment 6 by alexleonard2003, Apr 20, 2009
Great work Jonas! Keep it up. As mentioned I'm hoping to join in as soon as physically 
possible.
Comment 7 by jonasnockert, May 21, 2009
As a mobile version of the site is now in place (yay!), I think we should close this
issue. There are certainly issues left to deal with in this area but those should
probably be handled individually.
Comment 8 by adewale, May 21, 2009
(No comment was entered for this change.)
Status: Verified
Sign in to add a comment