My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 1389: ibus is missing support for /etc/machine-id fallback from dbus
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  Shawn.P....@gmail.com
Closed:  Apr 2012
Cc:  takao.fujiwara1


Sign in to add a comment
 
Reported by ssuomine...@gmail.com, Jan 3, 2012
dbus has support for using /etc/machine-id instead of /var and ibus is hardcoding the path to /var in src/ibusshare.c.  

obviously this fails when system only has /etc/machine-id.

the related upstream commit is:

http://cgit.freedesktop.org/dbus/dbus/commit/dbus/dbus-sysdeps-unix.c?id=66e52541d5bdd4927a5c702963749760643313f4

the downstream bug is:

http://bugs.gentoo.org/390463

the patch for the problem is:

http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/app-i18n/ibus/files/ibus-1.4.0-machine-id-fallback.patch?revision=1.1&view=markup

note that also other downstreams have added support for /etc/machine-id. namely "glib" and "pulseaudio" in their version controls
ibus-1.4.0-machine-id-fallback.patch
750 bytes   View   Download
Apr 25, 2012
Project Member #2 takao.fujiwara1
 Issue 1385  has been merged into this issue.
Apr 25, 2012
Project Member #3 takao.fujiwara1
Thanks for the suggestion.
Reading the dbus patch, I think your ibus patch is not exact.
I start to work with the attached patch.
ibus-1389-dbus-address.patch
805 bytes   View   Download
Status: Started
Cc: takao.fujiwara1
Labels: Component-ibus
May 5, 2012
#5 mgo...@gentoo.org
At a first glance, the above change could result in error not being freed when the fallback occurs.
May 7, 2012
Project Member #6 takao.fujiwara1
> At a first glance, the above change could result in error not being freed when the fallback occurs.

I don't think so.
Sign in to add a comment

Powered by Google Project Hosting