My favorites | Sign in
Project Home Wiki Issues Source
READ-ONLY: This project has been archived. For more information see this post.
Search
for
  Advanced search   Search tips   Subscriptions
Issue 259: Remove line number from breakpoint hash
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  ----
Closed:  Oct 2013


 
Reported by damjan.cvetko@gmail.com, Oct 9, 2013
In svn, when a breakpoint is added a hash for fast lookups is calculated from breakpoint line number and filename. This hash is used to quickly detect if no breakpoints are valid on current line of execution.

The problem is, that the current line of execution hash does not include the actual line number, but the line number where the current executing function was defined (frame->fileLineHash).

Quick workaround is to just not include line number in the hash.

The change required is in Debug.cpp:1330
mBreakpoints[toCopy->mBreakpointCount].hash = Hash(0, fileName);

This change also needs its counterpart in gencpp.ml:1167
let hash_file_line = gen_hash 0 stripped_file in
Oct 15, 2013
Project Member #1 gameh...@gmail.com
I have made the changes - for some reason, I thought the LINE macro also included the file/line hash.  I guess we could XOR the file hash+line together, but it is probably better just to compare the line integers.  I changed a few of the variable names so it probably needs a bit more of a test.
Status: Fixed
Oct 15, 2013
#2 damjan.cvetko@gmail.com
Thanks, will test in the evening. haxe change that also needs to be applied is here:
https://github.com/HaxeFoundation/haxe/pull/2239
Oct 15, 2013
#3 damjan.cvetko@gmail.com
Tested, looks ok.

Powered by Google Project Hosting