| Issue 259: | Remove line number from breakpoint hash | |
| 1 person starred this issue and may be notified of changes. | Back to list |
In svn, when a breakpoint is added a hash for fast lookups is calculated from breakpoint line number and filename. This hash is used to quickly detect if no breakpoints are valid on current line of execution. The problem is, that the current line of execution hash does not include the actual line number, but the line number where the current executing function was defined (frame->fileLineHash). Quick workaround is to just not include line number in the hash. The change required is in Debug.cpp:1330 mBreakpoints[toCopy->mBreakpointCount].hash = Hash(0, fileName); This change also needs its counterpart in gencpp.ml:1167 let hash_file_line = gen_hash 0 stripped_file in
Oct 15, 2013
Project Member
#1
gameh...@gmail.com
Status:
Fixed
Oct 15, 2013
Thanks, will test in the evening. haxe change that also needs to be applied is here: https://github.com/HaxeFoundation/haxe/pull/2239
Oct 15, 2013
Tested, looks ok. |