My favorites ▼ | Sign in
gyp
Project Home Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 42: Split actions/rules with process_outputs_as_sources=1 as _prebuild project for MSVC
8 people starred this issue and may be notified of changes. Back to list
Status:  Accepted
Owner:  ----


Sign in to add a comment
 
Project Member Reported by maruel@chromium.org, Jul 8, 2009 
What steps will reproduce the problem?
1. Set 'process_outputs_as_sources': 1 in an action as done in http://src.chromium.org/viewvc/chrome/trunk/src/webkit/webkit.gyp
2. See MSVC chocking on dependency processing for incremental build.

What is the expected output? What do you see instead?
MSVC200x doesn't support updating the dependency tree while processing a single 
project. The dependency tree is only updated after processing a whole project. 
So generated sources must be in a separate project from the steps that generate 
the said sources to have the dependency scanning done properly. This makes process_outputs_as_sources effectively broken and useless and should be removed 
accordingly. webkit.gyp and installer.gyp need to be updated to not use this 
flag anymore and support for this flag must be removed until we drop support for 
vcproj exports.
Jul 8, 2009
Project Member #1 mark@chromium.org 
We don't necessarily need to get rid of process_outputs_as_sources.  The MSVS 
generator could automatically generate an auxiliary dependency target for rules and 
actions that runs the scripts, and the outputs (when process_outputs_as_sources is 
true) could be compiled in the main target.
Jul 9, 2009
Project Member #2 maruel@chromium.org 
You are right.

So my proposal (since I can't rename the title)

- For every action and rules that have 'process_outputs_as_sources': 1,
- On MSVC only,
- Generate a '$(project)_prebuild.vcproj' that contains those steps, depends on the same 
dependencies than $(project).
- Have $(project)dependends on '$(project)_prebuild'.
Jul 9, 2009
Project Member #3 maruel@chromium.org 
(No comment was entered for this change.)
Summary: Split actions/rules with process_outputs_as_sources=1 as _prebuild project for MSVC
Aug 6, 2009
Project Member #4 sgk@chromium.org 
(No comment was entered for this change.)
Status: Accepted
Aug 18, 2009
Project Member #5 sgk@chromium.org 
(No comment was entered for this change.)
Labels: MSVS
Oct 19, 2009
Project Member #6 maruel@chromium.org 
He accepted but forgot to make himself owner
Owner: s...@chromium.org
Nov 16, 2009
Project Member #7 sgk@chromium.org 
No, I didn't forget.  Taking my name back off.

The "process" (if you want to dignify it) that bradnelson and I were following was to 
move items to Accepted to indicate it at least got a cursory project-level triage 
(bradnelson and I going through the new issues) and that the Priority and keywords 
are sane.  A name attached is what does or doesn't indicate a specific individual has 
intends to work on it.

That's not set in stone, it's just what we started doing the couple of times we went 
down the list.
Owner: ---
Jun 25, 2010
Project Member #8 mark@chromium.org 
We did this for Xcode in r762. It worked. We ought to fix it for MSVS too.
► Sign in to add a comment

Powered by Google Project Hosting