Dispatch Projects Update #316

Chris-V · 2013-08-21T03:39:06Z

_Change Log:_

gwtp-dispatch-rest

Replaced Piriti by gwt-jackson
Removed missing jax-rs annotation from the compile report
Added extension points and interfaces
Moved some code from the RestDispatch implementation to RestDispatchCall

gwtp-dispatch-client

Renamed artifact to gwtp-dispatch-rpc-client
Moved classes to com.gwtplatform.dispatch.rpc.client.*
The old classes are still there but are deprecated. If you wish to stay up to date and prevent future migration issues, make sure you use the classes available in com.gwtplatform.dispatch.rpc.client.*
Added extension points and interfaces
Moved some code from the DispatchAsync implementation to RpcDispatchExecuteCall and RpcDispatchUndoCall. They have the same extensions points DispatchAsync previously had

gwtp-dispatch-server

Renamed artifact to gwtp-dispatch-rpc-server
Moved classes to com.gwtplatform.dispatch.rpc.server.*
The old classes are still there but are deprecated. If you wish to stay up to date and prevent future migration issues, make sure you use the classes available in com.gwtplatform.dispatch.rpc.server.*

gwtp-dispatch-server-guice

Renamed artifact to gwtp-dispatch-rpc-server-guice
Moved classes to com.gwtplatform.dispatch.rpc.server.guice.*
The old classes are still there but are deprecated. If you wish to stay up to date and prevent future migration issues, make sure you use the classes available in com.gwtplatform.dispatch.rpc.server.guice.*

gwtp-dispatch-server-spring

Renamed artifact to gwtp-dispatch-rpc-server-spring
Moved classes to com.gwtplatform.dispatch.rpc.server.spring.*
The old classes are still there but are deprecated. If you wish to stay up to date and prevent future migration issues, make sure you use the classes available in com.gwtplatform.dispatch.rpc.server.spring.*

gwtp-dispatch-shared

Renamed artifact to gwtp-dispatch-rpc-shared
Moved classes to com.gwtplatform.dispatch.rpc.shared.*
The old classes are still there but are deprecated. If you wish to stay up to date and prevent future migration issues, make sure you use the classes available in com.gwtplatform.dispatch.rpc.shared.*

Additions

Created 2 new artifacts gwtp-dispatch-common-shared and gwtp-dispatch-common-client. They contain code (ie: DispatchCall abstraction) shared by both the REST and RPC dispatch projects.

Conflicts: gwtp-core/gwtp-dispatch-rest/src/main/java/com/gwtplatform/dispatch/client/gin/RestDispatchAsyncModule.java gwtp-core/gwtp-dispatch-rest/src/main/java/com/gwtplatform/dispatch/client/rest/RestDispatchAsync.java

Added jax-rs to gin exceptions.

…carstore_update

Updated the carstore for the new serializer and rest service syntax

…v_rest_dispatch_standalone Conflicts: gwtp-core/gwtp-dispatch-rest/src/main/java/com/gwtplatform/dispatch/client/rest/ActionMetadataProvider.java

… into cv_rest_dispatch_standalone

GJ-4: Remove the need for the Result interface

Migrate to Errai Marshalling

jDramaix · 2013-08-21T07:43:06Z

gwtp-carstore/src/main/java/com/gwtplatform/carstore/server/rest/ManufacturerResource.java

@@ -56,34 +55,30 @@
    }

    @GET
-    public GetResults<ManufacturerDto> getManufacturers() {
-        return new GetResults<ManufacturerDto>(Manufacturer.createDto(manufacturerDao.getAll()));
+    public List<ManufacturerDto> getManufacturers() {


With REST, it's always better to send a Response object. It gives you control on the HTTP status to send

I started doing it and it seems to expose something bigger. The carstore resources should return more relevant HTTP statuses (created, no content, not found, etc). Right now everything will return Repsonse.ok(...), but that's a lead for a story in the next iteration.
It can also mean updating the front-end accordingly. ie: If getManufacturer(321) returns with Status.NOT_FOUND, then we can display a custom error message in the UI.

jDramaix · 2013-08-21T08:44:54Z

very looong PR :)

Two comments :

some javadocs on GWTP class should be helpful
I don't like that people have to use the errai annotation on their dto. We are now linked to the errai framework. I think that the way we serialize/deserialize object to/from JSOn should be transparent and we should be able in the future to change that without impacting the final developer.

Add extension points to the dispatch code

RPC backward compatibility

Extracted common code between RPC and REST DispatchAsync

Extract common code from dispatch projects (part 1)

…h_update Conflicts: gwtp-build-tools/pom.xml gwtp-carstore/pom.xml gwtp-carstore/src/main/java/com/gwtplatform/carstore/server/rest/ManufacturerResource.java gwtp-core/gwtp-all/pom.xml gwtp-core/gwtp-clients-common/pom.xml gwtp-core/gwtp-crawler/pom.xml gwtp-core/gwtp-dispatch-rest/pom.xml gwtp-core/gwtp-dispatch-rpc-client/pom.xml gwtp-core/gwtp-dispatch-rpc-server-guice/pom.xml gwtp-core/gwtp-dispatch-rpc-server-spring/pom.xml gwtp-core/gwtp-dispatch-rpc-server/pom.xml gwtp-core/gwtp-dispatch-rpc-shared/pom.xml gwtp-core/gwtp-dispatch-rpc-test/pom.xml gwtp-core/gwtp-mvp-client/pom.xml gwtp-core/gwtp-processors/pom.xml gwtp-core/gwtp-tester/pom.xml gwtp-core/pom.xml gwtp-crawler-service/pom.xml pom.xml

…te services.

Dispatch documention

Replaced Errai by gwt-jackson

Chris-V · 2013-12-02T21:45:10Z

@christiangoudreau @olafleur @meriouma @olafleur @PhilBeaudoin
I'm merging now, you can still review this branch (12.5k changes...) or go back to the other PRs. I summarized the change log in the description and the doc should be up to date here https://github.com/ArcBees/GWTP/wiki/Rest-Dispatch-1.1.

Updated Dispatch Projects

Updated Dispatch Projects Former-commit-id: 9e0d3ad

Chris-V and others added 24 commits August 14, 2013 10:09

Replaced piriti by Errai Marshalling

6f44fa0

Merge branch 'cv_rest_dispatch_update' into cv_errai_marshalling

66d5a46

Code style

ebe0752

Code style

26ee61a

Fixed clashing slf4j scope

8dba423

Removed many dependencies between rest and rpc dispatch

f20c643

Fixed compilation errors

e76dd1d

Added missing Dispatch dependency

896eb9b

Updated the carstore for the new serializer and rest service syntax

24fdd69

Added support for collections, map and void as root result type.

681300b

pom cleanup

fdb134c

Fixed compilation errors and unit tests

9ea6fa4

Added jax-rs to gin exceptions.

698a8d8

Code style

7832fbc

Code style

55acb1f

Merge pull request #313 from ArcBees/cv_remove_jaxrs_warning

3be3586

Added jax-rs to gin exceptions.

Code style

c089a1a

Merge branch 'cv_carstore_update' of github.com:ArcBees/GWTP into cv_…

b4ad6e0

…carstore_update

Merge pull request #311 from ArcBees/cv_carstore_update

b3a39f9

Updated the carstore for the new serializer and rest service syntax

Merge branch 'cv_errai_marshalling' of github.com:ArcBees/GWTP into c…

5366506

…v_rest_dispatch_standalone Conflicts: gwtp-core/gwtp-dispatch-rest/src/main/java/com/gwtplatform/dispatch/client/rest/ActionMetadataProvider.java

Merge branch 'cv_rest_dispatch_standalone' of github.com:ArcBees/GWTP…

9c0bda4

… into cv_rest_dispatch_standalone

Merge pull request #309 from ArcBees/cv_rest_dispatch_standalone

bad9f92

GJ-4: Remove the need for the Result interface

Merge pull request #308 from ArcBees/cv_errai_marshalling

d5d07f0

Migrate to Errai Marshalling

jDramaix reviewed Aug 21, 2013
View reviewed changes

Chris-V added 23 commits November 21, 2013 15:25

Add extension points to the dispatch code

37a1e97

Merge pull request #351 from ArcBees/cv_dispatch_extension_points

ba57594

Add extension points to the dispatch code

Merge pull request #350 from ArcBees/cv_dispatch_backward_compatibility

0c1b236

RPC backward compatibility

Merge pull request #348 from ArcBees/cv_dispatch_client_common_2

5a8258c

Extracted common code between RPC and REST DispatchAsync

Merge pull request #318 from ArcBees/cv_dispatch_client_common

2f4b8f4

Extract common code from dispatch projects (part 1)

Fixed merge issues.

b7cbd71

Updated dispatch-common-* javadoc.

54003d6

Updated dispatch-rpc-client javadoc.

823a729

Updated dispatch-rpc-server-* javadoc.

7f46eac

Updated dispatch-rpc-shared javadoc.

71687a5

Added distapct-rest javadoc.

73c13ad

Reintroduced ResponseWrapper

469d272

removed mention of extension points. Added link to wiki on how to wri…

e1bb688

…te services.

removed mention of extension points in rpc-dispatch.

7a915a9

Typo

893895a

Replaced the REST serialization mechanism by gwt-jackson

7cce12c

Fixed void de/serialization

57107f8

Added some javadoc to the serialization code.

48ce1a8

Merge pull request #355 from ArcBees/cv_dispatch_javadoc

7b369a9

Dispatch documention

Added AbstractRestDispatcherController back

2a28594

Code style. Updated gwt-jackson to 0.2.0

a1422e1

Merge pull request #363 from ArcBees/cv_gwt_jackson

21d4158

Replaced Errai by gwt-jackson

Chris-V added a commit that referenced this pull request Dec 2, 2013

Merge pull request #316 from ArcBees/cv_rest_dispatch_update

1f07781

Updated Dispatch Projects

Chris-V merged commit 1f07781 into master Dec 2, 2013

Chris-V deleted the cv_rest_dispatch_update branch December 2, 2013 21:55

Chris-V mentioned this pull request Dec 17, 2013

Releasing 1.1 and moving to 1.2-SNAPSHOT #378

Merged

Chris-V added a commit that referenced this pull request Apr 4, 2014

Merge pull request #316 from ArcBees/cv_rest_dispatch_update

9e0d3ad

Updated Dispatch Projects

hpehl pushed a commit to hpehl/GWTP that referenced this pull request Dec 9, 2014

Merge pull request ArcBees#316 from ArcBees/cv_rest_dispatch_update

a4ae65a

Updated Dispatch Projects Former-commit-id: 9e0d3ad

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dispatch Projects Update #316

Dispatch Projects Update #316

Chris-V commented Aug 21, 2013

jDramaix Aug 21, 2013

Chris-V Aug 26, 2013

jDramaix commented Aug 21, 2013

Chris-V commented Dec 2, 2013

Dispatch Projects Update #316

Dispatch Projects Update #316

Conversation

Chris-V commented Aug 21, 2013

jDramaix Aug 21, 2013

Choose a reason for hiding this comment

Chris-V Aug 26, 2013

Choose a reason for hiding this comment

jDramaix commented Aug 21, 2013

Chris-V commented Dec 2, 2013