gwt-beans-binding - Project Hosting on Google Code

Last 7 days Dec 06, 2009 r53 ((Bug Fix) build.xml should not add Main.{java,class}) committed by georgopoulos.georgios - (Bug Fix) build.xml should not add Main.{java,class} (Bug Fix) build.xml should not add Main.{java,class} Dec 06, 2009 r52 ([No log message]) committed by georgopoulos.georgios - [No log message] [No log message] Dec 06, 2009 r51 ((Update) Project layout changed for GWT-2.0 compatibility) committed by georgopoulos.georgios - (Update) Project layout changed for GWT-2.0 compatibility (Update) Project layout changed for GWT-2.0 compatibility Earlier this year Oct 18, 2009 issue 7 (ListBoxAdapterProvider should return value instead of item t...) reported by ladislav.gazo - What steps will reproduce the problem? 1. create binding using ListBox on one side with selectedElement property 2. choose something in ListBox that will be assigned to i.e. bean field What is the expected output? What do you see instead? There is item text instead of value in the field. In case no value is set in ListBox list, value is equal to item text. In that case it makes more sense to return value instead as a result of item selection. What version of the product are you using? On what operating system? 0.2.4 Please provide any additional information below. I attached patch fixing the issue What steps will reproduce the problem? 1. create binding using ListBox on one side with selectedElement property 2. choose something in ListBox that will be assigned to i.e. bean field What is the expected output? What do you see instead? There is item text instead of value in the field. In case no value is set in ListBox list, value is equal to item text. In that case it makes more sense to return value instead as a result of item selection. What version of the product are you using? On what operating system? 0.2.4 Please provide any additional information below. I attached patch fixing the issue Jul 14, 2009 issue 6 ([Question] Are you working on validation?) changed by thomas.buckel - Fixed Validator.Result in rev #50 on trunk. It now returns the correct values. Cheers Thomas Status: Fixed Cc: georgopoulos.georgios olivier....@free.fr Fixed Validator.Result in rev #50 on trunk. It now returns the correct values. Cheers Thomas Status: Fixed Cc: georgopoulos.georgios olivier....@free.fr Jul 14, 2009 r50 (Issue 6: Validator.Result returns correct values now) committed by thomas.buckel - Issue 6 : Validator.Result returns correct values now Issue 6 : Validator.Result returns correct values now Jul 14, 2009 issue 6 ([Question] Are you working on validation?) changed by thomas.buckel - Status: Started Owner: thomas.buckel Labels: OpSys-All Status: Started Owner: thomas.buckel Labels: OpSys-All Jul 14, 2009 issue 6 ([Question] Are you working on validation?) commented on by georgopoulos.georgios - Hi, this project seems interesting for EL: http://code.google.com/p/gwt-exporter/ Kind Regards, George. Hi, this project seems interesting for EL: http://code.google.com/p/gwt-exporter/ Kind Regards, George. Jul 14, 2009 issue 6 ([Question] Are you working on validation?) Status changed by georgopoulos.georgios - Hi, I added you both to the project. Kind Regards, George. Status: Accepted Hi, I added you both to the project. Kind Regards, George. Status: Accepted Jul 13, 2009 issue 6 ([Question] Are you working on validation?) commented on by thomas.buckel - Hi George, you've done some great work with this module, but I ran in the same problem as Olivier did, e.g. only a partial implementation of the Validator class. IMHO integrating another Validation framework on top of beans binding doesn't make sense to me - jsr295 already provides the appropriate hooks for validation and so far it seems that only a few methods aren't implemented correctly. I'd be happy to provide a fix or commit it to the repository. Cheers Thomas Hi George, you've done some great work with this module, but I ran in the same problem as Olivier did, e.g. only a partial implementation of the Validator class. IMHO integrating another Validation framework on top of beans binding doesn't make sense to me - jsr295 already provides the appropriate hooks for validation and so far it seems that only a few methods aren't implemented correctly. I'd be happy to provide a fix or commit it to the repository. Cheers Thomas Jun 26, 2009 r49 ((Bug Fix) Issue 5: IntrospectionException using JUnit web mo...) committed by georgopoulos.georgios - (Bug Fix) Issue 5: IntrospectionException using JUnit web mode (workaround + possible fix) (Bug Fix) Issue 5: IntrospectionException using JUnit web mode (workaround + possible fix) Jun 26, 2009 r48 (0.2.4) committed by georgopoulos.georgios - 0.2.4 0.2.4 Jun 26, 2009 gwt-beans-binding-0.2.4.jar (GWT Beans Binding 0.2.4 (GWT 1.5 & GWT 1.6)) file uploaded by georgopoulos.georgios - Labels: Featured Labels: Featured Jun 26, 2009 r47 (0.2.4) committed by georgopoulos.georgios - 0.2.4 0.2.4 Jun 26, 2009 r46 ((Bug Fix) NPE fix in generator) committed by georgopoulos.georgios - (Bug Fix) NPE fix in generator (Bug Fix) NPE fix in generator Jun 26, 2009 issue 6 ([Question] Are you working on validation?) commented on by olivier....@free.fr - Hi, Finally, the validation library of the gwt-incubator project is too light, it's need many work to integrate it to gwt-beans-binding. So we try to build something on top of the Validator class. But we find that the Result inner-class as some mistakes. For example : private final String description; public String getDescription() { return null; } We will have a look to gwt-vl. I work for Antidot (http://www.antidot.net/en) and we are re-engineering our Back Office. We use a Rest server written using Java (and Restlet). We use GWT, gwt-incubator, gwt-beans-binding, gwt-mosaic and many proprietary code for the UI. So we try to enhance gwt-beans-binding to meet our requirements ;). For example, we write a replacement for BeanProperty that use Expression Language for the property path. So we support the [-syntax for maps and lists. Example: myprop.mylist[0].otherprop or myprop.mymap["key"].otherprop. Are you interested in merging our code with gwt-beans-binding? Regards, Olivier Hi, Finally, the validation library of the gwt-incubator project is too light, it's need many work to integrate it to gwt-beans-binding. So we try to build something on top of the Validator class. But we find that the Result inner-class as some mistakes. For example : private final String description; public String getDescription() { return null; } We will have a look to gwt-vl. I work for Antidot (http://www.antidot.net/en) and we are re-engineering our Back Office. We use a Rest server written using Java (and Restlet). We use GWT, gwt-incubator, gwt-beans-binding, gwt-mosaic and many proprietary code for the UI. So we try to enhance gwt-beans-binding to meet our requirements ;). For example, we write a replacement for BeanProperty that use Expression Language for the property path. So we support the [-syntax for maps and lists. Example: myprop.mylist[0].otherprop or myprop.mymap["key"].otherprop. Are you interested in merging our code with gwt-beans-binding? Regards, Olivier Jun 26, 2009 issue 6 ([Question] Are you working on validation?) commented on by georgopoulos.georgios - Hi, the validation is ported from the original, but I didn't test it at all. I plan to add validation on gwt-mosaic based on bindings but not in the near future. At the moment I am working on a DB module. I want to check this project too: http://gwt-vl.sourceforge.net/#showcase and also the validation used in Netbeans applications. By the way, where do you use gwt-beans-binding ? Kind Regards, George. Hi, the validation is ported from the original, but I didn't test it at all. I plan to add validation on gwt-mosaic based on bindings but not in the near future. At the moment I am working on a DB module. I want to check this project too: http://gwt-vl.sourceforge.net/#showcase and also the validation used in Netbeans applications. By the way, where do you use gwt-beans-binding ? Kind Regards, George. Jun 26, 2009 issue 6 ([Question] Are you working on validation?) reported by olivier....@free.fr - Hi Georges, We plan to add validation on bindings soon. We see the Validator class but it seems to be a draft. We also see the Validator from the incubator project. I think we try to connect the incubator Validator to your binding system. It seems possible to do. Do you have any suggestion? Regards, Olivier Hi Georges, We plan to add validation on bindings soon. We see the Validator class but it seems to be a draft. We also see the Validator from the incubator project. I think we try to connect the incubator Validator to your binding system. It seems possible to do. Do you have any suggestion? Regards, Olivier Jun 24, 2009 issue 5 (IntrospectionException using JUnit web mode (workaround + po...) commented on by georgopoulos.georgios - Hi, The Generator now returns the generated class & code generation is not possible in hosted mode (but is not required) since the original java.lang.reflect.Method class is declared final and can't be used by the generator in statements like: new Method() { public Object invoke(Object bean, Object... args) { return (java.lang.String)((com.delos.client.model.Employee) bean).getFirstName(); } } GWTBeansBinding class looks like this: import com.google.gwt.core.client.GWT; package org.gwt.beansbinding.core.client.util; public static void init() { if (!GWT.isScript()) { return; } try { GWT.create(GWTBeansBinding.class); } catch (Throwable t) { GWT.log(t.getMessage(), t); } } Let me know if that helps. Thanks, George. Hi, The Generator now returns the generated class & code generation is not possible in hosted mode (but is not required) since the original java.lang.reflect.Method class is declared final and can't be used by the generator in statements like: new Method() { public Object invoke(Object bean, Object... args) { return (java.lang.String)((com.delos.client.model.Employee) bean).getFirstName(); } } GWTBeansBinding class looks like this: import com.google.gwt.core.client.GWT; package org.gwt.beansbinding.core.client.util; public static void init() { if (!GWT.isScript()) { return; } try { GWT.create(GWTBeansBinding.class); } catch (Throwable t) { GWT.log(t.getMessage(), t); } } Let me know if that helps. Thanks, George. Jun 24, 2009 r45 ((Update) Code format) committed by georgopoulos.georgios - (Update) Code format (Update) Code format Jun 24, 2009 r44 ((Bug Fix) Issue 5 The Generator now returns the generated cl...) committed by georgopoulos.georgios - (Bug Fix) Issue 5 The Generator now returns the generated class & code generation is not possible in hosted mode (but is not required) since the original java.lang.reflect.Method class is declared final and can't be used by the generator in statements like: new Method() { public Object invoke(Object bean, Object... args) { return (java.lang.String)((com.delos.client.model.Employee) bean).getFirstName(); } } (Bug Fix) Issue 5 The Generator now returns the generated class & code generation is not possible in hosted mode (but is not required) since the original java.lang.reflect.Method class is declared final and can't be used by the generator in statements like: new Method() { public Object invoke(Object bean, Object... args) { return (java.lang.String)((com.delos.client.model.Employee) bean).getFirstName(); } } May 15, 2009 issue 5 (IntrospectionException using JUnit web mode (workaround + po...) changed by georgopoulos.georgios - Thanks, I will check that. George. Status: Accepted Owner: georgopoulos.georgios Thanks, I will check that. George. Status: Accepted Owner: georgopoulos.georgios May 13, 2009 issue 5 (IntrospectionException using JUnit web mode (workaround + po...) commented on by olivier....@free.fr - It's not GwtBinding but GwtTestBinding and it must extends GWTTestCase. public class GwtTestBinding extends GWTTestCase { ... } It's not GwtBinding but GwtTestBinding and it must extends GWTTestCase. public class GwtTestBinding extends GWTTestCase { ... } May 13, 2009 issue 5 (IntrospectionException using JUnit web mode (workaround + po...) reported by olivier....@free.fr - When you generate the GWTBeansBindingIntrospector class, you create a static method (setupBeanInfo) and a static initializer like : static { setupBeanInfo(); } This works great in web mode and in hosted mode (I suspected the hosted mode is using the Java implementation of Beans Binding, right ?). It works also with JUnit in hosted mode. But using JUnit in web mode give you an "IntrospectionException" with a message like "Class has not been enabled for introspection...". Here is a little example: public class GwtBinding { public static class A implements BeanAdapter { ... } public void test() { GWTBeanBinding.init(); // Here, the class A is known by Introspector... I mean // JUnit web mode: are you sure? Introspector.getBeanInfo(A.class); // Exception!!! } } After many test I've dumped the content of GwtIntrospector.beanInfos... public class GwtBinding { public static class A implements BeanAdapter { ... } public native void Map<Class<?>, ?> getMap() /-{ @com.googlecode.gwtx.java.introspection.client.GwtIntrospector::beanInfos; }-/; public void test() { GWTBeanBinding.init(); // Here, the class A is known by Introspector... I mean Map<Class<?>, ?> map = getMap(); String s = ""; for (Class<?> c : map.keySet()) { s += c.getName() + "\n"; } Window.alert("" + s + ""); // Expected: ...A // Found: ** // => No A in Introspector } } But why? The GWTBeanBindingIntrospector is generated... but the static method is never called. My workaround is to call, just after GWTBeanBinding.init() this static method (using JSNI do avoid compile error in eclipse): private native void bb() /-{ @org.gwt.beansbinding.core.client.util.GWTBeansBindingIntrospector::setupBeanInfo()(); }-/; public void test() { GWTBeanBinding.init(); bb(); ... } I had the same problem with static initialiser in my code. So I choose to change many of them. One change you can make to the class GWTBeanBinding can be to create an interface that GWTBeanBindingIntrospector implements. This interface define an "init" method. You generate the code into this method. Then you replace the static "init()" method of GWTBeanBinding by: public static void init() { try { ((MyIntf)GWT.create(GWTBeansBinding.class)).init(); } catch (Throwable t) { GWT.log(t.getMessage(), t); } } Regards, Olivier When you generate the GWTBeansBindingIntrospector class, you create a static method (setupBeanInfo) and a static initializer like : static { setupBeanInfo(); } This works great in web mode and in hosted mode (I suspected the hosted mode is using the Java implementation of Beans Binding, right ?). It works also with JUnit in hosted mode. But using JUnit in web mode give you an "IntrospectionException" with a message like "Class has not been enabled for introspection...". Here is a little example: public class GwtBinding { public static class A implements BeanAdapter { ... } public void test() { GWTBeanBinding.init(); // Here, the class A is known by Introspector... I mean // JUnit web mode: are you sure? Introspector.getBeanInfo(A.class); // Exception!!! } } After many test I've dumped the content of GwtIntrospector.beanInfos... public class GwtBinding { public static class A implements BeanAdapter { ... } public native void Map<Class<?>, ?> getMap() /-{ @com.googlecode.gwtx.java.introspection.client.GwtIntrospector::beanInfos; }-/; public void test() { GWTBeanBinding.init(); // Here, the class A is known by Introspector... I mean Map<Class<?>, ?> map = getMap(); String s = ""; for (Class<?> c : map.keySet()) { s += c.getName() + "\n"; } Window.alert("" + s + ""); // Expected: ...A // Found: ** // => No A in Introspector } } But why? The GWTBeanBindingIntrospector is generated... but the static method is never called. My workaround is to call, just after GWTBeanBinding.init() this static method (using JSNI do avoid compile error in eclipse): private native void bb() /-{ @org.gwt.beansbinding.core.client.util.GWTBeansBindingIntrospector::setupBeanInfo()(); }-/; public void test() { GWTBeanBinding.init(); bb(); ... } I had the same problem with static initialiser in my code. So I choose to change many of them. One change you can make to the class GWTBeanBinding can be to create an interface that GWTBeanBindingIntrospector implements. This interface define an "init" method. You generate the code into this method. Then you replace the static "init()" method of GWTBeanBinding by: public static void init() { try { ((MyIntf)GWT.create(GWTBeansBinding.class)).init(); } catch (Throwable t) { GWT.log(t.getMessage(), t); } } Regards, Olivier Feb 12, 2009 issue 4 ([Patch] Deferred binding generator bug on setter with primit...) Status changed by georgopoulos.georgios - Hi Oliver, the source code is updated: http://code.google.com/p/gwt-beans-binding/source/detail?r=43 Thanks, George. Status: Fixed Hi Oliver, the source code is updated: http://code.google.com/p/gwt-beans-binding/source/detail?r=43 Thanks, George. Status: Fixed Feb 12, 2009 issue 3 ([Patch] Deferred binding generator bug on property typed wit...) Status changed by georgopoulos.georgios - Hi Oliver, sorry for the delay, the source code is updated: http://code.google.com/p/gwt-beans-binding/source/detail?r=43 Thanks, George. Status: Fixed Hi Oliver, sorry for the delay, the source code is updated: http://code.google.com/p/gwt-beans-binding/source/detail?r=43 Thanks, George. Status: Fixed Feb 12, 2009 r43 (Issue 3: [Patch] Deferred binding generator bug on property ...) committed by georgopoulos.georgios - Issue 3 : [Patch] Deferred binding generator bug on property typed with type variable Issue 4 : [Patch] Deferred binding generator bug on setter with primitive return type Issue 3 : [Patch] Deferred binding generator bug on property typed with type variable Issue 4 : [Patch] Deferred binding generator bug on setter with primitive return type Feb 11, 2009 issue 4 ([Patch] Deferred binding generator bug on setter with primit...) reported by olivier....@free.fr - If you write the following class: ===================== public class Bug implements BeanAdapter { private PropertyChangeSupport support = new PropertyChangeSupport(this); private int i; public int getI() { return i; } public void setI(int i) { support.firePropertyChange("i", this.i, i); this.i = i; } // ... } ===================== The generator produce the following code: ===================== public Object invoke( Object bean, Object... args ) { ( (net.antidot.testui.client.Bug) bean).setI( (int) args[0] ); return null; } ===================== (look at the cast from Object to int). When a setter takes a parameter of a primitive type, you need to use the boxed type. Here is a patch that works for me (this patch is applied next to the patch of the issue 3 , be aware that line numbered can be different with the trunk source and that there is a "getErasedType()" call due to the issue 3 ): ===================== Index: BeanPropertyDescriptorGenerator.java =================================================================== --- BeanPropertyDescriptorGenerator.java (revision 42) +++ BeanPropertyDescriptorGenerator.java (working copy) @@ -268,9 +268,16 @@ sw.println("public Object invoke( Object bean, Object... args )"); sw.println("{"); sw.indent(); - JType argType = setter.getParameters()[0].getType(); + JType argType = setter.getParameters()[0].getType().getErasedType(); + String argTypeName ; + if (argType.isPrimitive() != null) { + argTypeName = argType.isPrimitive().getQualifiedBoxedSourceName(); + } + else { + argTypeName = argType.getQualifiedSourceName(); + } sw.println("( (" + type.getQualifiedSourceName() + ") bean)." - + setter.getName() + "( (" + argType.getQualifiedSourceName() + + setter.getName() + "( (" + argTypeName + ") args[0] );"); sw.println("return null;"); sw.outdent(); ===================== Regards, Olivier Monaco If you write the following class: ===================== public class Bug implements BeanAdapter { private PropertyChangeSupport support = new PropertyChangeSupport(this); private int i; public int getI() { return i; } public void setI(int i) { support.firePropertyChange("i", this.i, i); this.i = i; } // ... } ===================== The generator produce the following code: ===================== public Object invoke( Object bean, Object... args ) { ( (net.antidot.testui.client.Bug) bean).setI( (int) args[0] ); return null; } ===================== (look at the cast from Object to int). When a setter takes a parameter of a primitive type, you need to use the boxed type. Here is a patch that works for me (this patch is applied next to the patch of the issue 3 , be aware that line numbered can be different with the trunk source and that there is a "getErasedType()" call due to the issue 3 ): ===================== Index: BeanPropertyDescriptorGenerator.java =================================================================== --- BeanPropertyDescriptorGenerator.java (revision 42) +++ BeanPropertyDescriptorGenerator.java (working copy) @@ -268,9 +268,16 @@ sw.println("public Object invoke( Object bean, Object... args )"); sw.println("{"); sw.indent(); - JType argType = setter.getParameters()[0].getType(); + JType argType = setter.getParameters()[0].getType().getErasedType(); + String argTypeName ; + if (argType.isPrimitive() != null) { + argTypeName = argType.isPrimitive().getQualifiedBoxedSourceName(); + } + else { + argTypeName = argType.getQualifiedSourceName(); + } sw.println("( (" + type.getQualifiedSourceName() + ") bean)." - + setter.getName() + "( (" + argType.getQualifiedSourceName() + + setter.getName() + "( (" + argTypeName + ") args[0] );"); sw.println("return null;"); sw.outdent(); ===================== Regards, Olivier Monaco Feb 09, 2009 issue 3 ([Patch] Deferred binding generator bug on property typed wit...) reported by olivier....@free.fr - Define this class: ====================== public static class Test<T> implements BeanAdapter { private PropertyChangeSupport support; private T property; public T getProperty() { return property; } public void setProperty(T property) { support.firePropertyChange("property", this.property, property); this.property = property; } // ... } ====================== You obtain the following error: ====================== Errors in 'transient source for org.gwt.beansbinding.core.client.util.GWTBeansBindingIntrospector' Line 87: Syntax error on token "extends", ( expected Line 97: Syntax error on token "extends", . expected Line 100: Syntax error, insert ")" to complete Expression See snapshot: /tmp/org.gwt.beansbinding.core.client.util.GWTBeansBindingIntrospector20363.java ====================== Because the deferred binding generator generates the following code: ====================== beanInfo.addPropertyDescriptor( new PropertyDescriptor( "property", T extends java.lang.Object.class, new Method() ... ====================== (look at the "T extends java.lang.Object.class"). This is because you use the type and not its erasure. You can correct this bug using the following patch: ====================== Index: BeanPropertyDescriptorGenerator.java =================================================================== --- BeanPropertyDescriptorGenerator.java (revision 42) +++ BeanPropertyDescriptorGenerator.java (working copy) @@ -150,7 +150,7 @@ JParameter[] parameters = method.getParameters(); if (parameters.length == 1) { JParameter parameter = parameters[0]; - propertyType = parameter.getType().getQualifiedSourceName(); + propertyType = parameter.getType().getErasedType().getQualifiedSourceName(); } else { logger.log(Type.WARN, "Property '" + name + "' has " + parameters.length + " parameters: " + parameters + "!"); @@ -173,7 +173,7 @@ } else if (method.getName().startsWith("get") && method.getParameters().length == 0) { String name = Introspector.decapitalize(method.getName().substring(3)); - String propertyType = method.getReturnType().getQualifiedSourceName(); + String propertyType = method.getReturnType().getErasedType().getQualifiedSourceName(); Property property = properties.get(name); if (property == null) { property = new Property(name); @@ -191,7 +191,7 @@ } else if (method.getName().startsWith("is") && method.getParameters().length == 0) { String name = Introspector.decapitalize(method.getName().substring(2)); - String propertyType = method.getReturnType().getQualifiedSourceName(); + String propertyType = method.getReturnType().getErasedType().getQualifiedSourceName(); Property property = properties.get(name); if (property == null) { property = new Property(name); @@ -268,7 +268,7 @@ sw.println("public Object invoke( Object bean, Object... args )"); sw.println("{"); sw.indent(); - JType argType = setter.getParameters()[0].getType(); + JType argType = setter.getParameters()[0].getType().getErasedType(); sw.println("( (" + type.getQualifiedSourceName() + ") bean)." + setter.getName() + "( (" + argType.getQualifiedSourceName() + ") args[0] );"); ====================== I hope this help. Thanks for your work. Regards, Olivier M. Define this class: ====================== public static class Test<T> implements BeanAdapter { private PropertyChangeSupport support; private T property; public T getProperty() { return property; } public void setProperty(T property) { support.firePropertyChange("property", this.property, property); this.property = property; } // ... } ====================== You obtain the following error: ====================== Errors in 'transient source for org.gwt.beansbinding.core.client.util.GWTBeansBindingIntrospector' Line 87: Syntax error on token "extends", ( expected Line 97: Syntax error on token "extends", . expected Line 100: Syntax error, insert ")" to complete Expression See snapshot: /tmp/org.gwt.beansbinding.core.client.util.GWTBeansBindingIntrospector20363.java ====================== Because the deferred binding generator generates the following code: ====================== beanInfo.addPropertyDescriptor( new PropertyDescriptor( "property", T extends java.lang.Object.class, new Method() ... ====================== (look at the "T extends java.lang.Object.class"). This is because you use the type and not its erasure. You can correct this bug using the following patch: ====================== Index: BeanPropertyDescriptorGenerator.java =================================================================== --- BeanPropertyDescriptorGenerator.java (revision 42) +++ BeanPropertyDescriptorGenerator.java (working copy) @@ -150,7 +150,7 @@ JParameter[] parameters = method.getParameters(); if (parameters.length == 1) { JParameter parameter = parameters[0]; - propertyType = parameter.getType().getQualifiedSourceName(); + propertyType = parameter.getType().getErasedType().getQualifiedSourceName(); } else { logger.log(Type.WARN, "Property '" + name + "' has " + parameters.length + " parameters: " + parameters + "!"); @@ -173,7 +173,7 @@ } else if (method.getName().startsWith("get") && method.getParameters().length == 0) { String name = Introspector.decapitalize(method.getName().substring(3)); - String propertyType = method.getReturnType().getQualifiedSourceName(); + String propertyType = method.getReturnType().getErasedType().getQualifiedSourceName(); Property property = properties.get(name); if (property == null) { property = new Property(name); @@ -191,7 +191,7 @@ } else if (method.getName().startsWith("is") && method.getParameters().length == 0) { String name = Introspector.decapitalize(method.getName().substring(2)); - String propertyType = method.getReturnType().getQualifiedSourceName(); + String propertyType = method.getReturnType().getErasedType().getQualifiedSourceName(); Property property = properties.get(name); if (property == null) { property = new Property(name); @@ -268,7 +268,7 @@ sw.println("public Object invoke( Object bean, Object... args )"); sw.println("{"); sw.indent(); - JType argType = setter.getParameters()[0].getType(); + JType argType = setter.getParameters()[0].getType().getErasedType(); sw.println("( (" + type.getQualifiedSourceName() + ") bean)." + setter.getName() + "( (" + argType.getQualifiedSourceName() + ") args[0] );"); ====================== I hope this help. Thanks for your work. Regards, Olivier M. Feb 06, 2009 issue 1 (PropertyResolutionException is not properly Serializable) Status changed by georgopoulos.georgios - Hi, I know you don't do GWT anymore, but to close this issue... It seems that you didn't add: static { GWTBeansBinding.init(); } like in: http://code.google.com/p/gwt-beans-binding/source/browse/trunk/src/org/gwt/beansbinding/client/Main.java in your application. Kind Regards, George. Status: Invalid Hi, I know you don't do GWT anymore, but to close this issue... It seems that you didn't add: static { GWTBeansBinding.init(); } like in: http://code.google.com/p/gwt-beans-binding/source/browse/trunk/src/org/gwt/beansbinding/client/Main.java in your application. Kind Regards, George. Status: Invalid Feb 06, 2009 r42 (0.2.3) committed by georgopoulos.georgios - 0.2.3 0.2.3 Feb 06, 2009 gwt-beans-binding-0.2.3.jar (GWT Beans Binding 0.2.3 (GWT 1.5 & GWT 1.6)) file uploaded by georgopoulos.georgios Feb 06, 2009 r41 (0.2.3) committed by georgopoulos.georgios - 0.2.3 0.2.3 Feb 06, 2009 r40 (Bug fix in code gererator and classpath changes for GWT-1.6) committed by georgopoulos.georgios - Bug fix in code gererator and classpath changes for GWT-1.6 Bug fix in code gererator and classpath changes for GWT-1.6 Feb 06, 2009 r39 (Bug fix in code generator.) committed by georgopoulos.georgios - Bug fix in code generator. Bug fix in code generator. Feb 06, 2009 r38 (GWT-1.6) committed by georgopoulos.georgios - GWT-1.6 GWT-1.6 Jan 17, 2009 issue 1 (PropertyResolutionException is not properly Serializable) reported by dhoffer6 - What steps will reproduce the problem? 1. Try to pass this object through GWT RPC mechanism. What is the expected output? What do you see instead? This exception should be able to be passed through GWT RPC. However it cannot and you get error instead. What version of the product are you using? On what operating system? Current, 0.2.2. Windows. So hosted mode is using IE, non-hosted Firefox. Please provide any additional information below. We don't yet know what is causing this exception to be thrown. It only happens in non-hosted mode (It does happen when we try to run using compiled JS with hosted server). This error happens when we try to run an app which we just updated to use Actions/Bindings. Again, it works in hosted mode (Windows at least) but not otherwise. In any case, this object must be serializable so it can be used if the error does occur. It just needs a default constructor. What steps will reproduce the problem? 1. Try to pass this object through GWT RPC mechanism. What is the expected output? What do you see instead? This exception should be able to be passed through GWT RPC. However it cannot and you get error instead. What version of the product are you using? On what operating system? Current, 0.2.2. Windows. So hosted mode is using IE, non-hosted Firefox. Please provide any additional information below. We don't yet know what is causing this exception to be thrown. It only happens in non-hosted mode (It does happen when we try to run using compiled JS with hosted server). This error happens when we try to run an app which we just updated to use Actions/Bindings. Again, it works in hosted mode (Windows at least) but not otherwise. In any case, this object must be serializable so it can be used if the error does occur. It just needs a default constructor. Jan 03, 2009 gwt-beans-binding-0.2.2.jar (GWT Beans Binding 0.2.2 (GWT 1.5)) file uploaded by georgopoulos.georgios - Labels: Featured Labels: Featured Jan 03, 2009 r37 (0.2.2) committed by georgopoulos.georgios - 0.2.2 0.2.2 Jan 03, 2009 r36 (0.2.2) committed by georgopoulos.georgios - 0.2.2 0.2.2 Jan 01, 2009 r35 (type.getMethods() replaced by type.getOverridableMethods() i...) committed by georgopoulos.georgios - type.getMethods() replaced by type.getOverridableMethods() in generator class. type.getMethods() replaced by type.getOverridableMethods() in generator class. Older Dec 19, 2008 r34 ([No log message]) committed by georgopoulos.georgios - [No log message] [No log message] Dec 19, 2008 gwt-beans-binding-0.2.1.jar (GWT Beans Binding 0.2.1 (GWT 1.5)) file uploaded by georgopoulos.georgios - Labels: Featured Labels: Featured Dec 19, 2008 r33 (0.2.1) committed by georgopoulos.georgios - 0.2.1 0.2.1 Dec 19, 2008 r32 (static { GWTBeansBinding.init(); } will invoke the Pr...) committed by georgopoulos.georgios - static { GWTBeansBinding.init(); } will invoke the PropertyDescriptor generator. static { GWTBeansBinding.init(); } will invoke the PropertyDescriptor generator. Dec 19, 2008 r31 (GWTx upgrade) committed by georgopoulos.georgios - GWTx upgrade GWTx upgrade Dec 19, 2008 r30 (GWTx upgrade) committed by georgopoulos.georgios - GWTx upgrade GWTx upgrade Dec 19, 2008 r29 (GWTx upgrade) committed by georgopoulos.georgios - GWTx upgrade GWTx upgrade Dec 16, 2008 r28 ([No log message]) committed by georgopoulos.georgios - [No log message] [No log message] Dec 16, 2008 r27 ([No log message]) committed by georgopoulos.georgios - [No log message] [No log message]

issue 3 ([Patch] Deferred binding generator bug on property typed wit...) reported by olivier....@free.fr - Define this class: ====================== public static class Test<T> implements BeanAdapter { private PropertyChangeSupport support; private T property; public T getProperty() { return property; } public void setProperty(T property) { support.firePropertyChange("property", this.property, property); this.property = property; } // ... } ====================== You obtain the following error: ====================== Errors in 'transient source for org.gwt.beansbinding.core.client.util.GWTBeansBindingIntrospector' Line 87: Syntax error on token "extends", ( expected Line 97: Syntax error on token "extends", . expected Line 100: Syntax error, insert ")" to complete Expression See snapshot: /tmp/org.gwt.beansbinding.core.client.util.GWTBeansBindingIntrospector20363.java ====================== Because the deferred binding generator generates the following code: ====================== beanInfo.addPropertyDescriptor( new PropertyDescriptor( "property", T extends java.lang.Object.class, new Method() ... ====================== (look at the "T extends java.lang.Object.class"). This is because you use the type and not its erasure. You can correct this bug using the following patch: ====================== Index: BeanPropertyDescriptorGenerator.java =================================================================== --- BeanPropertyDescriptorGenerator.java (revision 42) +++ BeanPropertyDescriptorGenerator.java (working copy) @@ -150,7 +150,7 @@ JParameter[] parameters = method.getParameters(); if (parameters.length == 1) { JParameter parameter = parameters[0]; - propertyType = parameter.getType().getQualifiedSourceName(); + propertyType = parameter.getType().getErasedType().getQualifiedSourceName(); } else { logger.log(Type.WARN, "Property '" + name + "' has " + parameters.length + " parameters: " + parameters + "!"); @@ -173,7 +173,7 @@ } else if (method.getName().startsWith("get") && method.getParameters().length == 0) { String name = Introspector.decapitalize(method.getName().substring(3)); - String propertyType = method.getReturnType().getQualifiedSourceName(); + String propertyType = method.getReturnType().getErasedType().getQualifiedSourceName(); Property property = properties.get(name); if (property == null) { property = new Property(name); @@ -191,7 +191,7 @@ } else if (method.getName().startsWith("is") && method.getParameters().length == 0) { String name = Introspector.decapitalize(method.getName().substring(2)); - String propertyType = method.getReturnType().getQualifiedSourceName(); + String propertyType = method.getReturnType().getErasedType().getQualifiedSourceName(); Property property = properties.get(name); if (property == null) { property = new Property(name); @@ -268,7 +268,7 @@ sw.println("public Object invoke( Object bean, Object... args )"); sw.println("{"); sw.indent(); - JType argType = setter.getParameters()[0].getType(); + JType argType = setter.getParameters()[0].getType().getErasedType(); sw.println("( (" + type.getQualifiedSourceName() + ") bean)." + setter.getName() + "( (" + argType.getQualifiedSourceName() + ") args[0] );"); ====================== I hope this help. Thanks for your work. Regards, Olivier M.

Define this class: ====================== public static class Test<T> implements BeanAdapter { private PropertyChangeSupport support; private T property; public T getProperty() { return property; } public void setProperty(T property) { support.firePropertyChange("property", this.property, property); this.property = property; } // ... } ====================== You obtain the following error: ====================== Errors in 'transient source for org.gwt.beansbinding.core.client.util.GWTBeansBindingIntrospector' Line 87: Syntax error on token "extends", ( expected Line 97: Syntax error on token "extends", . expected Line 100: Syntax error, insert ")" to complete Expression See snapshot: /tmp/org.gwt.beansbinding.core.client.util.GWTBeansBindingIntrospector20363.java ====================== Because the deferred binding generator generates the following code: ====================== beanInfo.addPropertyDescriptor( new PropertyDescriptor( "property", T extends java.lang.Object.class, new Method() ... ====================== (look at the "T extends java.lang.Object.class"). This is because you use the type and not its erasure. You can correct this bug using the following patch: ====================== Index: BeanPropertyDescriptorGenerator.java =================================================================== --- BeanPropertyDescriptorGenerator.java (revision 42) +++ BeanPropertyDescriptorGenerator.java (working copy) @@ -150,7 +150,7 @@ JParameter[] parameters = method.getParameters(); if (parameters.length == 1) { JParameter parameter = parameters[0]; - propertyType = parameter.getType().getQualifiedSourceName(); + propertyType = parameter.getType().getErasedType().getQualifiedSourceName(); } else { logger.log(Type.WARN, "Property '" + name + "' has " + parameters.length + " parameters: " + parameters + "!"); @@ -173,7 +173,7 @@ } else if (method.getName().startsWith("get") && method.getParameters().length == 0) { String name = Introspector.decapitalize(method.getName().substring(3)); - String propertyType = method.getReturnType().getQualifiedSourceName(); + String propertyType = method.getReturnType().getErasedType().getQualifiedSourceName(); Property property = properties.get(name); if (property == null) { property = new Property(name); @@ -191,7 +191,7 @@ } else if (method.getName().startsWith("is") && method.getParameters().length == 0) { String name = Introspector.decapitalize(method.getName().substring(2)); - String propertyType = method.getReturnType().getQualifiedSourceName(); + String propertyType = method.getReturnType().getErasedType().getQualifiedSourceName(); Property property = properties.get(name); if (property == null) { property = new Property(name); @@ -268,7 +268,7 @@ sw.println("public Object invoke( Object bean, Object... args )"); sw.println("{"); sw.indent(); - JType argType = setter.getParameters()[0].getType(); + JType argType = setter.getParameters()[0].getType().getErasedType(); sw.println("( (" + type.getQualifiedSourceName() + ") bean)." + setter.getName() + "( (" + argType.getQualifiedSourceName() + ") args[0] );"); ====================== I hope this help. Thanks for your work. Regards, Olivier M.

Last 7 days

Earlier this year

Older