Issue 2 - greenend-vcs - vcs commit with more than one filename fails on p4

Issue 2:	vcs commit with more than one filename fails on p4
	1 person starred this issue and may be notified of changes.	Back to list

Status:	Fixed
Owner:	ewxrjk
Closed:	Jul 05
Type-Defect
Priority-High

Reported by ewxrjk, May 19, 2009

$ vcs commit Makefile maketags
Usage: submit [ -i -s -r -f option ] [ -c changelist# | -d description ] [file]
Missing/wrong number of arguments.

Comment 1 by ewxrjk, Jun 01, 2009

Observations:

1) At least as of 2008.2, p4 submit can take multiple filenames on its command line.
 So for sufficiently recent p4, this bug doesn't exist.

2) ...but this appears to be a property of the Perforce server NOT the client, so it
isn't sufficient for end users to update their client; rather they will have to
persuade their administrators to update their server, something they're not to be
willing to do on a whim.  For ease of testing it'll be simpler to assume this
limitation always exist rather than attempt to detect it at runtime and conditionally
work around it.

3) vcs ought to use "p4 submit -d" for "vcs commit -m", where possible.  I'm not sure
why I didn't do this in the first place.

4) vcs will have to synthesize a default change list and invoke the editor ourselves
in the case where (i) p4 submit doesn't accept multiple files and (ii) more than one
file is specified and (iii) a message is not specified.

Comment 2 by ewxrjk, Jun 05, 2009

> 1) At least as of 2008.2, p4 submit can take multiple filenames on
> its command line. So for sufficiently recent p4, this bug doesn't exist.

In fact this is not true, the help message is incorrect.

Comment 3 by ewxrjk, Jul 05, 2009

revno: 149
committer: Richard Kettlewell <rjk@greenend.org.uk>
branch nick: vcs
timestamp: Sun 2009-07-05 16:55:39 +0100
message:
  Rewrote p4_commit() to handle all four cases of -m and the file list.  
  In one of the cases this implies that vcs invokes the user's editor 
  directly.

Status: Fixed