| Issue 413: | 'Make install' list of lua scripts is hardcoded in makefile, and installed anyway if NOLUA=1. | |
| 1 person starred this issue and may be notified of changes. | Back to list |
The removed scripts are still present in src/Makefile so make install exits with:
cp: cannot stat `../share/grafx2/scripts/pic_ni_Colorspace12bit.lua': No such file or directory
cp: cannot stat `../share/grafx2/scripts/pic_ni_Colorspace15bit.lua': No such file or directory
cp: cannot stat `../share/grafx2/scripts/pic_ni_Colorspace18bit.lua': No such file or directory
cp: cannot stat `../share/grafx2/scripts/pic_ni_Grid8.lua': No such file or directory
cp: cannot stat `../share/grafx2/scripts/pic_ni_Grid8red.lua': No such file or directory
cp: cannot stat `../share/grafx2/scripts/pic_ni_GridIso.lua': No such file or directory
cp: cannot stat `../share/grafx2/scripts/pic_ni_PaletteX1.lua': No such file or directory
cp: cannot stat `../share/grafx2/scripts/pic_ni_PaletteX8.lua': No such file or directory
make: *** [install] Error 1
Aborting...
Patch included (only removed the entries), but to prevent similar bumps on the ride, is it be possible to
a) make the script list dynamical (add all *.lua in /path/to/scripts to list)
b) cd into the directory and cp *.lua from there?
or do they all just have to be manually added to or removed from the Makefile?
Jan 16, 2011
#1
sm4...@yahoo.com
Jan 16, 2011
The scripts whose name stats whith _tst_ should not be installed. Wildcards are a bit tricky because the makefile is mutiplatform, and on amiga the wildcard is not *.*, but #?. Other than that, you're right.
Labels:
-OpSys- -Milestone- OpSys-All Milestone-2.3 Component-BuildSys
Jan 17, 2011
If the user has created some scripts of his own, uninstall shouldn't delete them. This is reason enough for me to state the exact list of files to copy and delete. Also, on install/uninstall, the Makefile has no way to know if the program was built with NOLUA=1, so it installs them anyway - this part can't fail as long as we get the list right. Anyway, now that we handle subdirectories for scripts browsing, we're probably going to rework the directory tree... Maybe based on the prefixes by DawnBringer (scene, picture, brush, palette,...), maybe also something to separate everyday tools from "demo" scripts.
Jan 17, 2011
@yrizoud: "Also, on install/uninstall, the Makefile has no way to know if the program was built with NOLUA=1, so it installs them anyway" ..hmm.. you're right about that. That's when the ./configure script usually comes in handy, right? I'm asking this only because I don't know?
Jan 17, 2011
Yes, that'd be the kind of things ./configure usually does. For this project, we decided to go on an "everything in the makefile" approach, because it sounded simpler. (the autoconf tools are doing too much things beyond human understanding). Getting the makefile to work on all platforms is a bit tricky, but so far we got it working. We could store the build settings in version.c (generated at buildtime) and get the makefile to parse it, but doing that in a cross platform way would likely be a nightmare. However, make install only needs to work for unixish platforms, so we could actually use wildcards in this particular area. We need folders in the lua-script directory, but I'm not sure about Dawnbringer's layout. I'd drop the 'scene' folder, at least. Demo scripts could be moved to a "demo" folder, or even be made part of the 'art disk' package we plan to make available (see other issue in this bugtracker).
Jan 20, 2011
Fixed by Yves yesterday as emergency fix, we still want something more automated :)
Summary:
'Make install' list of lua scripts is hardcoded in makefile, and installed anyway if NOLUA=1.
Feb 15, 2011
(No comment was entered for this change.)
Labels:
Milestone-2.4
Apr 10, 2011
(No comment was entered for this change.)
Labels:
Milestone-2.5
|
|
| ► Sign in to add a comment |
