Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PATCH] Fix PPC64 macro usage in getpc testcase #460

Closed
alk opened this issue Aug 23, 2015 · 2 comments
Closed

[PATCH] Fix PPC64 macro usage in getpc testcase #460

alk opened this issue Aug 23, 2015 · 2 comments
Assignees
@alk
Labels
Priority-Medium Status-Fixed Type-Defect

Comments

@alk
Copy link
Contributor

alk commented Aug 23, 2015

Originally reported on Google Code with ID 457

The 'getpc' testcase uses a wrong PPC64 preprocessor directive.

--- a/src/tests/getpc_test.cc
+++ b/src/tests/getpc_test.cc
@@ -106,7 +106,7 @@ int main(int argc, char** argv) {
   //      ElfW(Addr) gp;      /* global pointer */
   //   };
   // We want the code entry point.
-#if defined(__ia64) || defined(__ppc64)     // NOTE: ppc64 is UNTESTED
+#if defined(__ia64) || defined(__powerpc64__)     // NOTE: ppc64 is UNTESTED
   expected = ((char**)expected)[0];         // this is "ip"
 #endif

Reported by zatrazz on 2012-07-25 04:35:28
@alk alk self-assigned this Aug 23, 2015
@alk
Copy link
Contributor Author

alk commented Aug 23, 2015 

Patch has been applied and committed to the main trunk. I do not have the means to test
the patch so if you could grab the code from the main trunk and give it a final verification
that would be awesome!

------------------------------------------------------------------------
r154 | chappedm@gmail.com | 2012-09-17 20:52:13 -0400 (Mon, 17 Sep 2012) | 1 line

issue-457: Fixed an issue where the 'getpc' testcase was using the wrong PPC64 preprocessor
directive
------------------------------------------------------------------------

Reported by chappedm on 2012-09-18 00:54:27

  • Status changed: Fixed

@alk
Copy link
Contributor Author

alk commented Aug 23, 2015 

Issue 447 has been merged into this issue.

Reported by chappedm on 2012-11-04 18:36:32

@alk alk closed this as completed Aug 23, 2015
@alk alk mentioned this issue Aug 23, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alk alk

Labels
Priority-Medium Status-Fixed Type-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alk