Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guard around defining WIN32_LEAN_AND_MEAN #127

Closed
alk opened this issue Aug 22, 2015 · 3 comments
Closed

Add guard around defining WIN32_LEAN_AND_MEAN #127

alk opened this issue Aug 22, 2015 · 3 comments
Assignees
@alk
Labels
Priority-Medium Status-Fixed Type-Patch

Comments

@alk
Copy link
Contributor

alk commented Aug 22, 2015

Originally reported on Google Code with ID 124

If the embedding project already defines the macro, we get warnings.

A simple fix.

Reported by mbelshe@chromium.org on 2009-04-14 20:03:44

- _Attachment: [leanmean.patch](https://storage.googleapis.com/google-code-attachments/gperftools/issue-124/comment-0/leanmean.patch)_
@alk alk self-assigned this Aug 22, 2015
@alk
Copy link
Contributor Author

alk commented Aug 22, 2015 

I don't understand -- what embedding project will be #including windows/port.h?  Are
you using the code in some way where you don't just compile it as a library?  port.h
is definitely not meant to be externally exposed!

That said, this seems like good hygiene in any case, so I'm glad to take the patch.

I'm just confused why it's necessary.

Reported by csilvers on 2009-04-14 20:32:14

  • Status changed: Started

@alk
Copy link
Contributor Author

alk commented Aug 22, 2015

Reported by csilvers on 2009-04-14 21:23:09

  • Labels added: Type-Patch, Priority-Medium

@alk
Copy link
Contributor Author

alk commented Aug 22, 2015 

This is fixed in perftools 1.2, just released.

Reported by csilvers on 2009-04-18 00:14:07

  • Status changed: Fixed

@alk alk closed this as completed Aug 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alk alk

Labels
Priority-Medium Status-Fixed Type-Patch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alk