New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fatal failure in SetUpTestCase() function should skip running tests. #247
Comments
Original comment by
|
Original comment by |
Original comment by |
Original comment by |
Original comment by |
Original comment by |
Original comment by |
Original comment by |
You can "fix" this yourself by using a test event listener, as described in the advanced user guide, by doing something like this in your derived test event listener class (which you would register in your main()):
And then register the event listener in your
|
Is there any progress on this issue? These seems like a major issue to me and should be prioritized. |
see google/googletest#247, gtest does not fail its tests even if SetUpTestCase() fails. after shutdown(), the behaviour of RadosClient is undefined. so we'd better avoid using it anymore in that case. Signed-off-by: Kefu Chai <kchai@redhat.com>
I also have this issue, partially fixed with the suggested workaround.
|
Guys! Any progress o this topic?? It's been hanging here since 2015... |
It's been hanging here since 2010... I face this issue with gtest1.8, and when it will fix? I don't think test event listener is a good way to fix it by myself. |
Hello, any progress in this issue? I have the same problem. |
Here as well. Please take a look! |
Done, see 9ed99c6 |
@gennadiycivil, can you clarify whether that change is expected to prevent test bodies from running (be skipped) when SetUpTestSuite() assertions fails? That is the crux of the current issue, so I'd like to understand whether it is actually fixed. |
wow , 10 years. |
Due to google/googletest#247 Can be reverted once googletest version is at least 1.11.0
* Include bringup.launch * Set unique udp port for data connection * Only start laserscan validation when connected on topic * Omit using SetUpTestSuite() Due to google/googletest#247 Can be reverted once googletest version is at least 1.11.0
* Fix hwtest_scan_compare * Include bringup.launch * Set unique udp port for data connection * Only start laserscan validation when connected on topic * Omit using SetUpTestSuite() Due to google/googletest#247 Can be reverted once googletest version is at least 1.11.0 * Update hwtest_readme.md * Update forwarded udp ports * Add description for running test with reference scan using industrial_ci
* Add rules_swift 1.2.0 * Add repository name to metadata * Add prefix to build targets * Remove strip_prefix since this is a release archive * Add patch adding module extension * Use clang on non-macOS platforms * Download Swift for Ubuntu20.04 * Filter out broken grpc example on Linux We do the same in the `rules_swift` repo: https://github.com/bazelbuild/rules_swift/blob/b6a111ea475da15793dfa5dda7e3e3646658f407/.bazelci/presubmit.yml#L24-L27
Original issue reported on code.google.com by
pvshew...@gmail.com
on 11 Jan 2010 at 6:39The text was updated successfully, but these errors were encountered: