Issue 341 - googleappengine - URL Fetch API should pass querystring in HTTP GET

Status:	Fixed
Owner:	----
Closed:	May 2008
Type-Defect
Priority-Medium

Sign in to add a comment

Reported by jkester, May 11, 2008

The URL Fetch API strips querystring parameters from a supplied URL before
performing the HTTP GET.

Passing the querystring through would make it possible to use the fetch API
against resources only available via querystring.

Comment 1 by shopdit, May 12, 2008

This actually worked with version 1.0.0 of google app engine.  Looks like the strip
of the querystring was implemented in either version 1.0.1 or 1.0.2.

Comment 2 by shopdit, May 13, 2008

If anybody has a solution/workaround for this could they post it here?  Right now the
following is occurring for me..
	  url = 'http://my-url-here.com/stuff/xml?VarOne=Stripped&VarTwo=RemovedAsWell'
	 
	  result = urlfetch.fetch(url)

Results in just a url fetch like so...
http://my-url-here.com/stuff/xml
stripping anything beginning with the ? character.

Comment 3 by jkester, May 13, 2008

The attached patch for google/appengine/api/urlfetch_stub.py correctly supplies a
querystring (if it exists) with the HTTP GET.

	urlfetch_stub_patch.txt
	753 bytes Download

Comment 4 by mistaSteve, May 13, 2008

thanks jkester.  I thought I was nuts or screwed something up.

Comment 6 by shopdit, May 14, 2008

Thanks jkester!  Works perfectly.

Comment 7 by shopdit, May 14, 2008

Attached urlfetch_stub.py for those like me who are lazy and want to simply take the
new file and replace the old one :)

	urlfetch_stub.py
	6.3 KB Download

Comment 8 by yaakovsash, May 20, 2008

Is this an issue on the local dev server or on deployed apps as well? If this also 
an issue on deployed apps, then downloading urlfetch_stub.py locally will not fix 
the issue. Right?

Comment 9 by eweaver, May 20, 2008

It is only an SDK issue. It does not affect production deployments.

Comment 10 by will.sargent, May 25, 2008

Dude.  Took me hours to figure this one out.

Comment 11 by abimanyuraja, May 26, 2008

Damn. I spent so much time on this. Anyway, good to see finally there's a fix.

Comment 12 by mlh496, May 26, 2008

I spent quite a bit of time on this, too.  The patch worked for me.  Thanks jkester!

Comment 13 by ryanb+ap...@google.com, May 29, 2008

hi all! thanks for the report, and sorry for the trouble. this should be fixed in 1.1.0.

Status: Fixed

Issue 341:	URL Fetch API should pass querystring in HTTP GET
	25 people starred this issue and may be notified of changes.	Back to list