Fixed
Status Update
Comments
pe...@google.com <pe...@google.com>
jo...@gmail.com <jo...@gmail.com> #2
This is per design; in order to know if a user has the Chromecast extension installed (and which one), cast_sender.js requests the script from all potentially installed extensions.
kl...@google.com <kl...@google.com> #3
This is terrible coding.
pe...@google.com <pe...@google.com>
ma...@google.com <ma...@google.com>
11...@eliotstock.com <11...@eliotstock.com> #4
This is amateurish at best, incompetent at worst. It's bad and Chrome developers should feel bad.
mu...@bygsoft.com <mu...@bygsoft.com> #5
at least keep the console free of errors...
ri...@google.com <ri...@google.com> #6
Using v1.5.3 of the Python SDK, I'm still unable to set the In-Reply-To or References headers in emails. In my code I have some debug/test code:
email_msg = mail.EmailMessage(**send_args)
email_msg.check_initialized()
logging.info ('Email hdrs before: "%s"', email_msg.headers)
email_msg.headers = {'In-Reply-To': _encode_safely(in_reply_to),
'References': _encode_safely(in_reply_to)}
logging.info ('Email hdrs after: "%s"', email_msg.headers)
logging.info ('Email msg: "%s"', email_msg.to_mime_message())
As you can see in the log snippet from my local dev instance below (email addresses have been censored), the headers are set in the EmailMessage just fine but are not being added to the MIME message by mail_message_to_mime_message. The end result is that the email is sent without the headers, as MailServiceStub.send calls mail.MailMessageToMIMEMessage. I've attached a patch for adding the headers to the MIME message.
INFO 2011-08-23 21:50:57,760 views.py:3179] Email hdrs before: "{'References': '<20110822181154.E2160102052@illian.mtv.corp.google.com>', 'In-Reply-To': '<20110822181154.E2160102052@illian.mtv.corp.google.com>'}"
INFO 2011-08-23 21:50:57,760 views.py:3182] Email hdrs after: "{'References': '<20110822181154.E2160102052@illian.mtv.corp.google.com>', 'In-Reply-To': '<20110822181154.E2160102052@illian.mtv.corp.google.com>'}"
INFO 2011-08-23 21:50:57,760 views.py:3183] Email msg: "From nobody Tue Aug 23 21:50:57 2011
Content-Type: multipart/mixed; boundary="===============8738160742719550684=="
MIME-Version: 1.0
To: XXXXXX@XXXXXX
Cc: XXXX@XXXX
From: test@example.com
Reply-To: test@example.com, XXXXXX@XXXXXX,
XXXX@XXXX
Subject: Re: message ID test ( issue 1 )
--===============8738160742719550684==
email_msg = mail.EmailMessage(**send_args)
email_msg.check_initialized()
email_msg.headers = {'In-Reply-To': _encode_safely(in_reply_to),
'References': _encode_safely(in_reply_to)}
As you can see in the log snippet from my local dev instance below (email addresses have been censored), the headers are set in the EmailMessage just fine but are not being added to the MIME message by mail_message_to_mime_message. The end result is that the email is sent without the headers, as MailServiceStub.send calls mail.MailMessageToMIMEMessage. I've attached a patch for adding the headers to the MIME message.
INFO 2011-08-23 21:50:57,760 views.py:3179] Email hdrs before: "{'References': '<20110822181154.E2160102052@illian.mtv.corp.google.com>', 'In-Reply-To': '<20110822181154.E2160102052@illian.mtv.corp.google.com>'}"
INFO 2011-08-23 21:50:57,760 views.py:3182] Email hdrs after: "{'References': '<20110822181154.E2160102052@illian.mtv.corp.google.com>', 'In-Reply-To': '<20110822181154.E2160102052@illian.mtv.corp.google.com>'}"
INFO 2011-08-23 21:50:57,760 views.py:3183] Email msg: "From nobody Tue Aug 23 21:50:57 2011
Content-Type: multipart/mixed; boundary="===============8738160742719550684=="
MIME-Version: 1.0
To: XXXXXX@XXXXXX
Cc: XXXX@XXXX
From: test@example.com
Reply-To: test@example.com, XXXXXX@XXXXXX,
XXXX@XXXX
Subject: Re: message ID test (
--===============8738160742719550684==
pr...@google.com <pr...@google.com> #7
This would be about 3 lines of code to fix. I'm very surprised Chromecast team considers it reasonable to dump a long list of error messages in the vast majority of people's browsers, ie > 99% of users of a typical web app are either using another browser or using Chrome but without Chromecast, and this will aversely affect all of them.
"Don’t leave “broken windows” (bad designs, wrong decisions, or poor code) unrepaired. Fix each one as soon as it is discovered." [1]. By routinely dumping error messages in almost everyone's consoles as if it were a normal situation, you are encouraging developers and users to ignore error messages instead of taking them seriously, as they should do, and you are making it impossible for developers to attain a pristine error log.
1.https://pragprog.com/the-pragmatic-programmer/extracts/software-entropy
"Don’t leave “broken windows” (bad designs, wrong decisions, or poor code) unrepaired. Fix each one as soon as it is discovered." [1]. By routinely dumping error messages in almost everyone's consoles as if it were a normal situation, you are encouraging developers and users to ignore error messages instead of taking them seriously, as they should do, and you are making it impossible for developers to attain a pristine error log.
1.
ri...@google.com <ri...@google.com> #8
This is ridiculous and very annoying. I dont want to see this error every time when developing.
Please fix!
Please fix!
pr...@google.com <pr...@google.com> #9
Agree with all comments above. Please fix!
ak...@gmail.com <ak...@gmail.com> #10
Very annoying for me too. Trying to fix a bug in a program and it took me a while to figure out that this wasn't part of the bug and wasn't something I was doing.
mc...@gmail.com <mc...@gmail.com> #11
yeah amateurish at best. should fix!
ri...@google.com <ri...@google.com> #12
I have not installed cast sender yet I'm seeing errors in my chrome dev console. not good.
Description
it doesn't offer In-Reply-To or References field that are important to establish
threading support in most email applications.
While it is possible to set the fields in emailMessage.original email object,
send() method simply ignore these fields.
Possible enhances:
1. Expose extensible fields representation to library clients, or
2. (better), add reply() and forward() methods that create new email object
with the appropriate In-Reply-To or References field.