Export to GitHub

google-web-toolkit - issue #5687

samples/expenses/pom.xml changes for each 2.1.1-RC and GA


Posted on Nov 30, 2010 by Swift Ox

We need to bump the gwt version in the pom.xml with each RC, and with the final release.

We also need to fix the pluginRepository entry.

Comment #1

Posted on Dec 9, 2010 by Swift Ox

From Dave:

maven changes needed are

  1. Change gwt.version in expenses pom to 2.1.1-rc1
  2. Change version 2.1.0 to 2.1.1-rc1 in tools/scripts/maven_script.sh
  3. Run maven_script.sh to install current build in your local repo

Test cases: 1. Run Expenses app with mvn gwt:run. See samples/expenses/MAVEN-README for funky run cmd with cd hack 2. Import into Eclipse (w/ or w/o STS) as existing maven project and Run As | Web App

Would be even better if we could lose the 2.1.0.M3 pluginRepository in expenses/pom.xml and instead use gwt-maven-plugin version 2.1.0-1 (just released). I'll test that config.

Comment #2

Posted on Dec 9, 2010 by Swift Ox

(No comment was entered for this change.)

Comment #3

Posted on Dec 9, 2010 by Swift Ox

http://gwt-code-reviews.appspot.com/1202801

Comment #4

Posted on Dec 9, 2010 by Swift Ox

Off to a bad start. mvn says it can't find the gwt-user 2.1.1-rc resource, and suggests that I upload it using exactly the commands the mavne_script.sh does. Output attached.

Attachments

Comment #5

Posted on Dec 9, 2010 by Swift Rhino

Could issue 4853 be fixed at the same time? (or at least for 2.1.1 "GA")

Comment #6

Posted on Dec 9, 2010 by Swift Rhino

To make GWT 2.1.1 work with gwt-maven-plugin 2.1.0-1, you have to explicitly declare gwt-user and gwt-dev as plugin dependencies. I'm almost sure it's not a "supported use" of the plugin though. org.codehaus.mojo gwt-maven-plugin 2.1.0-1 com.google.gwt gwt-user ${gwt.version} com.google.gwt gwt-user ${gwt.version} ...

(and note that in the plugin's is no longer needed or even meaningful, and is simply ignored)

Comment #7

Posted on Dec 9, 2010 by Happy Cat

See also http://jira.codehaus.org/browse/MGWT-256.

As long as the plugin behavior noted in tbroyer's solution is intentional, no plugin fix is required.

Comment #8

Posted on Dec 9, 2010 by Swift Ox

(No comment was entered for this change.)

Comment #9

Posted on Dec 9, 2010 by Swift Ox

Re-opening this because we'll need to do the same thing for any other RCs, and for GA

Comment #10

Posted on Dec 14, 2010 by Swift Ox

Dave, do we really need the roo, spring and slf4j version properties in the pom.xml file?

Comment #11

Posted on Dec 14, 2010 by Happy Cat

@rjrjr no, we don't need any Roo, Spring, slf4j stuff in the POM since we're no longer building the Expenses sample with Roo

Comment #12

Posted on Dec 16, 2010 by Swift Ox

Left the roo / spring stuff in place for now

r9423

Comment #13

Posted on Jan 13, 2011 by Swift Ox

(No comment was entered for this change.)

Status: Fixed

Labels:
Milestone-2_1_1 Priority-Critical