| Issue 3644: | Various native errors in Node.is() and Element.is() | |
| 8 people starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
Found in GWT Release (e.g. 1.5.3, 1.6 RC): 1.6.2 and later Encountered on OS / Browser (e.g. WinXP, IE6-7, FF3): IE6+ Detailed description (please be as specific as possible): A number of people have reported seeing native Javascript exceptions in Node.is() on IE as of GWT 1.6.2. It appears that PopupPanel's getting a null target from a previewed event on IE, which it dutifully passes to Element.is() to determine whether it's an element. Shortest code snippet which demonstrates issue (please indicate where actual result differs from expected result): Workaround if you have one: Don't pass null into these two methods. But it's trickier to keep PopupPanel from doing that. Links to relevant GWT Developer Forum posts: - http://groups.google.com/group/Google-Web-Toolkit-Contributors/browse_thread/thread/9350942815b2b17f - http://groups.google.com/group/Google-Web-Toolkit-Contributors/browse_thread/thread/d1f5637159eec9ee |
||||||||||||
,
May 11, 2009
Element.is() and Node.is() make no explicit guarantees about what happens if you give them a null argument. It seems likely that the easiest solution to this problem would simply be to be a bit more defensive, and explicitly allow null parameters (which of course would cause them to return false). The cost shouldn't be terribly high, as you normally only ever call these methods when you're unsure of a JSO's type, which isn't all that often. |
|||||||||||||
,
May 11, 2009
Code review: http://gwt-code-reviews.appspot.com/34801 |
|||||||||||||
,
May 11, 2009
(No comment was entered for this change.)
Status: ReviewPending
|
|||||||||||||
,
May 11, 2009
This issue was closed by r5332.
Status: Fixed
|
|||||||||||||
,
Jun 03, 2009
Any idea when this code fix will be out...? With the code review link it looks that modified code I have it in the jar ... but still its throwing various native events null |
|||||||||||||
,
Jun 03, 2009
Issue 3716 has been merged into this issue. |
|||||||||||||
,
Jun 03, 2009
Issue 3663 has been merged into this issue. |
|||||||||||||
,
Jun 03, 2009
@jgw: the issue seems to be marked for Milestone-1_6_1, but I'm guessing that's outdated since the fix seems to have just landed a few weeks ago. Marking as Milestone-NextRelease for now, feel free to remark if appropriate. @jerome976: This fix is not included in GWT 1.6.4, so feel free to patch this in to see if it fixes the issue you've observed and let us know how it goes.
Cc: sumitcha...@google.com
Labels: -Milestone-1_6_1 Milestone-NextRelease Type-Defect |
|||||||||||||
,
Jun 04, 2009
Actually, r5332 landed in releases/1.6 on May 11 (it was merged back up to trunk later), so it will be in the 1.6 update.
Labels: -Milestone-NextRelease Milestone-1_6_1
|
|||||||||||||
,
Jun 04, 2009
The problem is: this issue is marked Fixed rather than FixedNotReleased, which also happens to make it "hidden" in the default search for issues (which only searches "Open Issues"). |
|||||||||||||
,
Jun 04, 2009
(No comment was entered for this change.)
Status: FixedNotReleased
|
|||||||||||||
,
Jun 24, 2009
sumitcha, I patched up the latest fix to see that solves the reported problem it didn't. It looks like in Hosted mode I haven't seen any issue lately after the fix but in web mode the first time you try to show the DialogBox in my case it throws the Uncaught Javascript exception and hangs the system. When you refresh the browser, it doesn't throw me that exception at all and allows me to perform teh normal operation. In my opinion fix is not stable. |
|||||||||||||
,
Jul 09, 2009
@jerome: r5332 fixed the issues I was aware of, I as far as I can tell. If you're still having problems, please open a separate issue with the specific details of your problem, and code that reproduces it, if at all possible. |
|||||||||||||
,
Jul 13, 2009
We are experiencing the same issues. Any idea when the 1.6 update will be available ? I can do some tests in development to see if the changes work, but I have to use an official downloaded version of GWT in production - so a new official GWT release would be great! |
|||||||||||||
,
Jul 13, 2009
The patch seems to handle the problems we've seen in our application. |
|||||||||||||
,
Jul 13, 2009
I'm hoping that this fix is in the 1.7 release. |
|||||||||||||
,
Jul 22, 2009
This issue has been fixed in GWT 1.7.0 (see release notes): http://code.google.com/webtoolkit/releases/release-notes-1.7.0.html |
|||||||||||||
,
Jul 22, 2009
I upgraded the Google Eclipse plugin to 1.7 but that didn't immediately fix the problem and left me scratching my head. Turns out there was an additional manual step (in project/window properties) needed to tell Eclipse to use 1.7 after the upgrade. Of course, it makes perfect sense that you have to *use* the new code to get the fix but I thought I'd post just to make sure no-one else hits the same snag. |
|||||||||||||
,
Jul 29, 2009
(No comment was entered for this change.)
Labels: Milestone-1_7
|
|||||||||||||
,
Aug 03, 2009
(No comment was entered for this change.)
Status: Fixed
|
|||||||||||||
,
Aug 10, 2009
jgw, Issue what I reported got solved as soon as I upgraded to GWT-1.7 it has passed all testing which we did with GWT-1.6 where we faced this issue. Thanks you jgw sorry I don't know your name :( as well as sumitcha for following up. Jerome. |
|||||||||||||
|
|
|||||||||||||