My favorites | Sign in
Google
                
New issue | Search
for
| Advanced search | Search tips
Issue 1161: RFE Don't warn about native methods when serializing JRE emulation classes
  Back to list
Status:  Fixed
Owner:  mmendez@google.com
Closed:  Aug 2007
Type-Defect
Priority-Critical
Category-RPC
Milestone-1_4_RC2


Sign in to add a comment
 
Reported by ispeters, Jun 04, 2007
Found in GWT Release:

1.4.10

Detailed description:

The new, stricter RPC code emits warnings that calling native methods on
the server will result in UnsatisfiedLinkErrors.  The warning is sensible,
but I think it should be suppressed for JRE emulation classes because the
emulation code will never run on the server, and there is therefore never a
risk of causing an UnsatisfiedLinkError.

Workaround if you have one:

Ignore the verbose warnings.
Comment 1 by gwt.team.morrildl, Jun 06, 2007
This is already fixed, actually.  Assigning to Miguel to do the bookkeeping.
Owner: gwt.team.mmendez
Labels: -Priority-Medium Priority-Critical Category-RPC Milestone-1_4_RC2
Comment 2 by ispeters, Jun 06, 2007
Just curious, but is it fixed in a general way?  I've written some JRE emulation
classes myself and I get the same warnings.  I hope the solution will suppress the
warnings on my work as well as the classes that come packaged with GWT.
Comment 3 by gwt.team.mmendez, Jun 22, 2007
In 1.4 RC1, we only checked for native methods if the type was automatically
serializable.  This explains why our JRE libraries did not generate this warning.

The attached patch will check for native methods on both automatically and manually
serializable classes.  However, it will not perform the check if the class is defined
in any of the java.* packages.

issue1161-r1198.patch
2.2 KB Download
Status: ReviewPending
Labels: ReviewBy-scottb
Comment 4 by gwt.team.mmendez, Jun 28, 2007
I'm going to batch this one up with  issue 1163 .
Status: Started
Labels: -ReviewBy-scottb
Comment 5 by gwt.team.mmendez, Jun 28, 2007
(No comment was entered for this change.)
Status: ReviewPending
Comment 6 by gwt.team.mmendez, Jun 28, 2007
(No comment was entered for this change.)
Status: Started
Comment 7 by gwt.team.mmendez, Jun 28, 2007
Fix was included in patch for  issue 1163 .
Status: ReviewPending
Comment 8 by gwt.team.mmendez, Jul 10, 2007
Committed as r1228.
Status: FixedNotReleased
Comment 9 by gwt.team.scottb, Aug 20, 2007
1.4 RC2 now released.
Status: Fixed
Comment 10 by sumitcha...@google.com, Apr 28, 2008
 
Owner: mmendez
Sign in to add a comment