Export to GitHub

google-refine - issue #608

Patch: Update .classpath to export guava lib. Remove deprecated google-collect jar


Posted on Sep 11, 2012 by Swift Ox

Patch .classpath with attached patch file. Remove extensions/gdata/module/MOD-INF/lib/google-collect-1.0-rc1.jar

Motivation: The guava lib completely replaces the deprecated google-collect lib.

Attachments

Comment #1

Posted on Sep 11, 2012 by Swift Bird

(No comment was entered for this change.)

Comment #2

Posted on Sep 11, 2012 by Swift Bird

Thanks for the patch! Applied in r2545.

Comment #3

Posted on Sep 12, 2012 by Swift Ox

Can you also remove the file extensions/gdata/module/MOD-INF/lib/google-collect-1.0-rc1.jar since it is no longer needed.

Comment #4

Posted on Sep 13, 2012 by Swift Bird

Good point. It's gone now.

Comment #5

Posted on Sep 18, 2012 by Swift Bird

(No comment was entered for this change.)

Comment #6

Posted on Sep 23, 2012 by Happy Bird

Hi, I'm getting this error while trying to import from googledocs:

java.lang.NoSuchMethodError: com.google.common.collect.ImmutableSet.of([Ljava/lang/Object;)Lcom/google/common/collect/ImmutableSet; at com.google.gdata.wireformats.AltFormat$Builder.setAcceptableTypes(AltFormat.java:399) at com.google.gdata.wireformats.AltFormat$Builder.setAcceptableXmlTypes(AltFormat.java:387) at com.google.gdata.wireformats.AltFormat.(AltFormat.java:49) at com.google.gdata.client.Service.(Service.java:558) at com.google.refine.extension.gdata.GDataExtension.getDocsService(GDataExtension.java:97) at com.google.refine.extension.gdata.GDataImportingController.doListDocuments(GDataImportingController.java:127)

I'm launching from within Eclipse and Windows, I'm synced with the current version (2569), from what I see it seems gdata-core-1.0 is still calling the old library. Is it possible that the jar in the SVN is not up to date or am I missing something in the setup?

Comment #7

Posted on Sep 23, 2012 by Swift Ox

This can be fixed by updating the following gdata client libs from the latest version at http://gdata-java-client.googlecode.com/files/gdata-src.java-1.47.1.zip

M extensions/gdata/module/MOD-INF/lib/gdata-core-1.0.jar M extensions/gdata/module/MOD-INF/lib/gdata-spreadsheet-3.0.jar M extensions/gdata/module/MOD-INF/lib/gdata-docs-3.0.jar M extensions/gdata/module/MOD-INF/lib/gdata-base-1.0.jar M extensions/gdata/module/MOD-INF/lib/gdata-spreadsheet-meta-3.0.jar M extensions/gdata/module/MOD-INF/lib/gdata-docs-meta-3.0.jar M extensions/gdata/module/MOD-INF/lib/gdata-client-1.0.jar M extensions/gdata/module/MOD-INF/lib/gdata-media-1.0.jar M extensions/gdata/module/MOD-INF/lib/gdata-client-meta-1.0.jar

Status: Fixed

Labels:
Type-Defect Priority-Medium Milestone-2.6