Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failures in Access token requests for OAuth 2.0 assertion profile shouldn't be caught #42

Closed
wonderfly opened this issue Jan 9, 2015 · 1 comment
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@wonderfly
Copy link
Contributor

From rmis...@google.com on June 06, 2012 09:57:46

Reported by ryanboyd:

Using a bad scope in assertion profile code will result in an invalid_scope error (and 4xx response) from the OAuth token endpoint. The Java client library currently seems to ignore this error, and instead proceeds to make the call to the actual API service with an empty OAuth access token.

If there is an error in obtaining an access token using the assertion profile, I'd expect this to be thrown to the top level to enable easier debugging of issues using service accounts.

Original issue: http://code.google.com/p/google-oauth-java-client/issues/detail?id=42

@wonderfly wonderfly added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. imported labels Jan 9, 2015
@wonderfly wonderfly self-assigned this Jan 9, 2015
@wonderfly
Copy link
Contributor Author

From rmis...@google.com on June 06, 2012 10:01:04

http://codereview.appspot.com/6203063/

Status: Fixed

@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants