Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New structure for jars in zip package #38

Closed
wonderfly opened this issue Jan 9, 2015 · 1 comment
Closed

New structure for jars in zip package #38

wonderfly opened this issue Jan 9, 2015 · 1 comment
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@wonderfly
Copy link
Contributor

From rmis...@google.com on May 14, 2012 08:00:18

Similar to https://code.google.com/p/google-http-java-client/issues/detail?id=109 .

Summary by yanivi:

Currently the google-http-client jars are at the root of the zip file, and the dependency jars are in the dependencies folder.

Instead, I propose a new structure which puts all of the binary jars in a "libs" folder and all of the source jars are in the "libs-sources" folder. No distinction between http base lib or the dependencies. This follows exactly the structure of the jars in tasks-android-sample.

One motivation is that for Android applications, the package manager requires the directory with all binary jars to be called "libs". Similarly, for HTTP servlets to jars must go in the war/WEB-INF/lib folder. Normally source jars aren't placed in this directory, so that's why I recommend also doing the same for libs-sources.

Additionally, we should provide the classpath entries to use for the .classpath file for Eclipse for the various platforms. It's just too much of a pain to craft them manually, and often people forget the sourcepath which makes it more difficult for debugging.

We should make the same changes in the projects that we own that depend on this project (api, oauth, etc).

Original issue: http://code.google.com/p/google-oauth-java-client/issues/detail?id=38

@wonderfly wonderfly added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. imported labels Jan 9, 2015
@wonderfly wonderfly self-assigned this Jan 9, 2015
@wonderfly
Copy link
Contributor Author

From rmis...@google.com on May 14, 2012 10:26:32

http://codereview.appspot.com/6211049/

Status: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant