Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth 2.0 Username and Password Grant Type #24

Closed
wonderfly opened this issue Jan 9, 2015 · 10 comments
Closed

OAuth 2.0 Username and Password Grant Type #24

wonderfly opened this issue Jan 9, 2015 · 10 comments
Assignees
@wonderfly
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@wonderfly
Copy link
Contributor

From alexande...@gmail.com on February 10, 2012 10:47:43

Version of google-oauth-java-client (e.g. 1.5.0-beta)? 1.6.0-beta Java environment (e.g. Java 6, Android 2.3, App Engine)? Android Describe the problem. When using ResourceOwnerCredentialsAccessTokenRequest, the password is not sent in the request. How would you expect it to be fixed? I believe this derives from a missing "@key" in line 172 of https://code.google.com/p/google-oauth-java-client/source/browse/google-oauth-client/src/main/java/com/google/api/client/auth/oauth2/draft10/AccessTokenRequest.java

Original issue: http://code.google.com/p/google-oauth-java-client/issues/detail?id=24
@wonderfly wonderfly added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. imported priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jan 9, 2015
@wonderfly wonderfly self-assigned this Jan 9, 2015
@wonderfly
Copy link
Contributor Author

From yan...@google.com on February 28, 2012 17:11:35

I think you are probably correct that it is due to the missing @key annotation on the password field. However, we are deprecating this class anyway for 1.7 (which should release soon). Currently I don't have a replacement for ResourceOwnerPasswordCredentialsGrant in the new OAuth 2.0 package (oauth2). Rather than fixing ResourceOwnerPasswordCredentialsGrant, I'd rather just implement one based on the new OAuth 2.0 package.

Summary: OAuth 2.0 Username and Password Flow
Status: Accepted
Owner: yan...@google.com
Labels: -Type-Defect Type-Enhancement Milestone-Version1.8.0 Component-OAuth2

@wonderfly
Copy link
Contributor Author

From yan...@google.com on March 27, 2012 07:12:28

Owner: rmis...@google.com
Cc: yan...@google.com
Labels: -Milestone-Version1.8.0 Milestone-Version1.9.0

@wonderfly
Copy link
Contributor Author

From rmis...@google.com on May 14, 2012 07:16:22

Labels: -Milestone-Version1.9.0 Milestone-Version1.10.0

@wonderfly
Copy link
Contributor Author

From yan...@google.com on May 30, 2012 09:20:17

Labels: -Milestone-Version1.10.0 Milestone-Version1.11.0

@wonderfly
Copy link
Contributor Author

From yan...@google.com on July 26, 2012 07:37:14

Labels: -Milestone-Version1.11.0 Milestone-Version1.12.0

@wonderfly
Copy link
Contributor Author

From yan...@google.com on September 26, 2012 05:19:52

Owner: yan...@google.com
Cc: -yan...@google.com rmis...@google.com
Labels: -Milestone-Version1.12.0

@wonderfly
Copy link
Contributor Author

From yan...@google.com on January 10, 2013 13:46:14

Cc: ngmic...@google.com
Labels: Milestone-Version1.14.0

@wonderfly
Copy link
Contributor Author

From yan...@google.com on January 10, 2013 14:35:22

https://codereview.appspot.com/7060072

Status: Started

@wonderfly
Copy link
Contributor Author

From yan...@google.com on January 10, 2013 14:40:24

Summary: OAuth 2.0 Username and Password Grant Type (was: OAuth 2.0 Username and Password Flow)

@wonderfly
Copy link
Contributor Author

From yan...@google.com on January 17, 2013 19:13:07

Status: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wonderfly wonderfly

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wonderfly