Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP response header parsing should be case insensitive #91

Closed
wonderfly opened this issue Jan 9, 2015 · 2 comments
Closed

HTTP response header parsing should be case insensitive #91

wonderfly opened this issue Jan 9, 2015 · 2 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@wonderfly
Copy link
Contributor

From yan...@google.com on April 20, 2012 11:35:52

Version of google-http-java-client (e.g. 1.5.0-beta)? 1.8.0-beta Java environment (e.g. Java 6, Android 2.3, App Engine)? All? Describe the problem. For example, note how the ETag field is declared:

/** {@code "ETag"} header. */
@key("ETag")
private String etag;

We will correctly parse an HTTP response header like this:

ETag: "abc"

We will also correctly parse an HTTP response header like this:

etag: "abc"

But we won't parse any other capitalization, e.g.:

ETAG: "abc" How would you expect it to be fixed? Any capitalization should parse correctly.

Original issue: http://code.google.com/p/google-http-java-client/issues/detail?id=91

@wonderfly wonderfly added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. imported priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 9, 2015
@wonderfly wonderfly self-assigned this Jan 9, 2015
@wonderfly
Copy link
Contributor Author

From yan...@google.com on April 20, 2012 11:37:54

http://codereview.appspot.com/6089044/

Status: Started

@wonderfly
Copy link
Contributor Author

From yan...@google.com on April 23, 2012 15:03:23

Status: Fixed

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants