Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UriTemplate.expand should support Iterable<?> for list parameters #118

Closed
wonderfly opened this issue Jan 9, 2015 · 3 comments
Closed
Assignees
Labels
priority: p0 Highest priority. Critical issue. P0 implies highest priority. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@wonderfly
Copy link
Contributor

From rmis...@google.com on May 21, 2012 07:17:29

Reported by willem.salembier, May 19 (42 hours ago)
Version of google-api-java-client: 1.9.0-beta
Java environment: Java 6

Freebase Text API is bugged. The Get object requires to be initialized with a List, but the buildHttpRequestUrl() method uses UriTemplate.expand which expects the id parameter to be passed as an Iterator and not an Iterable.

Get get = freebase.text().get(Arrays.asList("en", "avenue_q")); How would you expect it to be fixed? com.google.api.services.freebase.Freebase.Text.Get.getId() should return an Iterator or UriTemplate.expand should support Iterable for list parameters.

Original issue: http://code.google.com/p/google-http-java-client/issues/detail?id=118

@wonderfly wonderfly added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. imported priority: p0 Highest priority. Critical issue. P0 implies highest priority. labels Jan 9, 2015
@wonderfly wonderfly self-assigned this Jan 9, 2015
@wonderfly
Copy link
Contributor Author

From rmis...@google.com on May 21, 2012 07:24:58

http://codereview.appspot.com/6208085/

Status: Started

@wonderfly
Copy link
Contributor Author

From rmis...@google.com on May 21, 2012 09:29:29

Labels: Component-HTTP

@wonderfly
Copy link
Contributor Author

From rmis...@google.com on May 22, 2012 13:30:09

Status: Fixed

@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Apr 6, 2020
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this issue Aug 11, 2022
…leapis#118)

* Extracting the project_id field from service account JSON files when available

* Test case for service account file without project_id
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p0 Highest priority. Critical issue. P0 implies highest priority. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants