Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-http-client-gson & google-http-client-jackson #103

Closed
wonderfly opened this issue Jan 9, 2015 · 3 comments
Closed

google-http-client-gson & google-http-client-jackson #103

wonderfly opened this issue Jan 9, 2015 · 3 comments
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@wonderfly
Copy link
Contributor

From yan...@google.com on May 05, 2012 07:56:34

External references, such as a standards document, or specification? http://google-http-java-client.googlecode.com/hg/google-http-client-assembly/readme.html http://javadoc.google-http-java-client.googlecode.com/hg/1.8.3-beta/com/google/api/client/json/gson/package-summary.html http://javadoc.google-http-java-client.googlecode.com/hg/1.8.3-beta/com/google/api/client/json/jackson/package-summary.html Java environments (e.g. Java 6, Android 2.3, App Engine, or All)? All Please describe the feature requested. The readme.html says that gson and jackson jars are dependencies. But that's really only true if you are using GSON or Jackson as the low-level JSON library. In particular, for applications based on Android Honeycomb (SDK 3.0) or higher that are using Android's native JSON library, or for applications that aren't using JSON (admitted rare these days), this dependency should be unnecessary. The problem is for Android it is highly recommended to use ProGuard, and it expects all dependent jars to be on the classpath. This is just an inconvenience. The good news is that it shouldn't actually cause the compiled application to be any larger, because in theory ProGuard should just strip out the jar.

Anyway, a simple fix might be to just split off the gson and jackson support into separate google-http-client-gson & google-http-client-jackson jars. Down side: two mores projects to manage (but that should be easy enough to manage). We should then list it in the readme.html with a qualifier for when it may be needed, e.g.:

  • google-http-client-gson (only if using GSON library)
    • gson
  • google-http-client-jackson (only if using Jackson library)
    • jackson

Original issue: http://code.google.com/p/google-http-java-client/issues/detail?id=103

@wonderfly wonderfly added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. imported labels Jan 9, 2015
@wonderfly wonderfly self-assigned this Jan 9, 2015
@wonderfly
Copy link
Contributor Author

From rmis...@google.com on May 14, 2012 07:14:07

Labels: -Milestone-Version1.9.0 Milestone-Version1.10.0

@wonderfly
Copy link
Contributor Author

From yan...@google.com on May 30, 2012 15:05:06

Labels: -Milestone-Version1.10.0 Milestone-Version1.11.0

@wonderfly
Copy link
Contributor Author

clundin25 pushed a commit to clundin25/google-http-java-client that referenced this issue Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant