Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-http-client-protobuf #102

Closed
wonderfly opened this issue Jan 9, 2015 · 5 comments
Closed

google-http-client-protobuf #102

wonderfly opened this issue Jan 9, 2015 · 5 comments
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@wonderfly
Copy link
Contributor

From yan...@google.com on May 05, 2012 07:36:49

External references, such as a standards document, or specification? http://google-http-java-client.googlecode.com/hg/google-http-client-assembly/readme.html http://javadoc.google-http-java-client.googlecode.com/hg/1.8.3-beta/com/google/api/client/http/protobuf/package-summary.html Java environments (e.g. Java 6, Android 2.3, App Engine, or All)? All Please describe the feature requested. The readme.html says that protobuf-java.jar is a dependency for Android. But most of the APIs don't use protobuf, e.g. most modern Google APIs are based on JSON. The problem is for Android it is highly recommended to use ProGuard, and it expects all dependent jars to be on the classpath. This is just an inconvenience. The good news is that it shouldn't actually cause the compiled application to be any larger, because in theory ProGuard should just strip out the jar.

Anyway, a simple fix might be to just split off the protobuf support into a separate google-http-client-protobuf jar. This would make it easier to manage the protobuf dependency. Down side: yet another project to manage (but that should be easy enough to manage).

Original issue: http://code.google.com/p/google-http-java-client/issues/detail?id=102

@wonderfly wonderfly added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. imported labels Jan 9, 2015
@wonderfly wonderfly self-assigned this Jan 9, 2015
@wonderfly
Copy link
Contributor Author

From yan...@google.com on May 05, 2012 07:41:04

If we do this, we should list it in the readme.html as an "optional" dependency needed if you are working with protobuf.

@wonderfly
Copy link
Contributor Author

From rmis...@google.com on May 14, 2012 07:14:07

Labels: -Milestone-Version1.9.0 Milestone-Version1.10.0

@wonderfly
Copy link
Contributor Author

From yan...@google.com on May 24, 2012 13:30:18

Owner: mlin...@google.com
Cc: rmis...@google.com

@wonderfly
Copy link
Contributor Author

From rmis...@google.com on June 04, 2012 05:20:26

I recommend we implement this in 1.11, there are going to be a lot of other changes required after the pom files are updated and new artifact is created.
Here are the ones that come to mind: readme.html of all three projects, Setup.wiki of all three projects, release.html of all three projects, jdiff.xml of all three projects, README.txt in the generator, features JSON file etc.

Cc: yan...@google.com
Labels: -Milestone-Version1.10.0 Milestone-Version1.11.0

@wonderfly
Copy link
Contributor Author

From rmis...@google.com on July 17, 2012 07:33:12

Looks like this was fixed in http://codereview.appspot.com/6311043/

Status: Fixed

clundin25 pushed a commit to clundin25/google-http-java-client that referenced this issue Aug 11, 2022
Add GoogleCredentials.createDelegated() method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant