My favorites | Sign in
Project Logo
                
New issue | Search
for
| Advanced search | Search tips
Issue 95: Fix Deskbar-Applet bug #508590 and 345658
3 people starred this issue and may be notified of changes. Back to list
Status:  Claimed
Owner:  itssebp
Code
ClaimedBy-element3260


Sign in to add a comment
 
Reported by itssebp, Jan 10, 2008
Task title: Add finished signal to module (#508590) and add support to
search more fields in evolution address book (#345658)

Benefits:
1) Currently, we're not able to tell when a module is finished searching.
Modules should explicitly tell Deskbar when they are done searching.

2) Currently, we only search name, e-mail and nickname fields. Obviously,
searching more fields will improve the value of the evolution module.

Requirements:
* Basic Python programming skills
* Basic C programming skills
* Latest Deskbar-Applet version from the subversion repository

Task description:

1) The module interface should contain a new signal called "finished" that
each module should emit when it's finished searching for results.
Currently, we're not able to tell when a module is finished searching.

Adding this feature requires:
* Adding new signal and method '_emit_finished' to deskbar.interfaces.Module
* Add a self._emit_finished() to each module in deskbar/handlers when it's
finished searching (i.e. either before a return statement or at the end of
the query method.

2) You have to edit deskbar/handlers/evolution/evolution.c and add more
useful fields (see links for available fields).

Please, attach the patch to the bugzilla entry.

Links:
* http://bugzilla.gnome.org/show_bug.cgi?id=508590
* http://bugzilla.gnome.org/show_bug.cgi?id=345658
* http://svn.gnome.org/svn/deskbar-applet/trunk
*
http://www.gnome.org/projects/evolution/developer-doc/libebook/EContact.html#EContactField

Estimated time: Two days

Primary contact: Sebastian Pölsterl (marduk {at} k-d-w {dot} org, sebp in
#deskbar on irc.gimp.net)
 
Comment 1 by andre.klapper, Jan 10, 2008
(No comment was entered for this change.)
Status: Open
Comment 2 by element3260, Jan 10, 2008
I claim this task
Comment 3 by itssebp, Jan 10, 2008
(No comment was entered for this change.)
Status: Claimed
Labels: ClaimedBy-element3260
Comment 4 by element3260, Jan 12, 2008
I'm getting the most odd errors on the second patch. For some reason whenever I
search for any other fields than the original three (name, email, and nickname) never
returns any matches. Iv searched through all the code in evolution.c and cant find
any reason why this would happen. Any ideas?


Comment 5 by element3260, Jan 12, 2008
O and here is the first patch
finishedSignal.patch
8.9 KB   Download
Comment 6 by itssebp, Jan 13, 2008
Can you provide the patch for the second bug, so I can try it myself?
Comment 7 by element3260, Jan 13, 2008
of course, here it is
test.diff
768 bytes   Download
Comment 8 by itssebp, Jan 14, 2008
It might be because we use e_book_query_and, try e_book_query_or (see
http://www.gnome.org/projects/evolution/developer-doc/libebook/libebook-e-book-query.html)
Comment 9 by element3260, Jan 14, 2008
Nope still nothing. After some debugging it seems that whenever _EMAIL _FULL_NAME or
_NICKNAME are not present in search_fields everything runs fine, but as soon as I add
any of those three to it, everything except those originals stops working. I am about
to rip my hair out because this is driving me nuts, and any help would be GREATLY
appreciated. 
Comment 10 by itssebp, Jan 15, 2008
I'm by far no Evolution expert. You should ask in #evolution or on their mailinglist
(http://www.gnome.org/projects/evolution/) they probably can help you.
Comment 11 by andre.klapper, Jan 15, 2008
http://www.go-evolution.org/EDS_Architecture#Addressbook provides some basic
information, however asking srag in #evolution would probably be the best idea :)
Comment 12 by element3260, Jan 16, 2008
thanks andre

Comment 13 by itssebp, Jan 22, 2008
How's progress? Do you have any unresolved problems?
Comment 14 by element3260, Jan 22, 2008
Unfortunately I'm still not able to figure out a solution. Whenever _EMAIL _FULL_NAME
or _NICKNAME are present in the search_fields array nothing but those three will
work. So I've decided to unclaim this task so that someone else can have a shot at it.
Comment 15 by element3260, Jan 22, 2008
I unclaim this task
Comment 16 by andre.klapper, Jan 22, 2008
(hmm, you cannot claim new tasks anymore as far as i know because the deadline is
over, so i would advice you to not unclaim it and wait for some comments by sebp
instead. just my feeling, though, if you definitely want to quit it's your choice. :-)
Comment 17 by itssebp, Jan 23, 2008
Did you ask one of the evolution guys for help?
Comment 18 by andre.klapper, Feb 01, 2008
anybody please note that the deadline for any tasks is february 3rd.
Sign in to add a comment

Hosted by Google Code