My favorites | Sign in
Project Logo
                
New issue | Search
for
| Advanced search | Search tips
Issue 89: Fix task manager in anjuta
2 people starred this issue and may be notified of changes. Back to list
Status:  Completed
Owner:  jhs.schmid
Closed:  Jan 2008
Code
ClaimedBy-bolekk


Sign in to add a comment
 
Reported by jhs.schmid, Jan 05, 2008
Task title: There are several small issues in the anjuta task manager that
could be improved.

Benefits: The task manager is one of the areas in anjuta that have not seen
much love recently. You have the chance to revive this and make it more
useful to the user.

Requirements: Some knowledge about C programming and GTK+ skills. GTK+
skills are not so mandatory if you are willing to read some docs and learn.


Task description Consists of:
Look at this bug list:
http://bugzilla.gnome.org/buglist.cgi?product=anjuta&bug_status=NEW&bug_status=REOPENED&bug_status=ASSIGNED&bug_status=UNCONFIRMED&component=plugins%3A%20gtodo

The aim is to at least fix #505205 and #460390. That should hopefully not
be that difficult. In addition either fix #505205 or, in case that is not
going to be easy, try to reproduce it and add instructions together with a
better stack trace to the bug.

For testing you can use the tasks that are included in the anjuta project.
This is a quite big list with many categories and should fit very well for
testing.

Feel free to bother me with any questions you have!

Extra: If you feel brave you might want to take a look at printing support
(#505205) or add an option to export the task list as a normal text TODO file.

Expected Outcome: Patches/Comments to bugs in bugzilla against svn trunk.

Links:
Anjuta Project website: http://www.anjuta.org
Anjuta in GNOME SVN: http://svn.gnome.org/viewvc/anjuta/trunk/
Anjuta Developer Mailing list: anjuta-devel@lists.gnome.org
Anjuta's bugzilla: http://bugzilla.gnome.org/browse.cgi?product=anjuta

Estimated time: 7 days

Primary contact:
Johannes Schmid <jhs@gnome.org>
IRC: jhs usually hanging around in #gnome-hackers, #anjuta
Comment 1 by jhs.schmid, Jan 05, 2008
(No comment was entered for this change.)
Labels: -Type-Defect Code
Comment 2 by andre.klapper, Jan 05, 2008
(No comment was entered for this change.)
Status: Open
Labels: -Priority-Medium
Comment 3 by bolekk, Jan 07, 2008
Bug IDs in task statement are confusing... 
The minimal requirement is to fix #505205 and #460390 ?
In addition fix ... (which one ?)
Comment 4 by jhs.schmid, Jan 07, 2008
hi bolekk!

Argh, sorry copied the wrong bug numbers. The original bugs to fix are #507304,
#460390 and #505205.

The extra bug is #304629.

Regards,
Johannes
Comment 5 by bolekk, Jan 08, 2008
I claim this task.
Comment 6 by bolekk, Jan 08, 2008
I think I've already found a solution to #505205 (patch + description at
http://bugzilla.gnome.org/show_bug.cgi?id=505205).

But I think there is another problem with this category stuff, when a user decides to
create a few categories (= presses "new" button two(or more) times in a row) and THEN
change the names of all three ones, he won't receive what he wanted to (same reason
as in #505205).

My idea is to check if we already have categories named like "<Enter name>" and if
so, create new ones with different names. For example if we press "new" button three
times in a row, we will receive "<Enter name 1>", "<Enter name 2>" "<Enter name 3>"
categories. What do you think of it ?

I will need an int-to-string conversion function, is there any in gtk+ or can I
implement a simple one?
Comment 7 by andre.klapper, Jan 08, 2008
bolekk, welcome aboard!
Status: Claimed
Labels: ClaimedBy-bolekk
Comment 8 by jhs.schmid, Jan 08, 2008
Hi bolekk!

>But I think there is another problem with this category stuff, when a user decides >to
>create a few categories (= presses "new" button two(or more) times in a row) and >THEN
>change the names of all three ones, he won't receive what he wanted to (same reason
>as in #505205).

>My idea is to check if we already have categories named like "<Enter name>" and if
>so, create new ones with different names. For example if we press "new" button three
>times in a row, we will receive "<Enter name 1>", "<Enter name 2>" "<Enter name 3>"
>categories. What do you think of it ?

First, I think the focus should go directly on the new category after "New" was
pressed and editing should be started with gtk_cell_renderer_start_editing() (or
similar). That would prevent most people from clicking again on "New".

But your idea still seems good if the user really adds multiple categories. The
easiest way to add the number would be following code:

gchar* label = g_strdup_printf (_("<Enter name (%d)>"), number);

I suggest parenthesis around the number as I feel that looks better and clearer to
the translators. Maybe we should even replace <Enter name> with <New category>.

Thanks!
Comment 9 by jhs.schmid, Jan 08, 2008
Sorry, gtk_cell_renderer_start_editing() is the wrong API method. Hopefully you can
find out the right one as I didn't find it yet. But I am sure that the functionality
exists somewhere.
Comment 10 by bolekk, Jan 08, 2008
Patch with fixed names of new categories attached on bugzilla (#505205).

I didn't manage to reproduce bug 507304 on my machine but I emailed its reporter so
maybe he will give me some more info about it.
Comment 11 by bolekk, Jan 09, 2008
Sorry I didn't update my copy from svn, I wasn't prepared for my first patch being
committed so quickly :p 

I think I fixed #460390 - patch+comment on bugzilla.

I've read in HACKING that
4) *Always* include a ChangeLog entry as part of the diff to ensure that
your entry is also committed directly with your name mentioned.

Should I do that? what should I write in ChangeLog?

I managed to crush anjuta while deleting tasks, working on it...
Comment 12 by andre.klapper, Jan 09, 2008
just take a look at other ChangeLog entries and you will get an idea; basically a
changelog entry looks like


2008-01-09  Andre Klapper  <example@example.com>

        * filename.c: Description what I have changed.
Comment 13 by jhs.schmid, Jan 09, 2008
yeah! And to make your life easier, you can activate the tools plugin in anjuta and
select Tools->Prepare ChangeLog which will give you a skeleton. Usually you just write 

filename.c:
filename.h:
Fix #000000 - This is the bug title
Comment 14 by bolekk, Jan 11, 2008
I think I've finally found a reason for this crash (#507304)
Description + patch at http://bugzilla.gnome.org/show_bug.cgi?id=507304

Please tell me if my proposed solution doesn't cause any other problems. I don't have
much experience with GTK+ so I may have omitted some problematic issues.
Comment 15 by bolekk, Jan 13, 2008
Thanks for accepting my patch :)

Please tell me if it is everything for this task.(I don't think I'm able to fix the
printing bug, actually I have never printed anything from linux ... )
Comment 16 by jhs.schmid, Jan 13, 2008
Thanks a lot for your contribution. The task is completely finished (Extra is meant
extra, it's not part of the task).

We would love to see future contribution to the project and hope you enjoyed working
on anjuta.
Status: Completed
Sign in to add a comment

Hosted by Google Code