New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overridden methods are injected twice #67
Comments
From kevinb9n on March 15, 2007 07:47:27 bogus. Labels: 1.1 |
From robbie.vanbrabant on August 10, 2007 01:39:38 Take a look if this is what you meant. Patch attached. Binary attachments: guice_overrides.zip |
From crazyboblee on September 09, 2007 14:07:36 Two things. 1) You can't override fields (you can only shadow them). Given: class Super { class Sub extends Super { Super.foo and Sub.foo are separate fields and we should inject both.
There's also the question of what does overriding mean semantically? If I have Finally, detecting true overriding is a little trickier. You have to take the |
From robbie.vanbrabant on September 09, 2007 16:12:10 You're right Bob.
|
From robbie.vanbrabant on April 13, 2008 09:42:41 Found the time to look at this again. Attached. Attachment: gist |
From limpbizkit on May 29, 2008 23:53:49 (No comment was entered for this change.) Labels: -1.1 Milestone-Release2.0 |
From limpbizkit on October 31, 2008 23:42:49 (No comment was entered for this change.) Labels: -Milestone-Release2.0 Milestone-Release2.1 |
From crazyboblee on September 29, 2009 11:22:00 This is fixed. Modified Guice to have the same behavior as JSR-330. This shouldn't Status: Fixed |
From crazyboblee on March 14, 2007 18:47:12
If you override a method with
@
Inject with another method with@
Inject,Guice will call it twice. This usually isn't a big deal, but we really
should filter out overridden methods.
Original issue: http://code.google.com/p/google-guice/issues/detail?id=67
The text was updated successfully, but these errors were encountered: