New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support chaining injectors / parent injectors #45
Comments
From kevinb9n on February 28, 2007 11:14:44 What about including any already-initialized singletons from the original container? |
From crazyboblee on February 28, 2007 12:04:24 We would pretty much have to do that. I also think sharing the instance is the least |
From crazyboblee on February 28, 2007 14:46:31 Container has been renamed Injector. I think being able to pass an Injector to a Binder is pretty safe and has a lot of Labels: 1.0RC3 |
From crazyboblee on February 28, 2007 14:48:44 Container has been renamed Injector. I think being able to pass an Injector to a Binder is pretty safe and has a lot of |
From crazyboblee on March 02, 2007 13:20:45 Deferring until I figure out how we want to do this. Should the containers share implicit bindings, too? i.e. consider an implicit We need to copy scope bindings, too. How will method interception work? I suppose we need to expose and copy the method I think keeping implicit bindings separate and only copying explicit bindings is the Labels: -1.0RC3 |
From crazyboblee on March 13, 2007 15:31:34 (No comment was entered for this change.) Summary: Support chaining injectors. |
From kevinb9n on June 03, 2007 11:01:39 People who want this feature, please-pretty-please add your use cases here. thanks. |
From crazyboblee on June 03, 2007 11:07:32 I don't think we should implement this. You can always enforce layering when compiling. |
From kevinb9n on June 03, 2007 11:38:39 I've gotten the general sense that there are other reasons besides layering why |
From oliver.buchtala on February 16, 2008 16:43:34 Hi, I don't know the current state of this issue. But I have 'working' prototype. I very much like the idea of injector chains. I tried to find out if Scopes are my solution - but, as I think, I have to bind the I worked out a simple Prototype of an hierarchical binder impl that does what I Current problem: eagerSingletons - may lead (very likely) to calls on the bridging What do you think? Greetz, Binary attachments: GuiceWithHierarchicalModules.zip |
From limpbizkit on May 30, 2008 00:26:36 Dan Halem has implemented a prototype of this in Guice svn. But I'd still like to make a thorough examination of |
From limpbizkit on June 06, 2008 09:24:46 (No comment was entered for this change.) Summary: Support chaining injectors / parent injectors |
From limpbizkit on June 17, 2008 11:32:40 There's a bug in the current implementation where deep hierarchies are not honoured: http://groups.google.com/group/google-guice/browse_frm/thread/4689199d93d76ecb |
From medotin on July 11, 2008 10:10:24
|
From medotin on July 11, 2008 10:12:42 Oops, wrong line number: http://fisheye2.atlassian.com/browse/google-guice/trunk/src/com/google/inject/InjectorImpl.java?r=555#l173 |
From sven.linstaedt on September 10, 2008 01:55:13 There is another bug: Constant bindings are not inherited from the parent injector. So while retrieving an object which depends on constant bindings from the parent |
From limpbizkit on October 14, 2008 16:43:45 I've rewritten parent injectors from scratch. From the Injector.java API: /** Status: Started |
From sven.linstaedt on October 15, 2008 06:20:35 Have a look at related discussion: http://groups.google.com/group/google-guice-dev/browse_thread/thread/c097874268bf9209?hl=en |
From limpbizkit on November 12, 2008 17:18:57 Implemented and now threadsafe. Hooray! Status: Fixed |
From crazyboblee on February 28, 2007 14:09:33
For example, I could pass a Container to a Binder and the resulting
Container would include all the bindings from the original Container. This
can be used the implement layering (i.e. view layer container includes the
application layer container) as well as initialization stages.
Original issue: http://code.google.com/p/google-guice/issues/detail?id=45
The text was updated successfully, but these errors were encountered: