Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up warnings #40

Closed
gissuebot opened this issue Jul 7, 2014 · 4 comments
Closed

clean up warnings #40

gissuebot opened this issue Jul 7, 2014 · 4 comments

Comments

@gissuebot
Copy link

From kevinb9n on February 27, 2007 03:45:37

We ought to compile warning-free and only @SuppressWarnings where necessary
and where we can explain how we know the suppression is safe.  I think the
refactoring and commenting necessary to handle this issue will make the
code easiser to understand.

Original issue: http://code.google.com/p/google-guice/issues/detail?id=40

@gissuebot
Copy link
Author

From dsallings on June 06, 2007 01:11:14

The attached patch against 335 cleans all but two warnings in my eclipse
configuration.  The two warnings are actually SuppressWarnings annotations for tokens
eclipse doesn't support.

Note that I did add some SuppressWarnings, but tried to keep them localized to
variable definitions.  That meant I'd take a return with a cast and save it to a
variable first so I could suppress the warnings when I couldn't actually fix the
problems.

I added comments for the suppressions I added except where they were really obvious
(i.e. unused in tests).

I removed a variable from InjectorImpl that was completely unused.  I can rework that
to suppress the unused, but it's otherwise dead code.

All the tests still pass, but I hope nobody takes my word for it.

Attachment: gist
   guice-warning-cleanup-335.diff

@gissuebot
Copy link
Author

From kevinb9n on June 06, 2007 07:40:01

I'm speechless!  Thanks!

@gissuebot
Copy link
Author

From dsallings on August 08, 2007 19:19:19

I'm tracking this in hg with mq here: http://hg.west.spy.net/hg/hacks/guice/

Attachment: gist
   guice-warning-cleanup-345.diff

@gissuebot
Copy link
Author

From crazyboblee on September 09, 2007 13:22:43

Thanks for the help, dsallings. I basically rewrote InjectorImpl to be
binding-oriented rather than InternalFactory oriented, and it made the typing a lot
easier to reason about.

Status: Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant