New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clean up warnings #40
Comments
From dsallings on June 06, 2007 01:11:14 The attached patch against 335 cleans all but two warnings in my eclipse Note that I did add some SuppressWarnings, but tried to keep them localized to I added comments for the suppressions I added except where they were really obvious I removed a variable from InjectorImpl that was completely unused. I can rework that All the tests still pass, but I hope nobody takes my word for it. Attachment: gist |
From kevinb9n on June 06, 2007 07:40:01 I'm speechless! Thanks! |
From dsallings on August 08, 2007 19:19:19 I'm tracking this in hg with mq here: http://hg.west.spy.net/hg/hacks/guice/ Attachment: gist |
From crazyboblee on September 09, 2007 13:22:43 Thanks for the help, dsallings. I basically rewrote InjectorImpl to be Status: Fixed |
From kevinb9n on February 27, 2007 03:45:37
We ought to compile warning-free and only
@
SuppressWarnings where necessaryand where we can explain how we know the suppression is safe. I think the
refactoring and commenting necessary to handle this issue will make the
code easiser to understand.
Original issue: http://code.google.com/p/google-guice/issues/detail?id=40
The text was updated successfully, but these errors were encountered: