Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binding API allows bogus sequences of calls #36

Closed
gissuebot opened this issue Jul 7, 2014 · 4 comments
Closed

Binding API allows bogus sequences of calls #36

gissuebot opened this issue Jul 7, 2014 · 4 comments
Labels
1.0RC3 bug imported Priority-Medium

Comments

@gissuebot
Copy link

From kevinb9n on February 27, 2007 03:08:09

We should tighten up the API so that you can only call things that are
valid; this will make auto-completion a breeze.  A downside is that this
usually forces us to mandate a particular order that the calls happen in
as well, but I don't think this is a problem.

Original issue: http://code.google.com/p/google-guice/issues/detail?id=36
@gissuebot
Copy link
Author

From kevinb9n on March 01, 2007 23:15:33

Huh, I guess you really did do a good job on this, Bob. :)  The only 2 bogosities I
found were:

* bind(Class).annotatedWith().annotatedWith()

  • bind(Key).annotatedWith()

This seems quite easily fixable, so I'll tag for RC3.

Labels: 1.0RC3

@gissuebot
Copy link
Author

From crazyboblee on March 02, 2007 07:42:48

Yeah, I just couldn't think of what to name the interface for that one. ;)

I guess we could make BindingBuilder only include impls and scopes. Then
AnnotatedBindingBuilder could extend that and add annotations?

@gissuebot
Copy link
Author

From crazyboblee on March 02, 2007 07:43:20

Yeah, and then bind(Key) would return only BindingBuilder!

@gissuebot
Copy link
Author

From crazyboblee on March 02, 2007 08:54:37

Fixed in rev 255. I think we have it all locked down now. We still have to handle
duplicate method calls obviously (the user could hold onto an object and call it twice).

Status: Fixed

@gissuebot gissuebot mentioned this issue Jul 7, 2014
Open
@yogeshbelur yogeshbelur mentioned this issue Jan 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0RC3 bug imported Priority-Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gissuebot