Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prohibit bindings to any com.google.inject.* type #32

Closed
gissuebot opened this issue Jul 7, 2014 · 4 comments
Closed

Prohibit bindings to any com.google.inject.* type #32

gissuebot opened this issue Jul 7, 2014 · 4 comments
Labels
1.0RC3 bug imported Priority-Medium

Comments

@gissuebot
Copy link

From kevinb9n on February 27, 2007 01:58:35

Someone making such a binding seems like it could only lead to pain ("so
much pain").  We should probably forbid it?  Without breaking the unit tests.

Original issue: http://code.google.com/p/google-guice/issues/detail?id=32
@gissuebot
Copy link
Author

From crazyboblee on February 27, 2007 10:28:52

Works for me. We can always whitelist certain classes in the future, but we can't go
the other way so this seem to be the safe choice.

@gissuebot
Copy link
Author

From kevinb9n on February 28, 2007 15:08:32

tagging for the RC because it's easy enough

Labels: 1.0RC3

@gissuebot
Copy link
Author

From crazyboblee on February 28, 2007 15:27:37

How did I miss this one? Definitely RC3.

@gissuebot
Copy link
Author

From kevinb9n on February 28, 2007 18:15:39

fixed with revision 246 .

of course, the default bindings of Stage and Injector are still allowed.

Summary: Prohibit bindings to any com.google.inject.* type
Status: Fixed

@yogeshbelur yogeshbelur mentioned this issue Jan 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.0RC3 bug imported Priority-Medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gissuebot