From limpbizkit on August 14, 2008 13:33:39

Disabling our OSGi-friendly classloader fixes this. I've disabled that classloader, and checked in your test: https://code.google.com/p/google-guice/source/detail?r=604

Summary: OSGi classloading doesn't work with package-private dependencies

From sberlin on August 14, 2008 13:42:52

Thanks!  I'm heading out for three weeks in approximately 18 hours... so will be
silent for a bit.

From mcculls on August 25, 2008 02:36:25

Suggested patch that checks parameter visibility for methods and constructors.
Also includes an additional testcase and fixes a typo in the test module name.

Attachment: gist
   GUICE_ISSUE_235.patch

From mcculls on August 28, 2008 01:55:51

Made minor performance improvement to patch

Attachment: gist
   GUICE_ISSUE_235.20080828.patch

From limpbizkit on August 31, 2008 07:24:07

(No comment was entered for this change.)

Labels: Milestone-Release2.0

From mcculls on September 09, 2008 22:44:41

As the next release will be Guice 2, I'm also thinking this line in common.xml:

  <property name="api.version" value="1.0"/>

should be changed to:

  <property name="api.version" value="2.0"/>

to reflect the new API level (this is also related to issue #243 ).

From mcculls on September 20, 2008 07:29:42

Updated patch for the latest trunk (note that this patch also renames
PackageVisilibityTestModule.java to PackageVisibilityTestModule.java)

Attachment: gist
   GUICE_ISSUE_235.20080920.patch

From mcculls on November 05, 2008 10:30:55

Updated patch to work with latest trunk.

Attachment: gist
   GUICE_ISSUE_235.20081106.patch

From limpbizkit on November 29, 2008 17:02:52

I've finally applied mcculls' patch with r710 .

This changes mccull's original patch by using the System Class Loader if that was used to load the application
classes. This should be a fairly reasonable thing to do, and it means users who aren't using OSGi or Java EE get a
simpler experience.

Status: Fixed

From mcculls on November 30, 2008 03:01:14

Tested locally with peaberry and it passes all existing tests - thanks Jesse!