google-gin - Project Hosting on Google Code

Today 21 hours ago r130 (Fixed static injection) committed by aragos - Fixed static injection Fixed static injection 21 hours ago GinTutorial (Using GIN to create a GWT widget) Wiki page edited by aragos - Revision r129 Updated tutorial. Revision r129 Updated tutorial. Yesterday 46 hours ago GinFaq (GIN frequently asked questions) Wiki page edited by aragos - Revision r128 Updated FAQs. Revision r128 Updated FAQs. 46 hours ago GinFaq (GIN frequently asked questions) Wiki page edited by aragos - Revision r127 Updated FAQs. Revision r127 Updated FAQs. 47 hours ago issue 73 (ant build fails if gwt.home point to a gwt-2.0.0 installatio...) commented on by larse...@gmail.com - I built it yesterday and it worked without issue. Perhaps you're not pointing to a JDK? I built it yesterday and it worked without issue. Perhaps you're not pointing to a JDK? Last 7 days Dec 28, 2009 issue 73 (ant build fails if gwt.home point to a gwt-2.0.0 installatio...) commented on by ch...@campsbayterrace.com - I have downloaded Gin 126 and tried to build using Ant in Eclipese 3.5 but get the following: init: clean: [delete] Deleting directory C:\Developer\Workspace\Gin\trunk\out compile.production: [mkdir] Created dir: C:\Developer\Workspace\Gin\trunk\out\production [javac] Compiling 44 source files to C:\Developer\Workspace\Gin\trunk\out\production BUILD FAILED C:\Developer\Workspace\Gin\trunk\build.xml:106: Error running javac.exe compiler I have checked the GWT_HOME environment variable and have set basedir via Run>Ant... but cannot make progress. I am sure it is a problem with my poor understanding of the Ant build process so request that gin.jar be made available for download if at all possible! I have downloaded Gin 126 and tried to build using Ant in Eclipese 3.5 but get the following: init: clean: [delete] Deleting directory C:\Developer\Workspace\Gin\trunk\out compile.production: [mkdir] Created dir: C:\Developer\Workspace\Gin\trunk\out\production [javac] Compiling 44 source files to C:\Developer\Workspace\Gin\trunk\out\production BUILD FAILED C:\Developer\Workspace\Gin\trunk\build.xml:106: Error running javac.exe compiler I have checked the GWT_HOME environment variable and have set basedir via Run>Ant... but cannot make progress. I am sure it is a problem with my poor understanding of the Ant build process so request that gin.jar be made available for download if at all possible! Last 30 days Dec 22, 2009 ContributingToGin (Information on how you can contribute to GIN) Wiki page edited by aragos - Revision r126 Edited wiki page through web user interface. Revision r126 Edited wiki page through web user interface. Dec 22, 2009 issue 60 (Inject the Ginjector fails with static field inject) commented on by awi...@google.com - This patch resolves a related issue as well: static injection of Messages subinterfaces fails. An apparent workaround for this: perform an ignored, non-static injection of the Messages, Ginjector, etc. into an existing object. This patch resolves a related issue as well: static injection of Messages subinterfaces fails. An apparent workaround for this: perform an ignored, non-static injection of the Messages, Ginjector, etc. into an existing object. Dec 21, 2009 issue 69 (A<? super B> is needed, but GIN looks for A<? extends B>) Status changed by aragos - Fixed in r125. Status: Fixed Fixed in r125. Status: Fixed Dec 21, 2009 r125 (Fixed wildcards issues (issue #69)) committed by aragos - Fixed wildcards issues ( issue #69 ) Fixed wildcards issues ( issue #69 ) Dec 21, 2009 issue 67 (Create new example app) Status changed by aragos - Submitted in r124. Thanks for the review! Status: Fixed Submitted in r124. Thanks for the review! Status: Fixed Dec 21, 2009 r124 (Added new sample application (issue #67)) committed by aragos - Added new sample application ( issue #67 ) Added new sample application ( issue #67 ) Dec 21, 2009 issue 73 (ant build fails if gwt.home point to a gwt-2.0.0 installatio...) Status changed by aragos - Submitted in r123. Status: Fixed Submitted in r123. Status: Fixed Dec 21, 2009 r123 (Updated Gin to GWT 2.0 (issue #73)) committed by aragos - Updated Gin to GWT 2.0 ( issue #73 ) Updated Gin to GWT 2.0 ( issue #73 ) Dec 21, 2009 issue 52 (Hosted Mode Refresh support) commented on by alen_vre...@yahoo.com - Been bogged down in unix programming. Anyway: Afaik IHM isn't complete yet[1]. I will have some free time at the end of this week. Will take a look and prepare some revised patched then. I have the following in mind o) Make a patch for GIN that enables the hosted mode refresh support if getTypeOracleClassLoader() exist. o) Make a patch for GWT that enables to get the type oracle class loader. Will open an issue on the gwt issue tracker for this and post the patch there. HTH [1] http://code.google.com/p/google-web-toolkit/issues/detail?id=847 Been bogged down in unix programming. Anyway: Afaik IHM isn't complete yet[1]. I will have some free time at the end of this week. Will take a look and prepare some revised patched then. I have the following in mind o) Make a patch for GIN that enables the hosted mode refresh support if getTypeOracleClassLoader() exist. o) Make a patch for GWT that enables to get the type oracle class loader. Will open an issue on the gwt issue tracker for this and post the patch there. HTH [1] http://code.google.com/p/google-web-toolkit/issues/detail?id=847 Dec 17, 2009 issue 73 (ant build fails if gwt.home point to a gwt-2.0.0 installatio...) Status changed by aragos - Status: Review Status: Review Dec 17, 2009 issue 73 (ant build fails if gwt.home point to a gwt-2.0.0 installatio...) commented on by aragos - I wrote a patch that covers this issue and updates the tests to GWT 2.0. Please review it at: http://codereview.appspot.com/179100 Once the review has been completed I'll check the changes in. I wrote a patch that covers this issue and updates the tests to GWT 2.0. Please review it at: http://codereview.appspot.com/179100 Once the review has been completed I'll check the changes in. Dec 17, 2009 r122 (Added a small test for method injection) committed by aragos - Added a small test for method injection Added a small test for method injection Dec 17, 2009 issue 52 (Hosted Mode Refresh support) commented on by robert.munteanu - GWT 2.0 is out with OOPHM. Are there any changes of posting the patch you mentioned in time for 1.0 ? GWT 2.0 is out with OOPHM. Are there any changes of posting the patch you mentioned in time for 1.0 ? Dec 16, 2009 issue 72 (Problem in BindingProcessor when trying to bind inner class ...) Status changed by aragos - Status: Fixed Status: Fixed Dec 16, 2009 r121 (Fixed binary/sourcename conversion (issue #72) ) committed by aragos - Fixed binary/sourcename conversion ( issue #72 ) Fixed binary/sourcename conversion ( issue #72 ) Dec 14, 2009 issue 73 (ant build fails if gwt.home point to a gwt-2.0.0 installatio...) commented on by diaz.salvador - Thank you for the quick answer. Thank you for the quick answer. Dec 13, 2009 ContributingToGin (Information on how you can contribute to GIN) Wiki page edited by aragos - Revision r120 Added note (need to be in google-gin to send reviews) to contributor page. Revision r120 Added note (need to be in google-gin to send reviews) to contributor page. Dec 13, 2009 issue 72 (Problem in BindingProcessor when trying to bind inner class ...) Status changed by aragos - Fix submitted for review: http://codereview.appspot.com/176069 Status: Review Fix submitted for review: http://codereview.appspot.com/176069 Status: Review Dec 13, 2009 issue 71 (Add a protected method to AbstractGinModule to expose the Gi...) Status changed by aragos - Status: Fixed Status: Fixed Dec 13, 2009 issue 73 (ant build fails if gwt.home point to a gwt-2.0.0 installatio...) changed by aragos - Thanks, I'll see if I can tweak the build file so it accepts both versions. Status: Accepted Owner: aragos Thanks, I'll see if I can tweak the build file so it accepts both versions. Status: Accepted Owner: aragos Dec 13, 2009 issue 73 (ant build fails if gwt.home point to a gwt-2.0.0 installatio...) reported by diaz.salvador - What steps will reproduce the problem? 1. Check out the trunk 2. point gwt.home ant variable to a gwt-2.0.0 installation 3. run the build (I actually just wanted to build the jar so I just ran clean, compile.production, dist targets) What is the expected output? What do you see instead? Instead of having a successfull build, compilation fails because of gwt-dev classes not being found, you'll find the full output in the attached file named failed-build.txt What version of the product are you using? On what operating system? Just checked out trunk revision 119. On Mac OS X 10.5.8, the ant tasks are run from Eclipse Galileo 3.5(Build id: 20090920-1017) Please provide any additional information below. To get a successful build for those tasks (clean, compile.production, dist) change line 44 in the build.xml from: <fileset dir="${gwt.home}" includes="gwt-dev-.jar"/> to: <pathelement location="${gwt.home}/gwt-dev.jar"/> I also attach a patch for build.xml but it doesn't repair the compile.tests task What steps will reproduce the problem? 1. Check out the trunk 2. point gwt.home ant variable to a gwt-2.0.0 installation 3. run the build (I actually just wanted to build the jar so I just ran clean, compile.production, dist targets) What is the expected output? What do you see instead? Instead of having a successfull build, compilation fails because of gwt-dev classes not being found, you'll find the full output in the attached file named failed-build.txt What version of the product are you using? On what operating system? Just checked out trunk revision 119. On Mac OS X 10.5.8, the ant tasks are run from Eclipse Galileo 3.5(Build id: 20090920-1017) Please provide any additional information below. To get a successful build for those tasks (clean, compile.production, dist) change line 44 in the build.xml from: <fileset dir="${gwt.home}" includes="gwt-dev-.jar"/> to: <pathelement location="${gwt.home}/gwt-dev.jar"/> I also attach a patch for build.xml but it doesn't repair the compile.tests task Dec 11, 2009 issue 68 (Release 1.0) Blocked on changed by aragos - Dec 11, 2009 issue 72 (Problem in BindingProcessor when trying to bind inner class ...) changed by aragos - Thanks for bringing this to my attention, I'll take a look into it. Solution is probably to recursively check for enclosing classes. Status: Accepted Owner: aragos Thanks for bringing this to my attention, I'll take a look into it. Solution is probably to recursively check for enclosing classes. Status: Accepted Owner: aragos Dec 11, 2009 issue 72 (Problem in BindingProcessor when trying to bind inner class ...) reported by baronce...@google.com - Not entirely sure, but I think the way NameGenerator#binaryNameToSourceName works has a bug in that it only replaces the last "$". In my case, I had a Gin module that was a static inner class of my entry point class, and a second class that was a static inner class of the Gin module. Something like: public class A extends EntryPoint { [...] public static class SomeGinModule extends AbstractGinModule { protected void configure() { [...] bind(new TypeLiteral<SomeInterface>).toProvider(ModelProvider.class); [...] } private static class ModelProvider implements Provider<SomeClass> { [..] } } } I had this exception at generation phase: java.lang.NullPointerException: null at com.google.gwt.inject.rebind.BindingsProcessor.createImplicitBinding(Bindin gsProcessor.java:425) at com.google.gwt.inject.rebind.BindingsProcessor.createImplicitBindingForUnre solved(BindingsProcessor.java:231) at com.google.gwt.inject.rebind.BindingsProcessor.createImplicitBindingsForUnr esolved(BindingsProcessor.java:219) at com.google.gwt.inject.rebind.BindingsProcessor.process(BindingsProcessor.ja va:211) at com.google.gwt.inject.rebind.GinjectorGeneratorImpl.generate(GinjectorGener atorImpl.java:76) at com.google.gwt.inject.rebind.GinjectorGenerator.generate(GinjectorGenerator .java:47) at com.google.gwt.dev.cfg.RuleGenerateWith.realize(RuleGenerateWith.java:49) at com.google.gwt.dev.shell.StandardRebindOracle$Rebinder.tryRebind(StandardRe bindOracle.java:108) at com.google.gwt.dev.shell.StandardRebindOracle$Rebinder.rebind(StandardRebin dOracle.java:54) at com.google.gwt.dev.shell.StandardRebindOracle.rebind(StandardRebindOracle.j ava:154) at com.google.gwt.dev.shell.ShellModuleSpaceHost.rebind(ShellModuleSpaceHost.j ava:117) at com.google.gwt.dev.shell.ModuleSpace.rebind(ModuleSpace.java:538) at com.google.gwt.dev.shell.ModuleSpace.rebindAndCreate(ModuleSpace.java:425) at com.google.gwt.dev.shell.GWTBridgeImpl.create(GWTBridgeImpl.java:39) at com.google.gwt.core.client.GWT.create(GWT.java:98) at com.google.ads.syn.adsense.fe.apps.allowandblockads.gwt.settings.testing.Fa keAllowAndBlockAdsSettingsModule.getGwtCreatedInjector(FakeAllowAndBlockAds SettingsModule.java:48) at com.google.ads.syn.adsense.fe.apps.config.gin.ActivityEntryPoint.getActivit yMapProvider(ActivityEntryPoint.java:41) at com.google.ads.syn.adsense.fe.apps.config.gin.ActivityEntryPoint.access$0(A ctivityEntryPoint.java:39) at com.google.ads.syn.adsense.fe.apps.config.gin.ActivityEntryPoint$1.getActiv ity(ActivityEntryPoint.java:52) at com.google.ads.syn.publisher.client.gwt.common.navigation.AbstractActivityC reator$1.onSuccess(AbstractActivityCreator.java:37) at com.google.gwt.core.client.GWT.runAsyncWithoutCodeSplitting(GWT.java:276) at com.google.gwt.core.client.GWT.runAsync(GWT.java:220) at com.google.ads.syn.publisher.client.gwt.common.navigation.AbstractActivityC reator.createActivity(AbstractActivityCreator.java:29) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.getActivityAndStart(NavigationController.java:245) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.access$6(NavigationController.java:236) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler$2.onSuccess(NavigationController.java:226) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler$2.onSuccess(NavigationController.java:1) at com.google.ads.syn.publisher.client.gwt.common.navigation.StandardApplicati onStarter.prepare(StandardApplicationStarter.java:59) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.initializeAndStartActivity(NavigationController.java:221) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.startActivity(NavigationController.java:211) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.startActivity(NavigationController.java:173) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.autoStartIfNeeded(NavigationController.java:143) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.install(NavigationController.java:137) at com.google.ads.syn.publisher.client.gwt.common.ActivityInstaller.install(Ac tivityInstaller.java:67) at com.google.ads.syn.adsense.fe.apps.config.gin.ActivityEntryPoint.onModuleLo ad(ActivityEntryPoint.java:49) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:3 9) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImp l.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at com.google.gwt.dev.shell.ModuleSpace.onLoad(ModuleSpace.java:380) at com.google.gwt.dev.shell.OophmSessionHandler.loadModule(OophmSessionHandler .java:172) at com.google.gwt.dev.shell.BrowserChannelServer.processConnection(BrowserChan nelServer.java:345) at com.google.gwt.dev.shell.BrowserChannelServer.run(BrowserChannelServer.java :192) at java.lang.Thread.run(Thread.java:619) so I debugged the generation process, and it turns out that in createImplicitBinding the "keyUtil.getRawClassType" call returns null because the object in the "allTypes" map in TypeOracle can be found with the name resulting from the substitution of both "$" with dots (i.e. both the one for the inclusion of the gin module class in the entry point one and one for the inclusion of the bound class in the gin module, but the replace in KeyUtil only changes the second one. Obvious workaround: move the class definition out of the inner class and at its same level (i.e.: as an inner class of the EntryPoint itself). Not entirely sure, but I think the way NameGenerator#binaryNameToSourceName works has a bug in that it only replaces the last "$". In my case, I had a Gin module that was a static inner class of my entry point class, and a second class that was a static inner class of the Gin module. Something like: public class A extends EntryPoint { [...] public static class SomeGinModule extends AbstractGinModule { protected void configure() { [...] bind(new TypeLiteral<SomeInterface>).toProvider(ModelProvider.class); [...] } private static class ModelProvider implements Provider<SomeClass> { [..] } } } I had this exception at generation phase: java.lang.NullPointerException: null at com.google.gwt.inject.rebind.BindingsProcessor.createImplicitBinding(Bindin gsProcessor.java:425) at com.google.gwt.inject.rebind.BindingsProcessor.createImplicitBindingForUnre solved(BindingsProcessor.java:231) at com.google.gwt.inject.rebind.BindingsProcessor.createImplicitBindingsForUnr esolved(BindingsProcessor.java:219) at com.google.gwt.inject.rebind.BindingsProcessor.process(BindingsProcessor.ja va:211) at com.google.gwt.inject.rebind.GinjectorGeneratorImpl.generate(GinjectorGener atorImpl.java:76) at com.google.gwt.inject.rebind.GinjectorGenerator.generate(GinjectorGenerator .java:47) at com.google.gwt.dev.cfg.RuleGenerateWith.realize(RuleGenerateWith.java:49) at com.google.gwt.dev.shell.StandardRebindOracle$Rebinder.tryRebind(StandardRe bindOracle.java:108) at com.google.gwt.dev.shell.StandardRebindOracle$Rebinder.rebind(StandardRebin dOracle.java:54) at com.google.gwt.dev.shell.StandardRebindOracle.rebind(StandardRebindOracle.j ava:154) at com.google.gwt.dev.shell.ShellModuleSpaceHost.rebind(ShellModuleSpaceHost.j ava:117) at com.google.gwt.dev.shell.ModuleSpace.rebind(ModuleSpace.java:538) at com.google.gwt.dev.shell.ModuleSpace.rebindAndCreate(ModuleSpace.java:425) at com.google.gwt.dev.shell.GWTBridgeImpl.create(GWTBridgeImpl.java:39) at com.google.gwt.core.client.GWT.create(GWT.java:98) at com.google.ads.syn.adsense.fe.apps.allowandblockads.gwt.settings.testing.Fa keAllowAndBlockAdsSettingsModule.getGwtCreatedInjector(FakeAllowAndBlockAds SettingsModule.java:48) at com.google.ads.syn.adsense.fe.apps.config.gin.ActivityEntryPoint.getActivit yMapProvider(ActivityEntryPoint.java:41) at com.google.ads.syn.adsense.fe.apps.config.gin.ActivityEntryPoint.access$0(A ctivityEntryPoint.java:39) at com.google.ads.syn.adsense.fe.apps.config.gin.ActivityEntryPoint$1.getActiv ity(ActivityEntryPoint.java:52) at com.google.ads.syn.publisher.client.gwt.common.navigation.AbstractActivityC reator$1.onSuccess(AbstractActivityCreator.java:37) at com.google.gwt.core.client.GWT.runAsyncWithoutCodeSplitting(GWT.java:276) at com.google.gwt.core.client.GWT.runAsync(GWT.java:220) at com.google.ads.syn.publisher.client.gwt.common.navigation.AbstractActivityC reator.createActivity(AbstractActivityCreator.java:29) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.getActivityAndStart(NavigationController.java:245) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.access$6(NavigationController.java:236) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler$2.onSuccess(NavigationController.java:226) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler$2.onSuccess(NavigationController.java:1) at com.google.ads.syn.publisher.client.gwt.common.navigation.StandardApplicati onStarter.prepare(StandardApplicationStarter.java:59) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.initializeAndStartActivity(NavigationController.java:221) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.startActivity(NavigationController.java:211) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.startActivity(NavigationController.java:173) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.autoStartIfNeeded(NavigationController.java:143) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.install(NavigationController.java:137) at com.google.ads.syn.publisher.client.gwt.common.ActivityInstaller.install(Ac tivityInstaller.java:67) at com.google.ads.syn.adsense.fe.apps.config.gin.ActivityEntryPoint.onModuleLo ad(ActivityEntryPoint.java:49) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:3 9) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImp l.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at com.google.gwt.dev.shell.ModuleSpace.onLoad(ModuleSpace.java:380) at com.google.gwt.dev.shell.OophmSessionHandler.loadModule(OophmSessionHandler .java:172) at com.google.gwt.dev.shell.BrowserChannelServer.processConnection(BrowserChan nelServer.java:345) at com.google.gwt.dev.shell.BrowserChannelServer.run(BrowserChannelServer.java :192) at java.lang.Thread.run(Thread.java:619) so I debugged the generation process, and it turns out that in createImplicitBinding the "keyUtil.getRawClassType" call returns null because the object in the "allTypes" map in TypeOracle can be found with the name resulting from the substitution of both "$" with dots (i.e. both the one for the inclusion of the gin module class in the entry point one and one for the inclusion of the bound class in the gin module, but the replace in KeyUtil only changes the second one. Obvious workaround: move the class definition out of the inner class and at its same level (i.e.: as an inner class of the EntryPoint itself). Dec 08, 2009 r119 (Adding access to binders, patch by dpb) committed by aragos - Adding access to binders, patch by dpb Adding access to binders, patch by dpb Dec 08, 2009 issue 69 (A<? super B> is needed, but GIN looks for A<? extends B>) Status changed by aragos - Fix submitted for review: http://codereview.appspot.com/165095 Please review this (simple) change so it can go in quickly! Status: Review Fix submitted for review: http://codereview.appspot.com/165095 Please review this (simple) change so it can go in quickly! Status: Review Dec 08, 2009 issue 71 (Add a protected method to AbstractGinModule to expose the Gi...) commented on by d...@google.com - OK, you have to help me out. Not used to this process. What do I put in the Base field of the upload form? OK, you have to help me out. Not used to this process. What do I put in the Base field of the upload form? Dec 08, 2009 issue 71 (Add a protected method to AbstractGinModule to expose the Gi...) Status changed by aragos - Can you please follow the directions here (as a Googler you don't need the CLA): http://code.google.com/p/google-gin/wiki/ContributingToGin Once the codereview is through, I'll submit it. I think this change is small enough to go in before the release. Thanks for contributing! Status: Accepted Can you please follow the directions here (as a Googler you don't need the CLA): http://code.google.com/p/google-gin/wiki/ContributingToGin Once the codereview is through, I'll submit it. I think this change is small enough to go in before the release. Thanks for contributing! Status: Accepted Dec 07, 2009 issue 68 (Release 1.0) Blocked on changed by aragos - Dec 07, 2009 issue 69 (A<? super B> is needed, but GIN looks for A<? extends B>) changed by aragos - Yes, I think I recently saw this bug in the code, will try to fix it quickly. Status: Accepted Owner: aragos Yes, I think I recently saw this bug in the code, will try to fix it quickly. Status: Accepted Owner: aragos Dec 07, 2009 issue 70 (@Inject( optional = true) doesn't work with method injection) Status changed by aragos - You're running into a subtle but intended behavior here: Gin tries to create your type by calling GWT.create() instead of failing for @Optional. I assume that A is an interface in your case. Unfortunately, Gin (currently) cannot tell whether there is a GWT binding for A and so falls back to trying that GWT binding before taking @Optional into account. Status: Invalid You're running into a subtle but intended behavior here: Gin tries to create your type by calling GWT.create() instead of failing for @Optional. I assume that A is an interface in your case. Unfortunately, Gin (currently) cannot tell whether there is a GWT binding for A and so falls back to trying that GWT binding before taking @Optional into account. Status: Invalid Dec 07, 2009 issue 71 (Add a protected method to AbstractGinModule to expose the Gi...) commented on by d...@google.com - Sorry, meant to mention that a patch is included. Sorry, meant to mention that a patch is included. Dec 07, 2009 issue 71 (Add a protected method to AbstractGinModule to expose the Gi...) reported by d...@google.com - This will enable method reuse within and across GIN modules. class MyModule extends AbstractGinModule { void configure() { SomeModuleHelper.bindMyCommonBindings(binder(), parameters); } } This will enable method reuse within and across GIN modules. class MyModule extends AbstractGinModule { void configure() { SomeModuleHelper.bindMyCommonBindings(binder(), parameters); } } Dec 07, 2009 issue 70 (@Inject( optional = true) doesn't work with method injection) reported by bochenski.jakub - What steps will reproduce the problem? 1. add to a GIN-managed class a method like: @Inject(optional = true) void injectA(A object){ } , where A is a class not configured anywhere in GIN modules 2. request this object from GIN What is the expected output? What do you see instead? Expected no change in behaviour - object of this class is not available, but injection is optional. Instead the result is an error: [ERROR] Deferred binding result type 'A' should not be abstract What steps will reproduce the problem? 1. add to a GIN-managed class a method like: @Inject(optional = true) void injectA(A object){ } , where A is a class not configured anywhere in GIN modules 2. request this object from GIN What is the expected output? What do you see instead? Expected no change in behaviour - object of this class is not available, but injection is optional. Instead the result is an error: [ERROR] Deferred binding result type 'A' should not be abstract Dec 07, 2009 issue 69 (A<? super B> is needed, but GIN looks for A<? extends B>) reported by bochenski.jakub - What steps will reproduce the problem? 1. Create class class C { @Inject C(A<? super B>) {} } 2. bind implementation of A<? super B> in GIN, e.g.: bind(new TypeLiteral<A<? super B>>(){ }).to(D.class) 3. Request C from Ginjector What is the expected output? What do you see instead? Instance of class D should be injected into C. Instead an exception is thrown: com.google.inject.ProvisionException: Guice provision errors: 1) Can't get class type for ? extends B 1 error ----- If the requested/provided classes are annotated with @Named the result is: No implementation bound for key Key[type=A<? extends B>, annotation=@com.google.inject.name.Named(value=TheNameEntered)] 4. Workaround Bind to A<? extends B>, e.g.: bind(new TypeLiteral<A<? extends B>>(){ }).to(D.class) What steps will reproduce the problem? 1. Create class class C { @Inject C(A<? super B>) {} } 2. bind implementation of A<? super B> in GIN, e.g.: bind(new TypeLiteral<A<? super B>>(){ }).to(D.class) 3. Request C from Ginjector What is the expected output? What do you see instead? Instance of class D should be injected into C. Instead an exception is thrown: com.google.inject.ProvisionException: Guice provision errors: 1) Can't get class type for ? extends B 1 error ----- If the requested/provided classes are annotated with @Named the result is: No implementation bound for key Key[type=A<? extends B>, annotation=@com.google.inject.name.Named(value=TheNameEntered)] 4. Workaround Bind to A<? extends B>, e.g.: bind(new TypeLiteral<A<? extends B>>(){ }).to(D.class) Dec 02, 2009 issue 67 (Create new example app) commented on by A.A.Vasiljev - App repackaged for GWT-2.0.0-rc2 App repackaged for GWT-2.0.0-rc2 Dec 02, 2009 issue 67 (Create new example app) commented on by A.A.Vasiljev - 1) patching build.xml in trunk fails. Attempt to see diff in Rietveld: http://codereview.appspot.com/116052/diff/1/15 gives: error: old chunk mismatch diff for build.xml is made against previous version, but there is no samples/simple/build.xml committed in trunk. The patch is really made against HigherLower's build.xml. 2) There is no build.properties in the project, but build.xml patch references them. 1) patching build.xml in trunk fails. Attempt to see diff in Rietveld: http://codereview.appspot.com/116052/diff/1/15 gives: error: old chunk mismatch diff for build.xml is made against previous version, but there is no samples/simple/build.xml committed in trunk. The patch is really made against HigherLower's build.xml. 2) There is no build.properties in the project, but build.xml patch references them. Dec 02, 2009 issue 67 (Create new example app) commented on by A.A.Vasiljev - There is no build.properties in the project, but build.xml patch references them. There is no build.properties in the project, but build.xml patch references them. Dec 02, 2009 issue 67 (Create new example app) commented on by A.A.Vasiljev - There is no build.properties in the project, but build.xml patch reference them. There is no build.properties in the project, but build.xml patch reference them. Dec 02, 2009 issue 67 (Create new example app) commented on by A.A.Vasiljev - patching build.xml in trunk fails. Attempt to see diff in Rietveld: http://codereview.appspot.com/116052/diff/1/15 gives: error: old chunk mismatch diff for build.xml is made against previous version, but there is no samples/simple/build.xml committed in trunk. patching build.xml in trunk fails. Attempt to see diff in Rietveld: http://codereview.appspot.com/116052/diff/1/15 gives: error: old chunk mismatch diff for build.xml is made against previous version, but there is no samples/simple/build.xml committed in trunk. Dec 02, 2009 issue 67 (Create new example app) commented on by A.A.Vasiljev - patching build.xml in trunk fails. Attempt to see diff in Rietveld: http://codereview.appspot.com/116052/diff/1/15 gives: error: old chunk mismatch patching build.xml in trunk fails. Attempt to see diff in Rietveld: http://codereview.appspot.com/116052/diff/1/15 gives: error: old chunk mismatch Dec 01, 2009 issue 65 (Current version of guice (guice-snapshot) is causing NoSuchM...) commented on by aragos - Once the review is through (I'll try to get to it by the end of the week) and you have your CLA done I can download the latest patch from the codereview site and then use that. Don't worry about the one message that didn't get through to the list. :) Once the review is through (I'll try to get to it by the end of the week) and you have your CLA done I can download the latest patch from the codereview site and then use that. Don't worry about the one message that didn't get through to the list. :) Earlier this year Dec 01, 2009 issue 65 (Current version of guice (guice-snapshot) is causing NoSuchM...) commented on by MGe...@gmail.com - Note that I still expect my CLA agreement. Where do I have to upload it after I receive it ? Here ? or as attachment at http://codereview.appspot.com ? Note that I still expect my CLA agreement. Where do I have to upload it after I receive it ? Here ? or as attachment at http://codereview.appspot.com ? Nov 30, 2009 issue 65 (Current version of guice (guice-snapshot) is causing NoSuchM...) commented on by MGe...@gmail.com - Note that post was not sent to the group "google-gin@googlegroups.com", cause I'm not a currently member of it. " We're writing to let you know that the group you tried to contact (google-gin) may not exist, or you may not have permission to post messages to the group. A few more details on why you weren't able to post: * You might have spelled or formatted the group name incorrectly. * The owner of the group may have removed this group. * You may need to join the group before receiving permission to post. * This group may not be open to posting. " If you want I could re-send it again after I join the group. Note that post was not sent to the group "google-gin@googlegroups.com", cause I'm not a currently member of it. " We're writing to let you know that the group you tried to contact (google-gin) may not exist, or you may not have permission to post messages to the group. A few more details on why you weren't able to post: * You might have spelled or formatted the group name incorrectly. * The owner of the group may have removed this group. * You may need to join the group before receiving permission to post. * This group may not be open to posting. " If you want I could re-send it again after I join the group.

issue 72 (Problem in BindingProcessor when trying to bind inner class ...) reported by baronce...@google.com - Not entirely sure, but I think the way NameGenerator#binaryNameToSourceName works has a bug in that it only replaces the last "$". In my case, I had a Gin module that was a static inner class of my entry point class, and a second class that was a static inner class of the Gin module. Something like: public class A extends EntryPoint { [...] public static class SomeGinModule extends AbstractGinModule { protected void configure() { [...] bind(new TypeLiteral<SomeInterface>).toProvider(ModelProvider.class); [...] } private static class ModelProvider implements Provider<SomeClass> { [..] } } } I had this exception at generation phase: java.lang.NullPointerException: null at com.google.gwt.inject.rebind.BindingsProcessor.createImplicitBinding(Bindin gsProcessor.java:425) at com.google.gwt.inject.rebind.BindingsProcessor.createImplicitBindingForUnre solved(BindingsProcessor.java:231) at com.google.gwt.inject.rebind.BindingsProcessor.createImplicitBindingsForUnr esolved(BindingsProcessor.java:219) at com.google.gwt.inject.rebind.BindingsProcessor.process(BindingsProcessor.ja va:211) at com.google.gwt.inject.rebind.GinjectorGeneratorImpl.generate(GinjectorGener atorImpl.java:76) at com.google.gwt.inject.rebind.GinjectorGenerator.generate(GinjectorGenerator .java:47) at com.google.gwt.dev.cfg.RuleGenerateWith.realize(RuleGenerateWith.java:49) at com.google.gwt.dev.shell.StandardRebindOracle$Rebinder.tryRebind(StandardRe bindOracle.java:108) at com.google.gwt.dev.shell.StandardRebindOracle$Rebinder.rebind(StandardRebin dOracle.java:54) at com.google.gwt.dev.shell.StandardRebindOracle.rebind(StandardRebindOracle.j ava:154) at com.google.gwt.dev.shell.ShellModuleSpaceHost.rebind(ShellModuleSpaceHost.j ava:117) at com.google.gwt.dev.shell.ModuleSpace.rebind(ModuleSpace.java:538) at com.google.gwt.dev.shell.ModuleSpace.rebindAndCreate(ModuleSpace.java:425) at com.google.gwt.dev.shell.GWTBridgeImpl.create(GWTBridgeImpl.java:39) at com.google.gwt.core.client.GWT.create(GWT.java:98) at com.google.ads.syn.adsense.fe.apps.allowandblockads.gwt.settings.testing.Fa keAllowAndBlockAdsSettingsModule.getGwtCreatedInjector(FakeAllowAndBlockAds SettingsModule.java:48) at com.google.ads.syn.adsense.fe.apps.config.gin.ActivityEntryPoint.getActivit yMapProvider(ActivityEntryPoint.java:41) at com.google.ads.syn.adsense.fe.apps.config.gin.ActivityEntryPoint.access$0(A ctivityEntryPoint.java:39) at com.google.ads.syn.adsense.fe.apps.config.gin.ActivityEntryPoint$1.getActiv ity(ActivityEntryPoint.java:52) at com.google.ads.syn.publisher.client.gwt.common.navigation.AbstractActivityC reator$1.onSuccess(AbstractActivityCreator.java:37) at com.google.gwt.core.client.GWT.runAsyncWithoutCodeSplitting(GWT.java:276) at com.google.gwt.core.client.GWT.runAsync(GWT.java:220) at com.google.ads.syn.publisher.client.gwt.common.navigation.AbstractActivityC reator.createActivity(AbstractActivityCreator.java:29) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.getActivityAndStart(NavigationController.java:245) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.access$6(NavigationController.java:236) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler$2.onSuccess(NavigationController.java:226) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler$2.onSuccess(NavigationController.java:1) at com.google.ads.syn.publisher.client.gwt.common.navigation.StandardApplicati onStarter.prepare(StandardApplicationStarter.java:59) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.initializeAndStartActivity(NavigationController.java:221) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.startActivity(NavigationController.java:211) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.startActivity(NavigationController.java:173) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.autoStartIfNeeded(NavigationController.java:143) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.install(NavigationController.java:137) at com.google.ads.syn.publisher.client.gwt.common.ActivityInstaller.install(Ac tivityInstaller.java:67) at com.google.ads.syn.adsense.fe.apps.config.gin.ActivityEntryPoint.onModuleLo ad(ActivityEntryPoint.java:49) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:3 9) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImp l.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at com.google.gwt.dev.shell.ModuleSpace.onLoad(ModuleSpace.java:380) at com.google.gwt.dev.shell.OophmSessionHandler.loadModule(OophmSessionHandler .java:172) at com.google.gwt.dev.shell.BrowserChannelServer.processConnection(BrowserChan nelServer.java:345) at com.google.gwt.dev.shell.BrowserChannelServer.run(BrowserChannelServer.java :192) at java.lang.Thread.run(Thread.java:619) so I debugged the generation process, and it turns out that in createImplicitBinding the "keyUtil.getRawClassType" call returns null because the object in the "allTypes" map in TypeOracle can be found with the name resulting from the substitution of both "$" with dots (i.e. both the one for the inclusion of the gin module class in the entry point one and one for the inclusion of the bound class in the gin module, but the replace in KeyUtil only changes the second one. Obvious workaround: move the class definition out of the inner class and at its same level (i.e.: as an inner class of the EntryPoint itself).

Not entirely sure, but I think the way NameGenerator#binaryNameToSourceName works has a bug in that it only replaces the last "$". In my case, I had a Gin module that was a static inner class of my entry point class, and a second class that was a static inner class of the Gin module. Something like: public class A extends EntryPoint { [...] public static class SomeGinModule extends AbstractGinModule { protected void configure() { [...] bind(new TypeLiteral<SomeInterface>).toProvider(ModelProvider.class); [...] } private static class ModelProvider implements Provider<SomeClass> { [..] } } } I had this exception at generation phase: java.lang.NullPointerException: null at com.google.gwt.inject.rebind.BindingsProcessor.createImplicitBinding(Bindin gsProcessor.java:425) at com.google.gwt.inject.rebind.BindingsProcessor.createImplicitBindingForUnre solved(BindingsProcessor.java:231) at com.google.gwt.inject.rebind.BindingsProcessor.createImplicitBindingsForUnr esolved(BindingsProcessor.java:219) at com.google.gwt.inject.rebind.BindingsProcessor.process(BindingsProcessor.ja va:211) at com.google.gwt.inject.rebind.GinjectorGeneratorImpl.generate(GinjectorGener atorImpl.java:76) at com.google.gwt.inject.rebind.GinjectorGenerator.generate(GinjectorGenerator .java:47) at com.google.gwt.dev.cfg.RuleGenerateWith.realize(RuleGenerateWith.java:49) at com.google.gwt.dev.shell.StandardRebindOracle$Rebinder.tryRebind(StandardRe bindOracle.java:108) at com.google.gwt.dev.shell.StandardRebindOracle$Rebinder.rebind(StandardRebin dOracle.java:54) at com.google.gwt.dev.shell.StandardRebindOracle.rebind(StandardRebindOracle.j ava:154) at com.google.gwt.dev.shell.ShellModuleSpaceHost.rebind(ShellModuleSpaceHost.j ava:117) at com.google.gwt.dev.shell.ModuleSpace.rebind(ModuleSpace.java:538) at com.google.gwt.dev.shell.ModuleSpace.rebindAndCreate(ModuleSpace.java:425) at com.google.gwt.dev.shell.GWTBridgeImpl.create(GWTBridgeImpl.java:39) at com.google.gwt.core.client.GWT.create(GWT.java:98) at com.google.ads.syn.adsense.fe.apps.allowandblockads.gwt.settings.testing.Fa keAllowAndBlockAdsSettingsModule.getGwtCreatedInjector(FakeAllowAndBlockAds SettingsModule.java:48) at com.google.ads.syn.adsense.fe.apps.config.gin.ActivityEntryPoint.getActivit yMapProvider(ActivityEntryPoint.java:41) at com.google.ads.syn.adsense.fe.apps.config.gin.ActivityEntryPoint.access$0(A ctivityEntryPoint.java:39) at com.google.ads.syn.adsense.fe.apps.config.gin.ActivityEntryPoint$1.getActiv ity(ActivityEntryPoint.java:52) at com.google.ads.syn.publisher.client.gwt.common.navigation.AbstractActivityC reator$1.onSuccess(AbstractActivityCreator.java:37) at com.google.gwt.core.client.GWT.runAsyncWithoutCodeSplitting(GWT.java:276) at com.google.gwt.core.client.GWT.runAsync(GWT.java:220) at com.google.ads.syn.publisher.client.gwt.common.navigation.AbstractActivityC reator.createActivity(AbstractActivityCreator.java:29) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.getActivityAndStart(NavigationController.java:245) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.access$6(NavigationController.java:236) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler$2.onSuccess(NavigationController.java:226) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler$2.onSuccess(NavigationController.java:1) at com.google.ads.syn.publisher.client.gwt.common.navigation.StandardApplicati onStarter.prepare(StandardApplicationStarter.java:59) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.initializeAndStartActivity(NavigationController.java:221) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.startActivity(NavigationController.java:211) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.startActivity(NavigationController.java:173) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.autoStartIfNeeded(NavigationController.java:143) at com.google.ads.syn.publisher.client.gwt.common.navigation.NavigationControl ler.install(NavigationController.java:137) at com.google.ads.syn.publisher.client.gwt.common.ActivityInstaller.install(Ac tivityInstaller.java:67) at com.google.ads.syn.adsense.fe.apps.config.gin.ActivityEntryPoint.onModuleLo ad(ActivityEntryPoint.java:49) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:3 9) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImp l.java:25) at java.lang.reflect.Method.invoke(Method.java:597) at com.google.gwt.dev.shell.ModuleSpace.onLoad(ModuleSpace.java:380) at com.google.gwt.dev.shell.OophmSessionHandler.loadModule(OophmSessionHandler .java:172) at com.google.gwt.dev.shell.BrowserChannelServer.processConnection(BrowserChan nelServer.java:345) at com.google.gwt.dev.shell.BrowserChannelServer.run(BrowserChannelServer.java :192) at java.lang.Thread.run(Thread.java:619) so I debugged the generation process, and it turns out that in createImplicitBinding the "keyUtil.getRawClassType" call returns null because the object in the "allTypes" map in TypeOracle can be found with the name resulting from the substitution of both "$" with dots (i.e. both the one for the inclusion of the gin module class in the entry point one and one for the inclusion of the bound class in the gin module, but the replace in KeyUtil only changes the second one. Obvious workaround: move the class definition out of the inner class and at its same level (i.e.: as an inner class of the EntryPoint itself).

Today

Yesterday

Last 7 days

Last 30 days

Earlier this year