My favorites | Sign in
Google
                
New issue | Search
for
| Advanced search | Search tips
Tip: To search for issues containing "18", use quotation marks.
Issue 18: In googlemerchantcalculations.php, <gift-result> is being sent instead of <gift-certificate-result>
1 person starred this issue and may be notified of changes.
Status:  Fixed
Owner:  ----
Closed:  Oct 2007
Type-Defect
Priority-Medium


Sign in to add a comment
 
Reported by kwiens2, Oct 02, 2007
What steps will reproduce the problem?
1. Use responsehandlerdemo.php
2. Replace coupons with gift certificates
3. Try to use a gift certificate with google checkout.

What is the expected output? What do you see instead?
Google checkout expects <gift-certificate-result>,
googlemerchantcalculations.php sends <gift-result>

What version of the product are you using? On what operating system?
1.2.5a
 
Comment 1 by rovagn...@gmail.com, Oct 03, 2007
hey, good catch!

next version will have that fixed! thx

ropu
Status: Fixed
Comment 2 by rovagn...@gmail.com, Oct 03, 2007
patch:

line 77 
replace:
          foreach($result->giftcert_arr as $curr_gift) {
            $xml_data->Push('gift-result');  
            $xml_data->Element('valid', $curr_gift->gift_valid);
            $xml_data->Element('code', $curr_gift->gift_code);
            $xml_data->Element('calculated-amount', $curr_gift->gift_amount, 
                array('currency'=> $this->currency));
            $xml_data->Element('message', $curr_gift->gift_message);
            $xml_data->Pop('gift-result');  
          }

with:

          foreach($result->giftcert_arr as $curr_gift) {
            $xml_data->Push('gift-certificate-result');  
            $xml_data->Element('valid', $curr_gift->gift_valid);
            $xml_data->Element('code', $curr_gift->gift_code);
            $xml_data->Element('calculated-amount', $curr_gift->gift_amount, 
                array('currency'=> $this->currency));
            $xml_data->Element('message', $curr_gift->gift_message);
            $xml_data->Pop('gift-certificate-result');  
          }
Comment 3 by rodnet, May 19, 2008
This issue is still present in the latest version of the zip.
Sign in to add a comment